diff mbox

[dpdk-dev] lib: clear experimental version tag in linker scripts

Message ID 20180427151756.22028-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit April 27, 2018, 3:17 p.m. UTC 
  Remove version tag from experimental block in linker version scripts
(.map files).

That label is not used by linker and information only. It is useful
for version blocks but not useful for experimental block but confusing.
Removing those labels.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/dpaa/rte_pmd_dpaa_version.map      | 4 +---
 lib/librte_cryptodev/rte_cryptodev_version.map | 2 +-
 lib/librte_eal/rte_eal_version.map             | 2 +-
 lib/librte_ethdev/rte_ethdev_version.map       | 2 +-
 lib/librte_eventdev/rte_eventdev_version.map   | 2 +-
 lib/librte_mbuf/rte_mbuf_version.map           | 3 +--
 lib/librte_mempool/rte_mempool_version.map     | 3 +--
 lib/librte_meter/rte_meter_version.map         | 2 +-
 lib/librte_net/rte_net_version.map             | 2 +-
 lib/librte_pipeline/rte_pipeline_version.map   | 2 +-
 lib/librte_vhost/rte_vhost_version.map         | 2 +-
 11 files changed, 11 insertions(+), 15 deletions(-)

Comments

Neil Horman April 27, 2018, 3:42 p.m. UTC | #1 
On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote:
> Remove version tag from experimental block in linker version scripts
> (.map files).
> 
> That label is not used by linker and information only. It is useful
> for version blocks but not useful for experimental block but confusing.
> Removing those labels.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Neil Horman <nhorman@tuxdriver.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/dpaa/rte_pmd_dpaa_version.map      | 4 +---
>  lib/librte_cryptodev/rte_cryptodev_version.map | 2 +-
>  lib/librte_eal/rte_eal_version.map             | 2 +-
>  lib/librte_ethdev/rte_ethdev_version.map       | 2 +-
>  lib/librte_eventdev/rte_eventdev_version.map   | 2 +-
>  lib/librte_mbuf/rte_mbuf_version.map           | 3 +--
>  lib/librte_mempool/rte_mempool_version.map     | 3 +--
>  lib/librte_meter/rte_meter_version.map         | 2 +-
>  lib/librte_net/rte_net_version.map             | 2 +-
>  lib/librte_pipeline/rte_pipeline_version.map   | 2 +-
>  lib/librte_vhost/rte_vhost_version.map         | 2 +-
>  11 files changed, 11 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map
> index 3b937b10f..c7ad4030a 100644
> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map
> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map
> @@ -9,6 +9,4 @@ EXPERIMENTAL {
>  	dpaa_eth_eventq_attach;
>  	dpaa_eth_eventq_detach;
>  	rte_pmd_dpaa_set_tx_loopback;
> -
> -	local: *;
Are you sure you meant to remove this local tag?  

Everything else looks good

Neil
Ferruh Yigit April 27, 2018, 3:55 p.m. UTC | #2 
On 4/27/2018 4:42 PM, Neil Horman wrote:
> On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote:
>> Remove version tag from experimental block in linker version scripts
>> (.map files).
>>
>> That label is not used by linker and information only. It is useful
>> for version blocks but not useful for experimental block but confusing.
>> Removing those labels.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Neil Horman <nhorman@tuxdriver.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> ---
>>  drivers/net/dpaa/rte_pmd_dpaa_version.map      | 4 +---
>>  lib/librte_cryptodev/rte_cryptodev_version.map | 2 +-
>>  lib/librte_eal/rte_eal_version.map             | 2 +-
>>  lib/librte_ethdev/rte_ethdev_version.map       | 2 +-
>>  lib/librte_eventdev/rte_eventdev_version.map   | 2 +-
>>  lib/librte_mbuf/rte_mbuf_version.map           | 3 +--
>>  lib/librte_mempool/rte_mempool_version.map     | 3 +--
>>  lib/librte_meter/rte_meter_version.map         | 2 +-
>>  lib/librte_net/rte_net_version.map             | 2 +-
>>  lib/librte_pipeline/rte_pipeline_version.map   | 2 +-
>>  lib/librte_vhost/rte_vhost_version.map         | 2 +-
>>  11 files changed, 11 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> index 3b937b10f..c7ad4030a 100644
>> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map
>> @@ -9,6 +9,4 @@ EXPERIMENTAL {
>>  	dpaa_eth_eventq_attach;
>>  	dpaa_eth_eventq_detach;
>>  	rte_pmd_dpaa_set_tx_loopback;
>> -
>> -	local: *;
> Are you sure you meant to remove this local tag?  

Yes, it was a duplicate, above DPDK_17.11 one has it already.

> 
> Everything else looks good
> 
> Neil
>
Neil Horman April 27, 2018, 7:30 p.m. UTC | #3 
On Fri, Apr 27, 2018 at 04:55:20PM +0100, Ferruh Yigit wrote:
> On 4/27/2018 4:42 PM, Neil Horman wrote:
> > On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote:
> >> Remove version tag from experimental block in linker version scripts
> >> (.map files).
> >>
> >> That label is not used by linker and information only. It is useful
> >> for version blocks but not useful for experimental block but confusing.
> >> Removing those labels.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >> ---
> >> Cc: Neil Horman <nhorman@tuxdriver.com>
> >> Cc: Thomas Monjalon <thomas@monjalon.net>
> >> ---
> >>  drivers/net/dpaa/rte_pmd_dpaa_version.map      | 4 +---
> >>  lib/librte_cryptodev/rte_cryptodev_version.map | 2 +-
> >>  lib/librte_eal/rte_eal_version.map             | 2 +-
> >>  lib/librte_ethdev/rte_ethdev_version.map       | 2 +-
> >>  lib/librte_eventdev/rte_eventdev_version.map   | 2 +-
> >>  lib/librte_mbuf/rte_mbuf_version.map           | 3 +--
> >>  lib/librte_mempool/rte_mempool_version.map     | 3 +--
> >>  lib/librte_meter/rte_meter_version.map         | 2 +-
> >>  lib/librte_net/rte_net_version.map             | 2 +-
> >>  lib/librte_pipeline/rte_pipeline_version.map   | 2 +-
> >>  lib/librte_vhost/rte_vhost_version.map         | 2 +-
> >>  11 files changed, 11 insertions(+), 15 deletions(-)
> >>
> >> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map
> >> index 3b937b10f..c7ad4030a 100644
> >> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map
> >> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map
> >> @@ -9,6 +9,4 @@ EXPERIMENTAL {
> >>  	dpaa_eth_eventq_attach;
> >>  	dpaa_eth_eventq_detach;
> >>  	rte_pmd_dpaa_set_tx_loopback;
> >> -
> >> -	local: *;
> > Are you sure you meant to remove this local tag?  
> 
> Yes, it was a duplicate, above DPDK_17.11 one has it already.
> 
copy that, thanks
Acked-by: Neil Horman <nhorman@tuxdriver.com>

> > 
> > Everything else looks good
> > 
> > Neil
> > 
> 
>
Thomas Monjalon May 14, 2018, 1:41 a.m. UTC | #4 
27/04/2018 21:30, Neil Horman:
> On Fri, Apr 27, 2018 at 04:55:20PM +0100, Ferruh Yigit wrote:
> > On 4/27/2018 4:42 PM, Neil Horman wrote:
> > > On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote:
> > >> Remove version tag from experimental block in linker version scripts
> > >> (.map files).
> > >>
> > >> That label is not used by linker and information only. It is useful
> > >> for version blocks but not useful for experimental block but confusing.
> > >> Removing those labels.
> > >>
> > >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks.

Note: recent rte_sched experimental block has been updated too.
diff mbox

Patch

diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map
index 3b937b10f..c7ad4030a 100644
--- a/drivers/net/dpaa/rte_pmd_dpaa_version.map
+++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map
@@ -9,6 +9,4 @@  EXPERIMENTAL {
 	dpaa_eth_eventq_attach;
 	dpaa_eth_eventq_detach;
 	rte_pmd_dpaa_set_tx_loopback;
-
-	local: *;
-} DPDK_17.11;
+};
diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map
index 560e46411..da6905ee6 100644
--- a/lib/librte_cryptodev/rte_cryptodev_version.map
+++ b/lib/librte_cryptodev/rte_cryptodev_version.map
@@ -91,4 +91,4 @@  EXPERIMENTAL {
 
 	rte_cryptodev_sym_session_get_private_data;
 	rte_cryptodev_sym_session_set_private_data;
-} DPDK_17.11;
+};
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 859723974..19ec04438 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -311,4 +311,4 @@  EXPERIMENTAL {
 	rte_vfio_container_group_bind;
 	rte_vfio_container_group_unbind;
 
-} DPDK_18.02;
+};
diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index 9c9394c58..0569bfe62 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -243,4 +243,4 @@  EXPERIMENTAL {
 	rte_mtr_stats_read;
 	rte_mtr_stats_update;
 
-} DPDK_18.02;
+};
diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
index 3ee28f759..3b9180f76 100644
--- a/lib/librte_eventdev/rte_eventdev_version.map
+++ b/lib/librte_eventdev/rte_eventdev_version.map
@@ -97,4 +97,4 @@  EXPERIMENTAL {
 	rte_event_timer_arm_burst;
 	rte_event_timer_arm_tmo_tick_burst;
 	rte_event_timer_cancel_burst;
-} DPDK_18.05;
+};
diff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map
index 2e056d994..1bb9538db 100644
--- a/lib/librte_mbuf/rte_mbuf_version.map
+++ b/lib/librte_mbuf/rte_mbuf_version.map
@@ -44,5 +44,4 @@  EXPERIMENTAL {
 	rte_mbuf_set_user_mempool_ops;
 	rte_mbuf_user_mempool_ops;
 	rte_pktmbuf_pool_create_by_ops;
-
-} DPDK_16.11;
+};
diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
index 1c406b5b0..7091b954b 100644
--- a/lib/librte_mempool/rte_mempool_version.map
+++ b/lib/librte_mempool/rte_mempool_version.map
@@ -63,5 +63,4 @@  EXPERIMENTAL {
 	global:
 
 	rte_mempool_ops_get_info;
-
-} DPDK_18.05;
+};
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index 391b80c82..2873a723d 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -17,4 +17,4 @@  EXPERIMENTAL {
 	rte_meter_srtcm_profile_config;
 	rte_meter_trtcm_profile_config;
 
-} DPDK_2.0;
+};
diff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map
index 8bc57d51c..26c06e7c7 100644
--- a/lib/librte_net/rte_net_version.map
+++ b/lib/librte_net/rte_net_version.map
@@ -18,4 +18,4 @@  EXPERIMENTAL {
 
 	rte_net_make_rarp_packet;
 	rte_net_skip_ip6_ext;
-} DPDK_17.05;
+};
diff --git a/lib/librte_pipeline/rte_pipeline_version.map b/lib/librte_pipeline/rte_pipeline_version.map
index 53d31a9cb..129ae5330 100644
--- a/lib/librte_pipeline/rte_pipeline_version.map
+++ b/lib/librte_pipeline/rte_pipeline_version.map
@@ -73,4 +73,4 @@  EXPERIMENTAL {
 	rte_table_action_time_read;
 	rte_table_action_ttl_read;
 
-} DPDK_16.04;
+};
diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
index 8243bcabf..da220dd02 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -82,4 +82,4 @@  EXPERIMENTAL {
 	rte_vhost_crypto_finalize_requests;
 	rte_vhost_crypto_set_zero_copy;
 	rte_vhost_va_from_guest_pa;
-} DPDK_18.02;
+};