From patchwork Thu Apr 26 23:16:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 39070 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08F4D8E1C; Fri, 27 Apr 2018 01:17:09 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 23C518DB5 for ; Fri, 27 Apr 2018 01:17:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 16:17:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,332,1520924400"; d="scan'208";a="223740459" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by fmsmga006.fm.intel.com with ESMTP; 26 Apr 2018 16:17:03 -0700 From: Ferruh Yigit To: Beilei Xing , Qi Zhang , Wenzhuo Lu , Konstantin Ananyev Cc: dev@dpdk.org, Ferruh Yigit , declan.doherty@intel.com Date: Fri, 27 Apr 2018 00:16:47 +0100 Message-Id: <20180426231647.239502-2-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180426231647.239502-1-ferruh.yigit@intel.com> References: <20180426231647.239502-1-ferruh.yigit@intel.com> Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix segfault while devarg parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" device.devargs can be null, don't access device.devargs->args without null check. Fixes: 3be5d686539c ("net/ixgbe: add support for representor ports") Signed-off-by: Ferruh Yigit --- Cc: declan.doherty@intel.com --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 15686da10..6088c7e48 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1729,9 +1729,12 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, struct rte_eth_devargs eth_da; int i, retval; - retval = rte_eth_devargs_parse(pci_dev->device.devargs->args, ð_da); - if (retval) - return retval; + if (pci_dev->device.devargs) { + retval = rte_eth_devargs_parse(pci_dev->device.devargs->args, + ð_da); + if (retval) + return retval; + } /* physical port net_bdf_port */ snprintf(name, sizeof(name), "net_%s_%d", pci_dev->device.name, 0);