From patchwork Wed Apr 18 00:00:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 38387 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A65D8E82; Wed, 18 Apr 2018 02:00:35 +0200 (CEST) Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) by dpdk.org (Postfix) with ESMTP id 219748E7E for ; Wed, 18 Apr 2018 02:00:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1510; q=dns/txt; s=iport; t=1524009634; x=1525219234; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=iGYNm+/VXfETO4WP7O0PH+Oq5sMaed6GYgCnSNMQZfE=; b=O2+qJjL3cCSw+OqLyXiCuf2U0vy5L9GKasCeW8uY0iJ5+hyBfZFHUeAr dfm2EailaoLWUw45M+I+nPBggok4TQPpVxicd+Pxb7UMGrdemRH/Uu8O1 4zZLaAy5Y3qUH8UvFSGMKt8kd7xM3JSezAO4EESTQ6FMSINxG8Y/0H7EI 0=; X-IronPort-AV: E=Sophos;i="5.48,464,1517875200"; d="scan'208";a="101041759" Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2018 00:00:23 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id w3I00MWN024011; Wed, 18 Apr 2018 00:00:23 GMT Received: by cisco.com (Postfix, from userid 392789) id BAE6020F2001; Tue, 17 Apr 2018 17:00:22 -0700 (PDT) From: John Daley To: ferruh.yigit@intel.com Cc: dev@dpdk.org, John Daley Date: Tue, 17 Apr 2018 17:00:20 -0700 Message-Id: <20180418000020.6229-1-johndale@cisco.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180417235324.25315-1-johndale@cisco.com> References: <20180417235324.25315-1-johndale@cisco.com> Subject: [dpdk-dev] [PATCH v2] net/enic: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A local variable was used without initialization and triggered a coverity issue. Is is fixed here, but there is no ill effect of not initializing the variable in this case. 'rxq_interrupt_offset' is irrelevant if 'rxq_interrupt_enable' is not set (the condition caught by coverity). Fixes: fc2c8c0668fd ("net/enic: use Tx completion index instead of messages") Coverity issue: 268314 Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- v2: fix typo drivers/net/enic/enic_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 822037ce8..2a2269794 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -200,15 +200,14 @@ void enic_init_vnic_resources(struct enic *enic) unsigned int error_interrupt_enable = 1; unsigned int error_interrupt_offset = 0; unsigned int rxq_interrupt_enable = 0; - unsigned int rxq_interrupt_offset; + unsigned int rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; unsigned int index = 0; unsigned int cq_idx; struct vnic_rq *data_rq; - if (enic->rte_dev->data->dev_conf.intr_conf.rxq) { + if (enic->rte_dev->data->dev_conf.intr_conf.rxq) rxq_interrupt_enable = 1; - rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; - } + for (index = 0; index < enic->rq_count; index++) { cq_idx = enic_cq_rq(enic, enic_rte_rq_idx_to_sop_idx(index));