From patchwork Tue Apr 3 13:04:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 36945 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2D441B730; Tue, 3 Apr 2018 15:05:07 +0200 (CEST) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 001681B6E8 for ; Tue, 3 Apr 2018 15:04:56 +0200 (CEST) Received: from glumotte.dev.6wind.com. (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id A81F015588F; Tue, 3 Apr 2018 15:03:52 +0200 (CEST) From: Olivier Matz To: dev@dpdk.org Cc: Anatoly Burakov Date: Tue, 3 Apr 2018 15:04:39 +0200 Message-Id: <20180403130439.11151-5-olivier.matz@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180403130439.11151-1-olivier.matz@6wind.com> References: <20180403130439.11151-1-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH v2 4/4] eal: set affinity for control threads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz Reviewed-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_thread.c | 22 +++++++++++++++++++++- lib/librte_eal/common/include/rte_lcore.h | 4 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c index 575b03e9d..3368fabc3 100644 --- a/lib/librte_eal/common/eal_common_thread.c +++ b/lib/librte_eal/common/eal_common_thread.c @@ -16,6 +16,7 @@ #include #include +#include "eal_private.h" #include "eal_thread.h" RTE_DECLARE_PER_LCORE(unsigned , _socket_id); @@ -169,7 +170,9 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name, .start_routine = start_routine, .arg = arg, }; - int ret; + unsigned int lcore_id; + rte_cpuset_t cpuset; + int cpu_found, ret; pthread_barrier_init(¶ms.configured, NULL, 2); @@ -183,6 +186,23 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name, goto fail; } + cpu_found = 0; + CPU_ZERO(&cpuset); + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + if (eal_cpu_detected(lcore_id) && + rte_lcore_has_role(lcore_id, ROLE_OFF)) { + CPU_SET(lcore_id, &cpuset); + cpu_found = 1; + } + } + /* if no detected cpu is off, use master core */ + if (!cpu_found) + CPU_SET(rte_get_master_lcore(), &cpuset); + + ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset); + if (ret < 0) + goto fail; + pthread_barrier_wait(¶ms.configured); return 0; diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h index f3d9bbb91..354717c5d 100644 --- a/lib/librte_eal/common/include/rte_lcore.h +++ b/lib/librte_eal/common/include/rte_lcore.h @@ -249,7 +249,9 @@ int rte_thread_setname(pthread_t id, const char *name); /** * Create a control thread. * - * Wrapper to pthread_create() and pthread_setname_np(). + * Wrapper to pthread_create(), pthread_setname_np() and + * pthread_setaffinity_np(). The dataplane and service lcores are + * excluded from the affinity of the new thread. * * @param thread * Filled with the thread id of the new created thread.