From patchwork Mon Mar 26 10:12:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 36508 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E1ABA5F22; Mon, 26 Mar 2018 12:12:52 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0084.outbound.protection.outlook.com [104.47.2.84]) by dpdk.org (Postfix) with ESMTP id 99C605F1D; Mon, 26 Mar 2018 12:12:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SMadTVlHgpzIKVpKEvztW59N2rgMQw+nGAvE3AP//BA=; b=pA7tIftl0ocIdPRRjR0SArYaYkqhz1XZeqtWA4oeKc9EsaTlSaIfHj7t9M/yDTYN5Z+Op0t7nHzwhmGRfQqLGwbCC5nTGlKUINqPXYtGqodyduitZ8sYZBtFOpJujtGGIsCFt3C9lY3Igho5S80HYZT9P/o+XNbELnQO8QXDZIY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by AM0PR05MB4420.eurprd05.prod.outlook.com (2603:10a6:208:5a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Mon, 26 Mar 2018 10:12:49 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org Date: Mon, 26 Mar 2018 13:12:18 +0300 Message-Id: <20180326101219.91229-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: VI1PR0102CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:802::26) To AM0PR05MB4420.eurprd05.prod.outlook.com (2603:10a6:208:5a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0a9cbb60-80f0-4f0b-59ea-08d593022170 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4420; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 3:ZycHU75/uD/PbG4p3ooDal4wm5yKRtOusp8cbVLPx0YTKA94JIbb4lol3Qor4W0coN8pylK8O2YSMKwYgB4471ceJwKIy/8afiGbQ6EAHjH3Y9YDz3HcMeLbJZlDabpp4TZbl7mr/XWGd16LY5+uIk2kZsXJyyHxmKwX0vnfxUikTbd8ZtkEqyooJih5eTOSykTJyDHUkbaEDdkYC6UWF5DfUL7g8eJ6a10/mV9bDuY3VPA3q/4G7l4jagt3pEZP; 25:JUs+l3lmLQhR3C2BpmO1rDsKZ8QxPqbfMV5YlOYEp29EbWA0TmvOHWViDjFj726MeXlNjPVQYRq/F9IKK/hnYVmFyKNE1kIO0qOkDhJh8jobZUyzr2Vtd2mNoYLeW4aqWGwrhwptCCwx0dMNlHY5dun4XIDx3yJ7YSV13pNlBiQwZ6vr8vvArhbN+0xINzxsXaKKU93Be64qzhHyo99WWj9vyWI4QDUcIjsEnvQmAL7lyyez89T66LguSgHzC1FwmLv5Y09kbKzdTZMTcMByHWllckZ62lMOVYwAnsw3vHjv99ZgnMvm0cWnSi1+xyFDZlCJ0MxG3ySLr+Gmvd3GuQ==; 31:P/hepVpj2dQPbBo14dqinbXYhumMFtHlGUnliEIqzStKIWiolHRKBO1hfXI2lQe6n4BB3AB2R140EgKzW0M9NxFZvxzyfhQqbCsp9eZZXkRtaoBJsWZ+b8Q7KBWf/YGX7s0dMef7JTfYRb3G5Vp0zDv0MxQX3t25r9uyH6JBvvUGkLQSlrWR0Xhyo0PQ3nm74EJxbXNNxLqJfI4ChjGkHfRmvRs/Ra7gVKMKARgeKsM= X-MS-TrafficTypeDiagnostic: AM0PR05MB4420: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 20:IAMiBruv3+LY4DYG1BsE54xVMLUJNZW7FR+LNxHMrgO0qUJtS4DMkI7E//8WBNd+KJoNLEKExuqd7c26Jt8lWRV7xOOtJp15PvRWa9mk5+G9Npyc5snrMIXteGm/Dcb65OhsO/k6xGVoBiUt2+iUccFQmxX1afFx9oxM2aruyEmv9cKwq0Nx8qz1YQbHho7qwsQPcpcnEUXKEeNUUPEh28WUedBBPXEz305dQLQogmiYqV4FgfnxtOBX4MegAFXONZPcRPhrzdmzSxv+SPISEv7TyRpW56pyaP6YQ4iMvN1Z6IXeBB0PjEVQm+DHB1dmra9LQZVk1WY3wL4yP+PHJtyP6zq8+yys1b1xwkteExh6lGkI5g16ff51qwtmbvBHu8fWCWQj6NmFrElkFKPXYSqegplIfaEv41JBZZnOR8qNayWJIZyNxpIO+6qEc/qxY+CwPyGiAwe4eeQwkgWwMA+d3Xdfc48CTlaC7TMaiuOLYceX8ocHwCvk4+v3CYJE; 4:Dtul5opVfVsBY2/c3L+f41j+482PNYIIgvtqYQ0gjEorRwKo8BsOBXt43yh+SIUTeLyHckMJGq+HWcJRlUh5thAECCIkYujD/Mkf9f2LjxFOdWQJosW9783Pk8IKgy6+Ju+zl2Lfxm2W029bSwTEIq6vCafkmvBE4nQPEO6f1URqtIrL1F5sJKasqcb1cXlz8PqXCMc1hyCpnbaGIHe8KHw6uIDEjHAzCZ4yL1g6Y6AwM02UPG2pnBFhlxqjtXAW2+h5/BPkUqUli53Tz7rUyA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM0PR05MB4420; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4420; X-Forefront-PRVS: 06237E4555 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(16586007)(25786009)(316002)(26005)(186003)(6116002)(3846002)(66066001)(2616005)(956004)(53936002)(16526019)(68736007)(8936002)(48376002)(8676002)(55016002)(81166006)(81156014)(50466002)(52116002)(1076002)(50226002)(2906002)(386003)(478600001)(6636002)(6666003)(105586002)(21086003)(47776003)(59450400001)(5660300001)(86362001)(7736002)(51416003)(106356001)(7696005)(69596002)(4326008)(36756003)(97736004)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4420; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR05MB4420; 23:krHV0MCuOw8uYLKV9LT2+UqNGyOJRobJswKnkIr5z?= qk6v3W9XiM6llTWU+eRR0hzLQxAk1/kR/MVNSXjtTRgJE5sd77kENlikXG3XVJtxSSBi88bmy4blLSuDK6TodKS7GQn8IrluFVTCgNHfQT6YMindklV17V+yLgv7zBCChAVmkCSJcuiY8R9qA5sTuFhUvhBTWDgLkxTQPxUe8Yki/4GvIVhTiGKMQJa0hFOTUXNX9Nj4HicvqSAZrJhtUpn3AwwpgoJ1vnF3IjTyhsBb/gKqpALbMoUB69u869FY6JgAlMOw2IkBpTc1K0P7ZYrv77wOYdIGKxwko0W7JrVXEZ2qmgoQt3//GDaczpCFZCbGfYWMd4NaMf91zFOK+XWVbxUqJY9N4tyBb4+iBQJmSUPURQ/LbjRuvSj7bl1zdgz8rHVBgM/X+us3h/95Hsf8/0W8M0tHWaLkiDLGPRPHOG0rKRgjgGiX6bAz2p6vatExiiDI2d0VR/HjlltTsEFeDYebvsiFr42CM/ue+UhN3q7VqvDAI6ql5cEN4O957ZZ1IgrD77ZPiXx82CkDpT1TsoTzhGnq94nEUZTTz7b/s5MDTn3GPl6wPKSEQKKY7fVN8rlHtgNRiQVhf0QIr8JFJYM29Za06kLRSHeI86ExjK5tb3tPUw9X5e/e+KcQ2lRvMIIQ+DHahzdOfqBYEBLDYdX+lSbZ2dT55qkcMg9nLYzx3GcgaZ2jGyCE7ozcGzK2UtBThdHfHjURz1AGWnembhG8Cn6ACFmnf/40HQQ8/erwhakDwG6XbQ2N0Ee03iCzBwTGdqZl3ps+idTOTVHi+1UkN1XRTk52X2LMXX8x+ZxLjXh5DLAMkhEdnGlHig9KYt/y++tkXoF3Eh0SF7hpHbTean3i6jo6JIS5pZzGGI818zxqtipqoXbq/Ct/87IKom2sZrDSANz5N4dNgXrKZIcb6pPyl0+Bdro6nQgZUurLj5s0oXydMdYFZForxGJErUptV7iBot9Kcy8AgfigPt1TOeI3MWLXpQFOlatUXm6YVVLuC38bE2c7pDROcHTDJ32bcaBbzBh7veCxUtF5ppt1UqbNoAQ466WJazpYojkfp3NNeEJsVe2G9j5BJultJpTCis9XWsyFQm1spvSe5CRFklNIS7loNw6ecBWBw== X-Microsoft-Antispam-Message-Info: fsVlvzLnzHjBz0DJhFDwGIU1MCfFyE55TbM6dil9KPmz/nPgglcExbwu/y7pAs81iCHLVCX/URuwxzMw7TEpEV5NkGw1OtRc/Ga4yalHnM/1zsU/hGUnmyHJt/bhilKfaSfAzwUXY43K8Nz4aFQhmPzHgqMVVqxA9zSUl94uDNbYATFBymJoDXpqC2AjUgvt X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 6:nC21cpl/nn7YNLa+z3YZo1W83D94z4mUiQuhUUTllbBZysEhaz9nKw3qjHKRO/UUwj+yPJdGKT+7PRWM80hnhWHNaWslVIo0QRV3hcCsOVag5HovQZVvaq54uKeSpek5+/95zbKVL1+OLtgX5XuFw4BjgsbMktmKgHhjHh82THewfXkPygGQphLqKNjOicpkVHcrAbIPBYNQTmsSpDgiz/9bUl3lIhLg6lf5o8cZ+oaWzK7oMDT7WJK4hfItd3+Ti7qpFDx3J8AAovcNHjXI7Ny6YtgtNynRVg74Rq4SsVvwYrfno4BA3OtllRmQUuxnLs9+O9weNx/XIuZqtWX7BfvbT/fxWQpuYO6G6tzvkhEguYu4xAyhdS8XPEPczLiqHiRtsw3FM29fJ1gvmi/IHEYd6Gs5x2QtGYo+laVuL5ETPQsw0rxXphyI9busG+w9UtqTlTepQpDTDWekMHyHow==; 5:XxOCF2uNIJJwUgMZIINieJN0/9SYNTPR5tKtKuGKrcLfp32SFRgTR6mV/X2Cvxfv+3qh8LskMAOk2BhnQ/f2Gv+JAct7nLBnqURDcjrxXZE/LozlOdxGkMhtN+CMSDuVixJz/mFizooTmN6BMCkmp7cs++9qRzDH+E9vmd6xMks=; 24:UaWaHwTr8k7PAf0iuyIwGtViIHS2Nhn1WkvZ0uyIhAbiqFNaxAy8xWKzyXDB7wePU3YN5t+hIGRIcRxyYcY2uqUDGE1tYXzHar8JOFcGGTc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 7:/TI6ZnAX11gudxQHzYhP6uh1/uPnDghRndeN9O05i5Z3UKy+5ezZ1zjsOw4G71FfPnhtaxdrpeKVesnzI4+u8B6zoIn3LiDvLPzFPpUAeXltL8x1bigwsG/78nLh6pMCGOwxVOJLsjWCsCvuEa+kFNtPmhcvKkeqt2KwX7pIgbUi7uLE61k71OAbBt5GjehiQtoMjQoa7BHCqRErvc7Jq46YIT3Y6ZqUfurPoe+icUStA+BkrO7nj1gEm9VFouBJ X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2018 10:12:49.4115 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9cbb60-80f0-4f0b-59ea-08d593022170 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4420 Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" RSS hash key must be 40 Bytes long. Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rss.c | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index f5511ce70..365101af9 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -329,7 +329,8 @@ mlx5_dev_configure(struct rte_eth_dev *dev) if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != rss_hash_default_key_len)) { - /* MLX5 RSS only support 40bytes key. */ + DRV_LOG(ERR, "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); rte_errno = EINVAL; return -rte_errno; } diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index 5ac650163..ceaa570ef 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, return -rte_errno; } if (rss_conf->rss_key && rss_conf->rss_key_len) { + if (rss_conf->rss_key_len != rss_hash_default_key_len) { + DRV_LOG(ERR, + "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); + rte_errno = ENOTSUP; + return -rte_errno; + } priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key, rss_conf->rss_key_len, 0); if (!priv->rss_conf.rss_key) {