From patchwork Sun Mar 18 01:45:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 36226 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69D967CFC; Sun, 18 Mar 2018 02:45:59 +0100 (CET) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id DDAEA5F71; Sun, 18 Mar 2018 02:45:57 +0100 (CET) Received: by mail-qk0-f195.google.com with SMTP id s188so14996707qkb.2; Sat, 17 Mar 2018 18:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RQwAiTa9SizxIrImBYHuZqTJNhodEeGrnSLNkIR/77M=; b=fVz7MDHM0QcJ2kqwY6vagLx9xRPFWK7j2Hi+F7x5l9sKcaeyec6pQVmrW/6fb2J7xr Ikk5Pci2051zUgV2E5XIMqMrGi4g74OauDxF6VvmuCb1sJBQ/VN8lQixdCMJ3KzfkR+z oT5iVDj5RbKqPParwAqOOI/dJdpsipO4xZo940+2cHWs1TpKVvwRSbL2jJU9NWloTLLM 2BXD9Kd0SaLZ3cp584aEgjRzfA/Q8gz4k9Xmh1+gtkOL/CTvZOIPjGAAE8OGJvQ2qFB0 eyLmsn1As685q+KNRNxzdjQmTsvN7lt9NzYG08/95ThunoMeFZkgY2/dEgQ5NEu2cphA RHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RQwAiTa9SizxIrImBYHuZqTJNhodEeGrnSLNkIR/77M=; b=TSG1UDXtAXiF6kLWGCFhGznCuW4eMe58YwS43McghEuq2Hab+r3Qv3rV6PurIlkhTp xuOIJx+f6qNVp+h6InbJRajqzzwmk1XXhwOzgM2Cz0gwy1Vi3OP3OTLCQEfqIiXdnYTz +O+XNZ0SgdXKfVVzenwpv6skpHm1dGT+IJQW7dgKbxhksdedQSnPlo7g6Jtnl5xqZlNo M/pSl1Zqs/0vj2H6GMvSHUzsuiSuyzTlyYz/CVWLN0sAGEYOgPFLsSf+0TmLB0Drt+iq KQym5Lxt4RQFMqMJQOdJaFraP1Ze+aeTbsWQQo1iib2LnogqAaQqHNzNo5ZwMEQpDmWh KbXw== X-Gm-Message-State: AElRT7EJB8Eo1TgBCAIkxeJrJ1AO+hVHbtDQ5YXW+NcDN0c4bMKgW/2s g+wBCzqzI3dFTAdLwKxZAQ/Azg== X-Google-Smtp-Source: AG47ELub+LyFaQQwl0vBOjoSpkYlVCmjypdMPIRGLl3vdn/DS36PJmsm+y0qhzuDFVzwT9l46XBWyQ== X-Received: by 10.55.15.221 with SMTP id 90mr10919804qkp.234.1521337557174; Sat, 17 Mar 2018 18:45:57 -0700 (PDT) Received: from monolith.home (pool-173-79-224-159.washdc.fios.verizon.net. [173.79.224.159]) by smtp.gmail.com with ESMTPSA id i129sm7458408qkc.16.2018.03.17.18.45.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 18:45:56 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: skhare@vmware.com, Chas Williams , stable@dpdk.org Date: Sat, 17 Mar 2018 21:45:52 -0400 Message-Id: <20180318014552.16703-1-3chas3@gmail.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] net/vmxnet3: keep link state consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Chas Williams The vmxnet3 never attempts link speed negotiation. As a virtual device the link speed is vague at best. However, it is important for certain applications, like bonding, to see a consistent link_status. 802.3ad requires that only links of the same cost (link speed) be enslaved. Keeping the link status consistent in vmxnet3 avoids races with bonding enslavement. Author: Thomas Monjalon Date: Fri Jan 5 18:38:55 2018 +0100 Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") Cc: stable@dpdk.org Signed-off-by: Chas Williams Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 426008722..48a4d4f98 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev, link.link_status = ETH_LINK_UP; link.link_duplex = ETH_LINK_FULL_DUPLEX; link.link_speed = ETH_SPEED_NUM_10G; - link.link_autoneg = ETH_LINK_AUTONEG; + link.link_autoneg = ETH_LINK_FIXED; return rte_eth_linkstatus_set(dev, &link); }