From patchwork Thu Mar 15 11:00:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 36123 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E2B95F62; Thu, 15 Mar 2018 12:01:17 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0072.outbound.protection.outlook.com [104.47.2.72]) by dpdk.org (Postfix) with ESMTP id 7E46B5F2F; Thu, 15 Mar 2018 12:01:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q00odwOnCP8cUSuyc4yY+DbhwHwPWdV++aNORw04bqI=; b=Hhs0r+ZhJqPg1uYOwDa0uARUz6/ZdhUrWFYEZUgruchBUjGq9AV/1WPFornEhlOCIhiQyL+nFPhTsK77b5mH3YIbZpsVEhspN8Ojp6XvGlQjdlq6/8gcE5rmjB3jgECreDrqhXjhubsKWaPciM3XmQ/PVB3xNIz2ilMoIpGnqX8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4428.eurprd05.prod.outlook.com (2603:10a6:5:1b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Thu, 15 Mar 2018 11:01:10 +0000 From: Shahaf Shuler To: yskoh@mellanox.com, nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 15 Mar 2018 13:00:05 +0200 Message-Id: <20180315110005.14928-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: VI1P189CA0021.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::34) To DB7PR05MB4428.eurprd05.prod.outlook.com (2603:10a6:5:1b::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7f75814b-46a7-45b8-449a-08d58a64104c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4428; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4428; 3:5vBkRWabvhgACfFaUOcHrJRJZPaAduRqDglY+CB7ObIbe29elTVvrFhUOz3qYRILnb4U6ftdSneeDnejkkgifBi64g3vR7hqaG+sFN+93cNVmjTKzuIFWBETGYDnsjJgyDcaJsXU7muiQ+eJ5X7v67gSXLrIR2R+FbKNB5Zw7lywd3UTzDvcKfEUnRJL3/MYQWHoufMFTMOkcyuaPc8/U8qWoguFZoV7WqvES8xesUuDamJZfd3LtEDoUq66KfDz; 25:HpY5gb8swRMeXiYPHta2qo4+OJ5SukpJJZoCUbwyWtamACNrSyQMiAx3WmrJm7jDMlbzRUAOhrMApsjz2XyJ92Hn+tsFbp9C9K79CLqJK/zAt9Xuz/SiV6CDFKdXWeNaodjCbsKtFvWr2iUJ6LQQkaeSK/tMfoMmyrC8N6IW2EkUQYt1JxmOiqZw5TYznFffB0JnBP8GXvLC3SK1bI4pN2yjbWx4fy32g531vv8Pq7hYYFyEDNx+3WmVJYUS6K3vApfQdVmRvkmnKoMQXWKknpCquztIkP7jL4BggRs15yjPgsg9AfCGNcZhlPlz9zkFiGpeZ843AQnc+oCSeVSLEQ==; 31:gof12z+isAA3LRrgPPTi40qp+JY6YKY0PEGSidfZUhF6n31dlzwmP5zv3EMCBqyk6gB41b9QnJ/CuJ2b7m/01MjR6/v51LjD34y15a1eb4GERucdJ49n/OZmAxJ9d6jVTjXDv6xu3wY9CzsVNO028C+Hg+WN14r8+oMDq5M578kWBk/hbel1oTX+X0R19yoiIzVL3BCiwLhV7ddCRfCzsolSz2jyl+WVlg/oGE9h4Xg= X-MS-TrafficTypeDiagnostic: DB7PR05MB4428: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4428; 20:Yr3vB/fz29KCbXd7bjIRFWkUBXsMmg4nIP3YZDFp4snbgOG33MIx4rmW9++LmpWJN8+WoCAQoXUluxnCGGNdJUuZ2NNlF1lWzsQF2wCrP+fErSy/ugwLgrgaIAT5ta/Agnt+XbHRloB3P0ZKwCBrNYsU64Dr+JWPPovmisqk4kwBE1U6zkr2b7nEk5uGz/XYuftBw9wI7VjP7pJFyK4fOLgfzMevRjdnbvIE+XjEFpl8zzQPT8TEnulfR2PXRBIvnxQLT1yugNajSjXI3VQm8FzvsonegWnwnHXjrxDIH1rO7lnvMyBTgYdJhThY+cUM+okCMFJM9076DC0fZZ8Urxnuh5nNL+rDWQmPZQnpstsM+GC1EOsS6XBf7K9piFLzO+615lR6LW+ZhWe+qfCpTueLqkAX8vnBqODuZ8KptYY0heOMOsAYYBBuyW0u3LHlMB3tJdw9a1t9lNIrmgEQHwF9l3ddTt0x+qZ7vMrjlAhjVg+RSlzEoNO4TAJnhx2P; 4:i8JaWuTdooPeeBXSIUr62UBpEuvYLCJfT0nclHurh8tUHzQuGc7s5pT0XXuSi2HvdH/pxm6rW2/F9tHNGd9x/rDhm5QLEYeiGJBlrWO8HCi2WK7dE61Lx0EeNQoF4D7zXmqLoByxFvhfL+yr4Qfq5T8q6qSrgtWnI9ZV000ub7LJD64CTHO+joiE2vwjEgSTcTisskRSjSMQqdyXJMq130hjXrUJHsHExKpU+0cCz92enLP13AMnPns/9Lt/KexlS7FxI1x9MUc5Llofvce0Og== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4428; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4428; X-Forefront-PRVS: 0612E553B4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(346002)(39380400002)(376002)(199004)(189003)(16526019)(55016002)(305945005)(86362001)(81166006)(5660300001)(4326008)(8676002)(25786009)(26005)(1857600001)(69596002)(16586007)(68736007)(97736004)(105586002)(316002)(81156014)(66066001)(59450400001)(386003)(6666003)(51416003)(3846002)(36756003)(1076002)(50226002)(48376002)(50466002)(52116002)(6116002)(7736002)(47776003)(21086003)(8936002)(106356001)(53936002)(478600001)(7696005)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4428; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4428; 23:IuJRfRv+Ey5ncytReTFfhvadZ6+3crwq2U8VjU4ww?= YoIxoKCJohJsupUZdG7YAtlGbcJJCcdrPhCRy2+wsf8PzRQts7I8n0ETgJSmNHnhc74zxlFccNWdz/Hds83OxtKSFt+MPEmym6JDmRiX/Nr9m5z3RMwJx2tASlTyOBKobaqEFqAV/mwFqKBtc+4PQW1pG4VOUR16HLsYvHkilahuHj6ZiTzMSyq5iSgu/PqB9/UYtKeRmSqH7D37RB8fVH7M6OJ/1lVtUvlSfYyvIB7Fs/swyvhxqF5HBdHYrxafG62yoehXxxJogb2roFUlQXz+s1BKTHmhzbTjmPgM6Jowwp9kiWtIE9C31a4XbYG8g3m3lbN//sBOAXmHaedodAZwkOxk942dX/p2+b/M1/wzDlJackjknITLhnF98pbh8hEOHA2cB5kXEi9ducqGA++khjTexw/gxxmaz09g62JMzBxXHrF4Q7cBiFBdCGmsQbjHjV6R8ZgvrOWMjw52XpyLAM/XJspGJONirJWVC8pO02dpRGoR5TWJwGnBttXJgdyjGRgS50westo+ZVR1oWMYqyIDYoTzs9qbFKysDlm394rDgL9qy3cLRpIc1oP/0447KVgr3RP2OTZ7UmTy12vq39cg5KbMHJUHQN71Bu5Gil3Hlng70UALdmCR7iEw2TPPFcuf+52yjnQDH2GFUq/rRaBeMZPa2KGkl5ZXWV+s+cFRaUrDBPjc8uSPnoLk8+qszmNv7K/sVUs8mLUaI4tZjwicOxT0VSTPEH5q51k6EWy1SUJUiWer7wDcF56sW7iKuk1mk23WQd7XfiR9tn8tw+L6yTTyPvXn/TJ0BMqYNDtQ05JNFYhqz8DFsWLzg7mAXD0oAbrHnjQTba2jMGR48UxkO+P6XSC3y2S7Lh+uOInFemD/lRAGYoqXBUDSxgURNq4ctYe521oYQMdXzLknuAPpIMPqo4jTIwvHjKXrUj+EN6ewgyhdnEfChlEycRNxz2HhAaokU8UNu+8NbAhF7TKQdH3VbO/ROBe9i/eHOlHK7N+/Ui1aA5QMoLiDLWpn90cSvf38uBI9jiXW3hv9w67eKfcg2z1/L9tXVz/9UX90EAxcS8dke8agogp5+M= X-Microsoft-Antispam-Message-Info: Miat8QlU6itiB+i8w5D32mHE/J0UnIgT4pgZRKUxL5+gkfjguhfpFwpLyrdRTnKDO1D4RKqUT0ArPJGGE+Ez1xNCFXN1JLDsSDdYy0G49WHKG7d0Wo8R8443dmusExze4CdHC80+LWYYJlYPu3OoCvQc4D/8kMuuCh/iexEuWH6gomIHpwzqvssTCSYkyZPK X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4428; 6:jZlGDwicvI0mhhvaIvmZUSApTEaJ6AOGsjgUCSkxkkhkhsnGP1BE1Gt5zRxqvVPWPCslUVJLXpCztJkOqO7s16BicA/9WtaUyoYGjwkXLWapt9F4kMUpZx00zSJ7B4o6idFIUrXQPYkQ08ePqFCBNUhA39Zx+t8RpJ9yRqY7XpSPMjtEhJFh9BY41j11OVikeYgRsPhfKRuIG4LCtwJpbotvjdWdu0dJyIvXoIuDr36bmUYAq6dUESnCwLYbSFEvWyCeqQazsuq9zLmO5Z5hfQWAPQNg2MByzpiPsrA2Yz2nk6SUogpxDrgcPjtKHqkdTt2Na+39qg0rfj+rk9PiOxdmHYHTVCtmUqDx8w24r4w=; 5:kf6dKyG44tY4VVF4jUipKJmZwPeG62AV+IRH+LTG/KxK1kqV2DAJS3PmDGoLleuHbezzpQPv/CviBqMNNsH1GOGHwbYFfp0KV5wEC+nf5xM8eEZ07lmmAKBW/yAbJtbVL3q8rZIwyyrFI0eTZN/BK5jsUKOiKY+xJ2DqMCTSdNM=; 24:iWN3ahJEwz284SOb7isumREwBFZi2xOco5uT/Cy5rUZP/4DrnmcwC8qQs28LvY9tA+PwaPRj5AEePUJnX0uaE73Jf8n09bMGqukl8cQfSBg=; 7:Ky5HRXxA5lwEcmVWFBna5kCd3jQSRni+89Bn98Y/YDox0AL44Ws80zDBxF3IryU903IUYBDpCdMU73EAr44VFwJESdsALmpNOb0CyhzIh1Qmm9F5B7heQl//O1ITfZEZxsYoqMhduvkdo7DQ985tiStBy+rLEFdJw8CabXRu6PoXtSqghM9wEwlTL1RaUsBHe03mm3VjcPlq3IjTytt60kIja7BBoxM2iFZ7sak5qoELzsj7kWx99+5E/YTT6NNe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2018 11:01:10.7120 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f75814b-46a7-45b8-449a-08d58a64104c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4428 Subject: [dpdk-dev] [PATCH] net/mlx5: fix TSO enablement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" TSO should be set if either of the TSO offload flags is requested. Fixes: dbccb4cddcd2 ("net/mlx5: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_txq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index ed1c713ea..42996e8db 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -651,7 +651,9 @@ txq_set_params(struct mlx5_txq_ctrl *txq_ctrl) unsigned int inline_max_packet_sz; eth_tx_burst_t tx_pkt_burst = priv_select_tx_function(priv, priv->dev); int is_empw_func = is_empw_burst_func(tx_pkt_burst); - int tso = !!(txq_ctrl->txq.offloads & DEV_TX_OFFLOAD_TCP_TSO); + int tso = !!(txq_ctrl->txq.offloads & (DEV_TX_OFFLOAD_TCP_TSO | + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | + DEV_TX_OFFLOAD_GRE_TNL_TSO)); txq_inline = (config->txq_inline == MLX5_ARG_UNSET) ? 0 : config->txq_inline;