[dpdk-dev,1/2] drivers/net: update icc deprecated parameter
Checks
Commit Message
With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
icc: command line remark #10010: option '-wd3656' is deprecated and will
be removed in a future release. See '-help deprecated'
"icc -help deprecated" output is:
-wd use -diag-disable
Based on above information "-wd" converted to "-diag-disable"
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/bnx2x/Makefile | 2 +-
drivers/net/cxgbe/Makefile | 2 +-
drivers/net/e1000/Makefile | 3 ++-
drivers/net/fm10k/Makefile | 3 ++-
drivers/net/i40e/Makefile | 2 +-
drivers/net/ixgbe/Makefile | 5 +++--
drivers/net/qede/Makefile | 4 ++--
drivers/net/sfc/Makefile | 2 +-
drivers/net/sfc/meson.build | 2 +-
drivers/net/vmxnet3/Makefile | 3 ++-
10 files changed, 16 insertions(+), 12 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, March 12, 2018 12:39 PM
> To: Harish Patil <harish.patil@cavium.com>; Rasesh Mody
> <rasesh.mody@cavium.com>; Rahul Lakkireddy
> <rahul.lakkireddy@chelsio.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Shahed Shaikh
> <shahed.shaikh@cavium.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; Shrikrishna Khare <skhare@vmware.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
>
> With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
>
> icc: command line remark #10010: option '-wd3656' is deprecated and will be
> removed in a future release. See '-help deprecated'
>
> "icc -help deprecated" output is:
> -wd use -diag-disable
>
> Based on above information "-wd" converted to "-diag-disable"
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Should this go into the stable branch? These warnings will be present there too.
Apart from this comment:
Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
On 4/11/2018 11:11 AM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Monday, March 12, 2018 12:39 PM
>> To: Harish Patil <harish.patil@cavium.com>; Rasesh Mody
>> <rasesh.mody@cavium.com>; Rahul Lakkireddy
>> <rahul.lakkireddy@chelsio.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>> Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>;
>> Xing, Beilei <beilei.xing@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; Shahed Shaikh
>> <shahed.shaikh@cavium.com>; Andrew Rybchenko
>> <arybchenko@solarflare.com>; Shrikrishna Khare <skhare@vmware.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
>>
>> With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
>>
>> icc: command line remark #10010: option '-wd3656' is deprecated and will be
>> removed in a future release. See '-help deprecated'
>>
>> "icc -help deprecated" output is:
>> -wd use -diag-disable
>>
>> Based on above information "-wd" converted to "-diag-disable"
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Should this go into the stable branch? These warnings will be present there too.
Makes sense, I will update as "fix" patch and will send a new version.
> Apart from this comment:
>
> Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
@@ -18,7 +18,7 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map
LIBABIVER := 1
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS += -wd188 #188: enumerated type mixed with another type
+CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type
endif
#
@@ -49,7 +49,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd188
+CFLAGS_BASE_DRIVER = -diag-disable 188
else
#
# CFLAGS for gcc/clang
@@ -22,7 +22,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd177 -wd181 -wd188 -wd869 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188
+CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259
else
#
# CFLAGS for gcc/clang
@@ -19,7 +19,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
@@ -24,7 +24,7 @@ LIBABIVER := 2
# to disable warnings
#
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS_BASE_DRIVER = -wd593 -wd188
+CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
@@ -20,9 +20,10 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
-CFLAGS_ixgbe_rxtx.o += -wd3656
+CFLAGS_ixgbe_rxtx.o += -diag-disable 3656
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
@@ -73,8 +73,8 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
else #ICC
-CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another type
-CFLAGS_qede_ethdev.o += -wd279 #279: controlling expression is constant
+CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type
+CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant
endif
#
@@ -46,7 +46,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
# Suppress ICC false positive warning on 'bulk' may be used before its
# value is set
-CFLAGS_sfc_ef10_tx.o += -wd3656
+CFLAGS_sfc_ef10_tx.o += -diag-disable 3656
endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
@@ -32,7 +32,7 @@ extra_flags += [
# Suppress ICC false positive warning on 'bulk' may be used before its
# value is set
-extra_flags += '-wd3656'
+extra_flags += '-diag-disable 3656'
foreach flag: extra_flags
if cc.has_argument(flag)
@@ -15,7 +15,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#