From patchwork Mon Feb 26 19:20:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Horman X-Patchwork-Id: 35432 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 982AF325F; Mon, 26 Feb 2018 20:20:55 +0100 (CET) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 378081D7 for ; Mon, 26 Feb 2018 20:20:54 +0100 (CET) Received: from cpe-2606-a000-111b-40b7-640c-26a-4e16-9225.dyn6.twc.com ([2606:a000:111b:40b7:640c:26a:4e16:9225] helo=hmswarspite.think-freely.org) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1eqOKK-0007KN-Gr; Mon, 26 Feb 2018 14:20:51 -0500 Received: from hmswarspite.think-freely.org (localhost [127.0.0.1]) by hmswarspite.think-freely.org (8.15.2/8.15.2) with ESMTP id w1QJKAos030269; Mon, 26 Feb 2018 14:20:10 -0500 Received: (from nhorman@localhost) by hmswarspite.think-freely.org (8.15.2/8.15.2/Submit) id w1QJK9SP030267; Mon, 26 Feb 2018 14:20:09 -0500 From: Neil Horman To: dev@dpdk.org Cc: Neil Horman , Thomas Monjalon , Ferruh Yigit , Hemant Agrawal Date: Mon, 26 Feb 2018 14:20:01 -0500 Message-Id: <20180226192001.30220-1-nhorman@tuxdriver.com> X-Mailer: git-send-email 2.14.3 X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed libraries for dpaa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When preforming a shared library build, if the dpaa pmd is configured, the build fails when linking testpmd. This occurs because the makefile fails to include dependent libraries dpaa_mempool and dpaa_bus. Fix is to simply include them in the makefile. We could perhaps fix this more generally by using the copy-dt-needed-entries linker option, but doing so has a significant effect on link order, which may be undesireable. Given this is fairly isolated, and that we have precident for this (see rte.app.mk), just add the needed libraries for this specific app Signed-off-by: Neil Horman CC: Thomas Monjalon CC: Ferruh Yigit CC: Hemant Agrawal --- app/test-pmd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index ed588ab6d..77a02ca0d 100644 --- a/app/test-pmd/Makefile +++ b/app/test-pmd/Makefile @@ -45,7 +45,7 @@ LDLIBS += -lrte_pmd_bond endif ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y) -LDLIBS += -lrte_pmd_dpaa +LDLIBS += -lrte_pmd_dpaa -lrte_bus_dpaa -lrte_mempool_dpaa endif ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)