diff mbox

[dpdk-dev] net/mlx5: revert support in IPv4 time-to-live filter

Message ID 20180207142336.95200-1-shahafs@mellanox.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shahaf Shuler Feb. 7, 2018, 2:23 p.m. UTC 
  Nor upstream kernel nor MLNX_OFED support such filter.

Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
Cc: nelio.laranjeiro@6wind.com

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 doc/guides/rel_notes/release_18_02.rst | 1 -
 drivers/net/mlx5/mlx5_flow.c           | 1 -
 2 files changed, 2 deletions(-)

Comments

Nélio Laranjeiro Feb. 8, 2018, 12:26 p.m. UTC | #1 
On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
> Nor upstream kernel nor MLNX_OFED support such filter.
> 
> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
> Cc: nelio.laranjeiro@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  doc/guides/rel_notes/release_18_02.rst | 1 -
>  drivers/net/mlx5/mlx5_flow.c           | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
> index 32067969f..0d4630335 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -94,7 +94,6 @@ New Features
>    * Improved multi-segment packet performance.
>    * Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs.
>    * Extended statistics for physical port packet/byte counters.
> -  * Supported IPv4 time-to-live filter.
>    * Converted to the new offloads API.
>    * Supported device removal check operation.
>  
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 822705060..f88ece123 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
>  				.dst_addr = -1,
>  				.type_of_service = -1,
>  				.next_proto_id = -1,
> -				.time_to_live = -1,
>  			},
>  		},
>  		.default_mask = &rte_flow_item_ipv4_mask,
> -- 
> 2.12.0


Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Ferruh Yigit Feb. 8, 2018, 2:35 p.m. UTC | #2 
On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
>> Nor upstream kernel nor MLNX_OFED support such filter.
>>
>> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
>> Cc: nelio.laranjeiro@6wind.com
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-net/master, thanks.
Thomas Monjalon Feb. 8, 2018, 2:38 p.m. UTC | #3 
08/02/2018 15:35, Ferruh Yigit:
> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
> > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
> >> Nor upstream kernel nor MLNX_OFED support such filter.
> >>
> >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
> >> Cc: nelio.laranjeiro@6wind.com
> >>
> >> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > 
> > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> Applied to dpdk-next-net/master, thanks.

Have you applied the v1 or v2?
Ferruh Yigit Feb. 8, 2018, 2:47 p.m. UTC | #4 
On 2/8/2018 2:38 PM, Thomas Monjalon wrote:
> 08/02/2018 15:35, Ferruh Yigit:
>> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
>>> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
>>>> Nor upstream kernel nor MLNX_OFED support such filter.
>>>>
>>>> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
>>>> Cc: nelio.laranjeiro@6wind.com
>>>>
>>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>>>
>>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>> Applied to dpdk-next-net/master, thanks.
> 
> Have you applied the v1 or v2?

v2 applied, but I reply to v1 by mistake.
diff mbox

Patch

diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 32067969f..0d4630335 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -94,7 +94,6 @@  New Features
   * Improved multi-segment packet performance.
   * Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs.
   * Extended statistics for physical port packet/byte counters.
-  * Supported IPv4 time-to-live filter.
   * Converted to the new offloads API.
   * Supported device removal check operation.
 
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 822705060..f88ece123 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -313,7 +313,6 @@  static const struct mlx5_flow_items mlx5_flow_items[] = {
 				.dst_addr = -1,
 				.type_of_service = -1,
 				.next_proto_id = -1,
-				.time_to_live = -1,
 			},
 		},
 		.default_mask = &rte_flow_item_ipv4_mask,