[dpdk-dev,v4] app/testpmd: fix port DCB configuration

Message ID 20180205095619.9401-1-yanglong.wu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yanglong Wu Feb. 5, 2018, 9:56 a.m. UTC
  The port_conf for the DCB configuration should
inherit the same configuration of the port.

Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>

Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
v2:
changing patch accoding to review
---
v3:
changing patch accoding to comments
---
v4:
changing patch accoding to comments
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Zhang, Helin Feb. 6, 2018, 3:09 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Monday, February 5, 2018 5:56 PM
> To: dev@dpdk.org
> Cc: shahafs@mellanox.com; Lu, Wenzhuo; Wu, Yanglong
> Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration
> 
> The port_conf for the DCB configuration should inherit the same configuration
> of the port.
> 
> Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> 
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to dpdk-next-net-intel, thanks!

/Helin
  

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5dc8ccac5..da1d9bd3a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2324,6 +2324,9 @@  init_port_dcb_config(portid_t pid,
 	/* Enter DCB configuration status */
 	dcb_config = 1;
 
+	port_conf.rxmode = rte_port->dev_conf.rxmode;
+	port_conf.txmode = rte_port->dev_conf.txmode;
+
 	/*set configuration of DCB in vt mode and DCB in non-vt mode*/
 	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);
 	if (retval < 0)