From patchwork Thu Feb 1 22:39:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 34860 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91DA91D9E; Thu, 1 Feb 2018 23:39:22 +0100 (CET) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 28D701BE0 for ; Thu, 1 Feb 2018 23:39:22 +0100 (CET) Received: by mail-qt0-f195.google.com with SMTP id c2so28577838qtn.9 for ; Thu, 01 Feb 2018 14:39:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=EPzKoVLGyFUZhOPUCil5ITmdGrattNsCN+1LiH22n+Y=; b=doS5vOfg2KkDN/UF1dNc4Z6r9S9WsLmiml7p/oQxk9FyZyj+hIiy2KYZnR1BltNN01 4QyQ/yJpugSBXCK9MCrl9idFGrt6+br1aznVdwu6f43+k+fYfkmJT6KNPU+EIXSuXglT blna4K3pAkt1JJiZQOR6V54CTFwt6/fJbbKm2dYHcx4i55LronWCNNAfXW/kiMRsj1Hg N1bFGc0kshFfEM3JPs/F9jXXLrVaYyAAndX3ipSzWLpAKQkr9PiExC75aAcRAK6vXD+4 WdopJ0TNh0sSp7LUYwZxXf5HGjo8aWwphKdvNwsQ0P6iKvmyaYqVvprtHu7PrtKwsJl3 0iRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EPzKoVLGyFUZhOPUCil5ITmdGrattNsCN+1LiH22n+Y=; b=CQIqvQADnDYmweUpXCeQAhJNP83aWawkmBJBcuXx14MQCmNiD9fVM8J0wRU9Ci4tRi dodN74qpqQ7udIYzDw0WGv3m6viCS6IrivHaDeJQ6ipFTg1kMCXu+V0pEaIE691o+l8G QT4u1wcCKEZ2Ampbw89qGQBvUNZoTdo8WfqUp9cbz6Ox1xO8dFNbBosctvPAgnlKYJCx dh+Fxh9V3rDgKK4ZUnpXPf8obpmw6cM2ImzCUyaR8rssF66xwEpZKCD4Kff0Nc7ZgBdJ ZsIOke5RwfOL1hp8SFSz+hkqc7ldj+YLOhJCMO9rWnUcwNabl5cpm5js1mb7Zulx0v+U 4rxg== X-Gm-Message-State: AKwxytcUSZelQMLvguwK0rv1D0IQQnetc4PH8EsF4Li3i7dToqNVZ/29 M+Bw2knb2gOeWfNdYWcXQ8LIpw== X-Google-Smtp-Source: AH8x22490B+PTOiZyST5B6NlHU+wY0TC492ky4VihEKRksXd4RUyCXpFsjjdaoRWg5zrG9+1EDrsdQ== X-Received: by 10.200.5.11 with SMTP id u11mr42929680qtg.196.1517524761402; Thu, 01 Feb 2018 14:39:21 -0800 (PST) Received: from monolith.home (pool-173-79-224-159.washdc.fios.verizon.net. [173.79.224.159]) by smtp.gmail.com with ESMTPSA id e34sm423889qtc.14.2018.02.01.14.39.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2018 14:39:20 -0800 (PST) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, "Charles (Chas) Williams" Date: Thu, 1 Feb 2018 17:39:07 -0500 Message-Id: <20180201223907.31240-1-3chas3@gmail.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Charles (Chas) Williams" If we haven't set wait_to_complete, there is no need to busy wait until we have a link status. Applications, like bonding, use the wait_to_complete flag to indicate that they will be doing their own busy wait and will likely be polling again shortly. Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") Signed-off-by: Chas Williams Acked-by: Helin Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 37eb668..f6fd1c9 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3861,7 +3861,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed, /* for SFP+ modules and DA cables on 82599 it can take up to 500usecs * before the link status is correct */ - if (mac->type == ixgbe_mac_82599_vf) { + if (mac->type == ixgbe_mac_82599_vf && wait_to_complete) { int i; for (i = 0; i < 5; i++) {