From patchwork Thu Feb 1 18:53:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 34856 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26AD52F42; Thu, 1 Feb 2018 19:54:18 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10050.outbound.protection.outlook.com [40.107.1.50]) by dpdk.org (Postfix) with ESMTP id 9EE921F28; Thu, 1 Feb 2018 19:54:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NLDU6WjXGV9uIB+qKNCxhTCMAEzqT5qepym8xvhCjyc=; b=PcUWsD2dihvxPEN63k7V7oqEIS4NSOB7TE+SIGTuIbFyPg1BfvidQKko7b6Y8vwUqi1LlYtkTbk+8gL2ahuNeJneotWwKjvonI0bdAQxt8Am/LxRiWiFN868u9V13BYYZLpgLJCM5p6r9ortLL2fFSCZFf0QnOL3TqE13jEyQhE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by VI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1 Feb 2018 18:54:14 +0000 From: Shahaf Shuler To: yskoh@mellanox.com, nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, alexr@mellanox.com, stable@dpdk.org Date: Thu, 1 Feb 2018 20:53:53 +0200 Message-Id: <20180201185353.93449-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: AM5PR0102CA0007.eurprd01.prod.exchangelabs.com (2603:10a6:206::20) To VI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 31c37206-42b6-4bd9-e487-08d569a530cb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3151; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 3:z4g4PI7kjTgwbQI8Zo8Yj50KPvUdSGPXvWLGehzNJmbc4n9h6m3Rl7/1sZSoIramEnQ6AEuGCKpMgwLWnv+eQo36BsPK25UAXSye5PKEmngArwL8ltn37cFhPNCfqmHiedbyiPMFxIcScF9pzcwJ+CwuPHXOu68nJt9PVAr7m/0tIcx94qoXaD/HYrxSezUML+Ed+oD7vFNNg7NgmmOpRsblJ1uFxRxAShpgl5pTNFx6+JBJyjFFVYbabT/KcIgq; 25:rQfwNG9axGf6meOhrCiP7Lvas/OaNAFr66lWL7SP4Lmsp3MRILDY9OGqnvYP31znZ6vjtvVkggC20TRUU58ZVO4FQlsN13bli0dRnJWQDBQspIRgMLO3zwJQM/OkdIp8oAcYSoaE5PSLRQgim+DG10/VjDHAuLEQ7dduxOsQtbmRKzaQOSLjpC31zknuNUAAEDipXNCgDX+S/7PGIjKItnIAaLuYkEIicMArPGJFOobdDH5wtRE4i9B3/qoVoQgobJxH5STzNUQI+zM51Fygn1/n0dd/LObULwL9D49/gruusuS+NmbYG5weCe4LEMlGw95WnHmkZMNerkQmrOtrxg==; 31:MW1CB5QikVYpM/Mvm4CHUgASCJ4vUanWDTmxDZlQrLj82gVxtNfSO1IZ+7eCU1ObRCwq5Jw7zisVeUnKgdgfTAZnZytX/mun6jRkBmSht2Q3kL9yrgMiiLAWKsCNfIAa/LfPLQVA8iIhsZoASZ39+apg5eyfMxyFq78Be/bTQhS+sOnd50LwkRLIWjEFblAkGyrWhzqeJwBj4C6sGNL/3VwNXcDTJi78G9Jb7Lg5pQo= X-MS-TrafficTypeDiagnostic: VI1PR05MB3151: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 20:0r98CBMOKVUZ6y3taMLrqRBB8vcGRUWeTsSQW8M7jhlbWAA4DibodPX8ub8o18uC5BuFaN4IbJ3FWVNxKEC10IF3W+u6Twge4zkBmA0PCOFV2yCt+WgEiB8plcroOt3qnbBhdYeZMAhFMvjSLDmKchF81iJUDSTgvHZiUJW8C5YY/TQ83Nc+FdBo/LVR8oZXP65qAGC4isIpWneZCn8XR6s4FpSbVxGA728LEr+ra3Yt0RT0aBCiFM9b0s/MHgkmt2QsXg0bgu/680Ik+EsDXfSNY5YCBtgXkuw7OlsWeGp1Mww8ojNSvmLu2K4sNm1UTUV/tE3Vm2mCRMAmQXhpBGPCAUuz/LjeJ1I1P1OGjCFA4GBm3FD/BVZgzIuMwv1rlj724bt6+4ZnBuGnsFkUBTXXv2IuTVu24jh/AMp5uqyiTXrYWp8GXQxN8WmdPa0IW5oUnlaRd9rHZcAnz3L1lcKzuuBwyeEJvRhM+EEu4TIoJY7P5BusdLxoW6ZR4vW1; 4:x8RTV1j/7+gKmyoTjjel4vaj/XKzMY74tjhBhEoeCVxkemKd3lNid6P5cPc0JAEteEFAFDWw7uc5V4Ui4AEa7EBK+eaocGsagNWZZ2S5IJgYXt58Zt9imlmKoe9U2NGev5GE37VrairsA55ESsRuXLi0MrkRfiZpFb+zXytvQlZy6weMXcwYEPZVjXcdFW7PeJ5DUlfli16L9M6i8GoUXrF18R/syuGk6AFDELpjniPDDKDcFRR/q6d3j8vPrDAzEl43eb8VKaM02T9M8dbRXw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(2400082)(944501161)(93006095)(93001095)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR05MB3151; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB3151; X-Forefront-PRVS: 0570F1F193 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(39860400002)(346002)(376002)(366004)(199004)(189003)(21086003)(16526019)(50226002)(1076002)(305945005)(68736007)(55016002)(3846002)(81166006)(7736002)(6116002)(69596002)(36756003)(2906002)(81156014)(97736004)(25786009)(5660300001)(53936002)(386003)(8936002)(478600001)(16586007)(51416003)(6666003)(7696005)(26005)(47776003)(316002)(52116002)(105586002)(106356001)(48376002)(66066001)(86362001)(50466002)(4326008)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB3151; 23:o27G3GXVqDttMCqsD0fAChX75Rt4vYi/S+9LdF+lR?= hVzHx1IjIqZpFhdln0Q0v8JOlAMgZvQBYv1AmhEUSHqXarUyBTbNqZmWDAYSEqmy93fTTYGMhvrPdsZyEJvxHtkU14oJcjVYSmGa9KUkY94ex3iLMLeBxznabUodbAtzOMEuqOKM7EF9KYQQ5/K5snb3dvJeZWGm9wcgXhT+cr1Wglb+845rmMfoV4+pi+CpZbdshGX6UjdskesyJnMoTGivPUi2FdEwKo0cVKptSQ/vzmGDWxG9+xfu3lhhgUsUUm693/UbWltNxq4zAzCupM6uPesVn9F/pQmAY+LzsFQf6bJ5paF7U6EGSqKbY9GXLtWBna709FP0SsMiEGmQxdaAsBny3a1P4MTytNy+M09r9V7BI87wBt6+lI+PAtdgHIpV6R1LSC7vqsFYO+d8PYGAQk5XvGlzSQV0wbVg/E6UHTbRl7rKMPRd/DlTwwZPCZwsJSp0NZSSbglRwQk+NskgZMx+nrPhSqDXJhxKZDg62AuS0iDTdivfqrx771QOTw7wF05i16nPTsDRgDaQ0Dbnbwu67UOj0d+w2MRvPu37U67ByCCKoFo4VchRnnES8jMLveRua/6vyOld/DQWgdcvkjMihFitmPNIJVoKKRUkTl+F7T1tz8T4TkqNttIdNwygXk7CHIXzjyhu5BJh1k81kT1M9Gv5FkKUj+povTkU+TXNxc3GxTuJXmgSB6B/3yPFX54GPFTWIy+gkl558ToKxBcMf3O42oMVy7xJjNd+4khP6Nm1aEGzlvoAOq44JN1shu70WEiWK5v9Yww4qWjLUYpgz2a4o4z8MNSZvu0mlVY8F+HwfbQw9Y0mvdNP1F7jOwj2VNmahwomDXC8o+cKWgVi3vNFHMscj+MF7KXDWmEbEjaYPxWFuMYToI4AKmr1LT5YWVA+VD8LUASVSsUMi+5HNjPaF5k9pcQ8Cw/auX6Uvtb9wNCqT6N6Mde/ijNEBztgyU1g1eO0baPlnMOaF6EpiB6EKigqxxSkObmmI6erTTm9DEOHqI7iH5LIX0= X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 6:jcuaYxWzXzT75SyMZy1b8BaX6fW7LsQ6Gs7nCDm0HrHc819LFuMVFQmcjGuSf9RWTaskua7wrxTffuGagvo1PTO61KVsoGoYU5TbD7E+9WD7tKZ7r7a5hmBw/H56eDKiY+NE1gQLzbzKzgypAMFRWDZHlRuc9XXzgm7v3pj04bcLZvwU7JFLF0dLzMElGaVtqzAi7qJPvn0Oelw8s4gQAolbhapspb10BjAlfusXe7xWqNEmhDfl2CxzQMHzyQ6EBst+cbj1couXq32uFEqXGKtmv7opYy3jSee88JGJvdr0EmifbbT3LP2CAU1MeY4DIEtkAjGv3Jzi7Ml8HPipt4V36SxbqayHEx7cii28xeU=; 5:KSYjnZdEDh3xmB5HJaTi1QVL2/T2nQbt6KNp6rrRNZ2oLEkFxqJjwlkN7BoF1gyR+lylvNHcTHHS2iKAHi758jfbTskdFn2gh1cDjJ5Mt5KPVa1s4C2JyDbtne0zaZ0P89M1Vy5wtMEJgfxmB/qEI1Ze0AI1Zb30bSe1WnY3pFc=; 24:uIQ9tRunFF7U8JbSHEFBYpfGRZtg+b/+5GWqqxHnxXKAcgoDlckC36Ml/eqOY0r7p7oS1xGzGasde0yRkA9NHIgVnQksM2xCF3WgfYQJ8AU=; 7:2igm6BU46/oQ/kAozte9yOrI2mw0kdSGDDi3t4EvXwcKJoI5UZGuG5MGo6lHFBgiUD8kiw/IXP8R1v3kg1ZWXmmSPgXOJgY4ZsJe8KKB1lRxaxx8EuMsToH7cV054UHZ9/ma12R4rLDTmUT9UVdhBkonKUDAawRIFBher2qawiYjYE/K55SrC7ZgRNdZm2zt4axHyKW9OekQHDWu1GiO3BQdb+zFmlarlVOqfzHGRvP6WakrxdzqkAnsnEU3QYAx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 18:54:14.5107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31c37206-42b6-4bd9-e487-08d569a530cb X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3151 Subject: [dpdk-dev] [PATCH] net/mlx5: fix CRC strip cap query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" IBV_WQ_FLAGS_SCATTER_FCS is a WQ flag to be used to configure the CRC strip on a queue upon creation. Using IBV_RAW_PACKET_CAP_SCATTER_FCS instead to query to capability. Even though this is RAW_QP capability, it is being used by rdma-core to indicate for both RAW_QP and WQ. Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: stable@dpdk.org Reported-by: Alex Rosenbaum Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 544599b01..02082c107 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -895,9 +895,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) DEBUG("VLAN stripping is %ssupported", (config.hw_vlan_strip ? "" : "not ")); - config.hw_fcs_strip = - !!(device_attr_ex.orig_attr.device_cap_flags & - IBV_WQ_FLAGS_SCATTER_FCS); + config.hw_fcs_strip = !!(device_attr_ex.raw_packet_caps & + IBV_RAW_PACKET_CAP_SCATTER_FCS); DEBUG("FCS stripping configuration is %ssupported", (config.hw_fcs_strip ? "" : "not "));