From patchwork Thu Jan 25 21:02:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 34508 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5BB681B29E; Thu, 25 Jan 2018 22:03:40 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0086.outbound.protection.outlook.com [104.47.1.86]) by dpdk.org (Postfix) with ESMTP id A370F1B299 for ; Thu, 25 Jan 2018 22:03:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=s+Ly4qxZ8vT7GdT7rl4a/854jdNSIcf0c/JbZ/heZEw=; b=nTyMCTcsfnsvRByS+HwiAUsvZZuyV3oyyndp8YKorKZYG/i/dSnaYu59Ms0tzEXosISZp6D13UwBuEitrqqLtAjXmYQY+/PsM4Yh4RRtPrw6AARl13NWbKIyZy9XrVwnfU3F5FBPu1SbtcRku3XVpquy1yXHDVurO/kBnSReGjI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB6PR0501MB2037.eurprd05.prod.outlook.com (2603:10a6:4:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 21:03:21 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, chaozhu@linux.vnet.ibm.com, jerin.jacob@caviumnetworks.com, jianbo.liu@arm.com Cc: arybchenko@solarflare.com, dev@dpdk.org, Yongseok Koh Date: Thu, 25 Jan 2018 13:02:48 -0800 Message-Id: <20180125210250.38233-8-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180125210250.38233-1-yskoh@mellanox.com> References: <20180119004430.15305-1-yskoh@mellanox.com> <20180125210250.38233-1-yskoh@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CY4PR15CA0014.namprd15.prod.outlook.com (2603:10b6:910:14::24) To DB6PR0501MB2037.eurprd05.prod.outlook.com (2603:10a6:4:6::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9b54c350-8dea-4a82-4c2c-08d564371271 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR0501MB2037; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 3:r+vTJxI/mxQyv8lW18sYjIKGrjVI4mfYDqZpjZTRQ2cdE8HHrKPge6k4kL+tFm21KvUZdEcq03SBbn3ESCKxyfs4PP6Oi0kN5ZX6al9/GqctExeHiZjXZBgAMkTYoYzDgS0fhZ1yGiNp1hmb3xzPh3/NXGNNqL4ytAaaILHmw3/Ul44POK53xFCj8ATwkpqLraGz6FhCd2kFvKHgwmCU7tkdxna2mpzew5eb3D6Ri9lvNtRCsLxKJpZ1gLO7rzfw; 25:je7OkP2Nl7mAZo00rKoQVisB4RbDUNrw0tBvtmgF6iEOPK0xjGIwTeITclMwl0u7fgppY4Sjp4BxF0pVzmu0dad7xYEamOQEOHJFUxGJELe/lAFCI7HejNuqnxC5QNe3wxSF4JCIkZyhC2PsHDd4M/L1w8HmHhmvaL7nD7+6CSflC5If7yRqyCO8kFeXHg779zovNSj3IYhasJKoE9BPsNpuee4aaOZdGp8U2gwdjMNHCnakIbYr3aNN8ZB3HT9okaOs0PsIqKmpWFkhM/ZSjyALo2/kc9NGcc9cFuKD+Wley7J4YTSZX3uOpCU/zHI8dedu67imJZ/oLI9WIJxMjQ==; 31:WPcNeDQSWLeiRi+tMeUBZ2b3A1Zf2mCMHQMSieSBlYuviEsZg/EFYaHT55/ukL2eWw/2bClVz7/3qi5tKh6XoTGPae6157FYiw/focizGDUKmPwlMwXG1Xcn+V93o+rELsXQCa4LkvCbeSDA3Z1pB+Dc59IoGDFZw9L+yhas8qS1W79CWEEv2fPP/nBaWJNN2GT/xJRpYOP7//exacIZ6HMvevJJfBMJKcfssmRE9PE= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2037: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 20:84yRpXS2vU5duRrrJ8U7LXZMfrfYFReabOmBF4b8JY4G4BXetedFw4kc/TdKWJR6M8rDMSVg5HoecRl5d6nE2MayOQtC5jswRwhROgdn/TAiJonJtWdQtQqjK0wWGoz9jlcsrWf+ljvVKJotK+4xg6xuMYjGB8r+xeqFp8qyKnCK1HBfNMykhn3yam7cUPMid6I8Sr8aNEwNufMcBSXL1B1mLSj5gsDDqVfzts4AmxVhPt3NamUCaIfYx5kfDjoTlSHSgBQGOrulDeWvnpDORWsKP2RNlrEXrfTYJ97ltkIIAPLDd3XhZlQMGMQCVU4/sdCZAykQua3sDR1e1w837wZuNfKBUFfbd6MxQ+FqX0m4mkeeMFRiu8Fpe0vwPt6Co52VZt5amidQO8sGCLQRuBZRLvOQebuzIHqTy06WY83opJdu8lH5Z6D2dhgJP5/GfLtz8MFWnvZtDBE/u8ShBwSVXWPChNVis8wMUNKquU0v5JYG2QU6VnrUOhQf3bCR; 4:WiTJ0JkR6CWjYQJOrHScKxdRwI9ZnH7bDNR2J5LtFru+c7t1awPAdIE2rlQELcn/27TN/HgjamCIjLq52K8Ekyxg32Z+3V2qxrvS4PsVyjeItlzoMOIyND7QMZnrmyY4S0nVpm5Krbw6hp7EDRwIfHE1lsnC0AJHK91SYXmEs0ZvQ6u5q/AJ6WRTrN+K9xtK4zP5RC0uDBwtum1QSCm0HogzTUCGWdIYTf84vE7vm3xpwRS8Avl6RqzJaGN29lrtw6t/21Asrv5kXy4/EewLyQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR0501MB2037; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2037; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39860400002)(39380400002)(346002)(396003)(199004)(189003)(47776003)(66066001)(21086003)(69596002)(105586002)(106356001)(6116002)(26005)(3846002)(16526019)(478600001)(305945005)(7736002)(1076002)(2950100002)(6666003)(81166006)(8676002)(81156014)(76176011)(386003)(59450400001)(51416003)(52116002)(7696005)(186003)(2906002)(316002)(16586007)(5660300001)(48376002)(50466002)(97736004)(36756003)(53936002)(55016002)(8936002)(50226002)(68736007)(107886003)(4326008)(25786009)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2037; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2037; 23:kuD/iXD1BR1fBsOZv5yf0fUp5N+vD/cRPFekWoW?= g3Y92DIeRJaprx1T1J0iBY5DrzDj+DmauTCPfvpOUkGVNTdw7g9yyp7XzDeKoP3I0oVWIxiJjpkoRkQBucE3w3egWzJyEp/LHqAUdLyN/KxPLdN2eXihixKSi4mAQCeTin1FZDi/90AFMgEmO+zkk2f7xI82zY6Crlxb6qB5gB/FIvXqIt1Bslhy+Qc4tiU87sdWJtQv8MrauoZ6t44FazFSOn4/5Av9yTTbjQCVX8DwPZE4qjlYbD4yn3Rh8aPITjAbLWSyFVT6u8WHj+Xb5NhkvZCYdeMuBGbz1Fv9ovqsK2fAG1j1adWnCcEeaGN+fwAnQkxjW68UAR32Gg4VObAAbaNg4Yuis1Pzs09rZwPRYvNX8Mv9V7B1UgCP8zK62iateme35nahHTCFU6WxgS0RjdGNXueZ+dlyWjr9edSZIae6WmX636cI7mZrab7jlE9hKbf7DCPcCJwfKC5sZ4UWyR8gctE2uzYcFJFfHaX7J+qJorw5Ly5mSqyjmI2GaWGaF53NHZx1vckV01aTu81bfyRMz1OnfbJrQpEUggvhSxxirQC6vv0QwGCRm+aVBKSfyIrlrO/9Cb2WtCOjNbfgNK3YAiIoWa3hKLNZcEZ9qvWY/x+NlOnD1SWE70ggoE2j9ITWMPynWADZd0nzbYbLef4t83CKvyzaEUsCAGsG+t42adlPZ8Z9waAribPlGlMLDlB4Bivc3AVBv+pLm7wIi0pnzKXOrx3iPMlalE6+7Nx6T37I/S0U0p59YOZ2HYjwZyT6IA6nPEYXp/rir3DJU+tq6aTLEl5pIMmm+yfOOhk6+qyMmuSpFX72ZyqspiBGmCzsuD0ZPZtBoho3a9BBuuGLMJhAoyUCwBj2rEeIv0ReNs6VA9r/1Tt0XNOxz3/1p/3Hxllsvyhpvg6T/P1Ct96aMUJktW3V4glWlA72eTPKDWLBQmGOxJ2aP893AINk6B/ouW3IBDjhQR3hjjWynGDLQpStFvgyyM6XovH/v19sDCm0/44cJmDRUenbEOAx1dFbVvwPuT/FTnNLWP9hxT0fOLpew70bIOafmWd+DMXXN92DvVqh6AY0Jy4KOhKL+cEixLz+ZM4r8zg36KVzinrx7jvR3LfesTegJduBPRB3LA5i3yLJzj+X5ecpfBqQ= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 6:lp7F8au9OrB877VV7zAxYoC199X5E2+C+gfqPVH7GIehU8KlP1XJ0LIj3cOB1N5YdUV7SHrbhq1w+zHQA/cWdDVIAjrs4vO6SjqTtOcky2SOrWuYvwXeNUrOuDXQuh/LKUIfHTiYeabTKiAZST7K8vTZHMELv6fDXc5OEilad/ZF6ChRjymNhEQaEJc1I1X3wq1AOTKfsxSy3woRl8fEWt8SMZrTQU4gvgB9MvcAumPwumzhBFyjitj+nBux72WG9uVBMTYR8zU7gqvprSqf/RfpZI6dKYipRJC9kz1Or8W8qPoV3kFk+ryPIE6qXskp0uvmzG+oBjLCR8Idowf93h8QGyGqYGLnNEfpde9BY4s=; 5:vdbNL+36BxVcZjq+5NSp6vvbRawrCF97T1JVZGnaT4gW9RmkJMpbrac5EO0vtBpfK4rxlLTVSt09al5eFn3hVICoL5EmtocawpHOYfkjlmX8NsEi/jq8JhANaZ50iE31/nh3HxXG5cG1LdpYI/i6tT9CbicEvaDiMNDSqksjaZQ=; 24:Zub76j99PcXERO5al+766CkeqktKsBm5IQnZQkFFbK1he7/oKVVtMEAvi0iM1FfyADZc3kVV7qebqWs0RP9+4GmQO0DRaOENmzYtGUmM/zo=; 7:GpOcGZfrTCX127vCOQmSmT90nqbkwRuwNRiU3MbbNHTGp9zwo/0d779dQWoABPf1milxQoCGCiy4wsx1InvM7ZcWALta4JurVITuk4OO/x3iEzurvHgHRXwWz3RmHp/KI066sglPVONqiEGB1eiOQ528IC6xuxF2xKgxZ5nbAo0DoZSKcTVuUMHCIiIafriMJlbU2aOYbztTMy0etkXICJco/+LNElhhcXtU9MEvJ/Y0Gv0g8U1uC53KJNqMO4Qg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 21:03:21.5841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b54c350-8dea-4a82-4c2c-08d564371271 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2037 Subject: [dpdk-dev] [PATCH v4 7/9] net/mlx5: remove unnecessary memory barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As rte_write64() has an IO barrier, there's no need to have a barrier before the call. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 3c716b960..ca6cd3ae6 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -517,7 +517,6 @@ mlx5_arm_cq(struct mlx5_rxq_data *rxq, int sq_n_rxq) doorbell = (uint64_t)doorbell_hi << 32; doorbell |= rxq->cqn; rxq->cq_db[MLX5_CQ_ARM_DB] = rte_cpu_to_be_32(doorbell_hi); - rte_wmb(); rte_write64(rte_cpu_to_be_64(doorbell), cq_db_reg); }