Message ID | 20180103080622.2063-1-yskoh@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 170271B171; Wed, 3 Jan 2018 09:06:49 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40077.outbound.protection.outlook.com [40.107.4.77]) by dpdk.org (Postfix) with ESMTP id 0B0A81B170; Wed, 3 Jan 2018 09:06:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iHT6mu6gh/9fgKNOmfFBHChkePQFT1bJ9cDpCeQZTk0=; b=XnxEZPgJdn3h9Y24oPxzqwTRuk3iA8sajsovXWTHvIWQ9df02E200glPNLpJynO/mUfAZP40s1B+LkrhLBVjBMLU9mWwrcX8mQx9rCdWh0PotMVJ8GIVHgpGx9+rfq99Yb/oUZloEoepnkoIQDEbFnbYcX8FCgi1O02g6AlcboU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Wed, 3 Jan 2018 08:06:43 +0000 From: Yongseok Koh <yskoh@mellanox.com> To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, Yongseok Koh <yskoh@mellanox.com>, stable@dpdk.org Date: Wed, 3 Jan 2018 00:06:22 -0800 Message-Id: <20180103080622.2063-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR15CA0051.namprd15.prod.outlook.com (2603:10b6:301:4c::13) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1e0897d-83b7-48eb-c3d7-08d55280ee2e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307)(7153060); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:76iP3mJtrxY4U2EawmLicj7Imiqonxrs6s2KCOc7Cho1ZesIPreUHIaIk69UxWGP2f/pku4f4X4U13J1t7rsQvPM6o778iZXIDHLc6P6AS7AmNmV6yuVwSewJl0v7Km1qRKthnLZcItlxTgLe/vZtHs6rUZismG86docUq2Oy6HaBE9NWGr1FVvIj9WcutWg1daMc89xWRGPtV57BDI4xTEdEA/PSE+VzflnJ1aNx1JyzEvniz400MR80j2x6+14; 25:c2eN0nvZLlPIWz2xIZqrN5tNLDMc1BXSO/z6qE1bq/SMGb+fdviH2GXj6aZ+iTZ60UmffIzdyia3TcoeKfFUl+go5SbKBTzNZI7V660m/tHFmARhw67ZRsKnRsw/gJHFOWvjn1Zmp+Iugt+U/U5sGhafMHdZ95MgGgqeWC5rUlwCYnCpc1cLDOAJOxu8Q3+BVyxuiCNINlZO13JfLckAQrxTEQlO+mNXWllTeBv/Jix8Yihi16YBmT7VHdxS2qEJNqLmAjew/3XLDhtXOwaCj9WjPgPCzpgiTzTe2cBVPTpxBw7ACZbkEtDOtlfgsu5BEZ1crVMWdWB0xNGC9G+9og==; 31:9uBtVLO1k/12GbytatBCoKvaqHzDOHoQL/mki2OUrmDHiGtnbaN1dMfXf0tfXAhoi4EokxIbVnMY8t9VflCluHVIINPY19M2OkYalMMKMv2tqX3wjdgRBnm68AvrN6C2J84vuEPIctfKrwbhOOa9tNySqUl6OXTBNEPEombKYgfY2avyc/jlPXx0i1MFu6pPbi8JgtAg+q3cU2bd/zT7uC6E3ZO32Tez8UYDrbYo/HM= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 20:o0+IsDeSEaYuxu4wmjKXFU/oy4lr+VKu8Svoadr3Ktl+w2R11fAqJYaJeObAYWTSEMnRkxYq0p3OJmETBEHg5jU9kYpn4F3erB8JrSh4QYXLwH63g+VcwHb37lNrn9yEZR72wEAQvJWcIStEANnPY9Vl2TNz5YC7ufebTJ+HmwdmrQUzaKV7tD05NcasoNfUUj/2GfSUjgIOophH9JQ+YCh1zlBl+tQFkJu2bdO3WCCdhYPBSYiSPw/6sHDy7ZjldYiyUp0f+qYkIH2qu4l72F3byOX+OkOkWPkTDR5AmHgokTy5a59LWViVtVdH3rYGUdUk8AwnIYMyObaSBgJxezLhbleHFD2XI2sNwmxal32FfRrdLuQ30zks8vap2FxaNnS2R1kaxlVK9pu8vRMW2ISkKkSZFtbmELSVWmSYzNMDB+OHk5eXgkI7aZpwFm1a1nu0tkoJwwxcRDPpNBMi1N6gVOPOBSCjk46m2Gge0geznXbUNtt1jfHDPLo8/up9; 4:eoawp67vJG1HsBCpsVan9BjuGuodIMkY+sD3GVe+wl+kDdxdyYhsH/eccfB0k6LVjBLU5u+VSLMfoZpaPr7yYmLWS04Ir0JO6teA9rUmMY0JsGL7UbnWX+Z+VSEMqmIwX4F+DJP6iCWxuX9KRilW4ZSfIsh95BmiK451TT9LFvWrXJ58C0dkc0mYQ7qNuRdVndgvVCsYyJnuBJqnJh7+csin1zuq8E9+hNgSWQU3UpSzXhbddif4jX0Gn1PP63wB5k4HyNa00dSNPiTR9j0bvA== X-Microsoft-Antispam-PRVS: <VI1PR0501MB20457A315A3C6BC7CC0E7AE4C31E0@VI1PR0501MB2045.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231023)(944501075)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0501MB2045; X-Forefront-PRVS: 0541031FF6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(396003)(346002)(376002)(189003)(199004)(3846002)(16586007)(81166006)(50226002)(305945005)(81156014)(1076002)(8676002)(7736002)(53936002)(105586002)(21086003)(8936002)(106356001)(68736007)(25786009)(2906002)(6116002)(97736004)(69596002)(4326008)(316002)(47776003)(478600001)(86362001)(6666003)(59450400001)(386003)(66066001)(50466002)(48376002)(16526018)(55016002)(51416003)(7696005)(36756003)(52116002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:3; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:TDIaBYdcGtasW4RLPmlZP5J8j7yEMOSuoYdNN+y?= ly5TyL7rRPn7raD/60fliGksskZyeCXyQgz4BKwU8SSjeUrW3tL+p3839aUbB6i35aUJUTeORVdCIu+sMa/pdsEyusIC2f1ye+5JlpJmYwbbW5nRqNEZIZPzyep6xwufPiJQ8KeXw+NOfAGSsuJY6IQt7h60AnVyOblk8Y6CMXnAa+zh3DF3EnCw+0rgZ+/JgJ3CRJghBBrDq2ZAfAjk4Lu6iolYrxi0b6MvsTAxIYzIuxR+cHxageN4scpox3wwRAN+yWs/XAb68XYYJwHlgiKuR8LQJC8ZsPoEfXVB8WK4EOpnPHDIziaLBzjBlHWxWILL8tD1i6lPheacdZz8iszTEB8JXBQwY8JcdvaFe05P6ZyxpO3M8HFzwbpy+viI/mVko01BwsHj2bP/KT0Ga/oN1aNld3hER+SLZhn6WviwBIj4p04/UH0j+qlKjaVTxwPQoIBUVdS3dddp5y4TH6gpoJVQddcu0tpkLV9YVYYz6Ut8aK5HYFkGAaz2luyLi20qrNgp8kS79kWwr1/U9fD5xCQHXwTq79lDXvJmU6VvUJPBJcq+uJRnh7py3s+ohbS7ipjKE7ZH6FyxIlLHxBw3IQTpnLUvDiCZavC6ZrbA5RicuO0UZn6v6I94T4ZMA8iRsC9dGlpWT0zdrADP9V6JAHzZSkeXRWAjwzJTbmAI1Zev0Na7hlg9vEuZEWuT467oEC726NcSJiZp/D5kDA7i11/cI+OuLY6NR7OxH2O6+UWTr5eYIX5f6CVzapFJYwBpxQ//cPbArPIsZ1Yw2jdPNeCUcq5139ZFzLRYfHsWWABxnYF2s4GYRaLKeCi0BRMQKMHJkB4IctFeuwero2qNOYoIaas9TYs7F4ZwrkIXwfC28UOtOz4hNS9TFvTKbqJtVckvnyIH76C271m57lU3hoALKAQCsO5D+LpndnG9UkyStW84QZ3WEkF2Ah0H7SbvjJSEZxkJD2V/UMvUlQfNG0ar5UljcdPaPd6Y1tNJrtJPVTFtTtbKjytLQGXqY0TLyxSkj81kbdkYsvyWNTKpu X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:hEU89whmvAYo39cVvX4r7GrzPOPwo4IHyzmWm/+o2opcVsjUzOSi+nOTZSh7Y8vspbKZZ1OmIW2IiNp+ktCdoZb2FPXhAoYAVtpxJTSU/KZI9ANEqncrpOLDSygaD8rB+3mb2+ycL3/bkTUcKbcK2FJC56QkDIGBHd3lf0A2YBME55y4Pb646V7wf8s05fp6bTHgE1pZsm0v0OVYLiSrM9m7vUAx+bzmg3mwKVFfVoDBX5zFYzTncxMN1CdFvda1YqZTUaMkFS2EyHtO9Gx2Xull+t3RPLNXucBeRGNm6U38uhT8/x16HuM9HqsqkaqVnz6Tvtlc+zRVA3PYtLZeSMGuFmSuQhW1D7WifffHdyo=; 5:PphzuCDconK5q8ui1yBlwuu9cELbNk1SrZhyrG6Vl6Nj4ouTyDOl5/+a9SBo8ThRfLLeIfvFkA1YJNUnzUwrWs5ga+7d+U7iempNyQ9wZUOoItpzgDxL6l4cbH+jL7h09ccfUdvxF5eDKaJKOHefhQh3G1myJpvAeXNOdfaJoWM=; 24:5RwocgJhu2zTM2YVeAH4OHYueXSRG8p/p64qG5IZAlX9IpkQRO7d1oxj2qeM4wgd3F34Rz9KyaQIE1Vmq/Y/Yhh8vCBounUd5T249brFmUQ=; 7:oUOH6Df/gyPMtVu0UQKgfWdgLKL4o/psAVadoy8D982u5yCOp2PSX8M3M0SMeQEhJY/GVuzEAsfEKEi+ocJzTyK8tNtTJcbk5Y6du8srwI+m1xzA6XGjv6X6/0LxGVfcYY6gmIebG6eTxD5XL1cS2753KN9DTcvGGDYwjLE/LgaSZmKM/JcCJolVtShUvcQi2YSG/4zRYHPa5hZW4nxG78mKh6FWUOREeim/ccU4l58LVpnhJL1DFlcCOVn2JZjf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2018 08:06:43.5314 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1e0897d-83b7-48eb-c3d7-08d55280ee2e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Yongseok Koh
Jan. 3, 2018, 8:06 a.m. UTC
Checking HW checksum offload flag for outer IP is missing. If flag is set for only outer IP, this can't be set properly. Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> --- drivers/net/mlx5/mlx5_rxtx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote: > Checking HW checksum offload flag for outer IP is missing. If flag is set > for only outer IP, this can't be set properly. > > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> > Acked-by: Shahaf Shuler <shahafs@mellanox.com> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > --- > drivers/net/mlx5/mlx5_rxtx.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index e70d52361..90f129168 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -636,7 +636,8 @@ txq_ol_cksum_to_cs(struct mlx5_txq_data *txq_data, struct rte_mbuf *buf) > > /* Should we enable HW CKSUM offload */ > if (buf->ol_flags & > - (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) { > + (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM | > + PKT_TX_OUTER_IP_CKSUM)) { > if (txq_data->tunnel_en && > (buf->ol_flags & > (PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN))) { > -- > 2.11.0 >
Wednesday, January 3, 2018 10:30 AM, Nelio Laranjeiro: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for > outer IP > > On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote: > > Checking HW checksum offload flag for outer IP is missing. If flag is > > set for only outer IP, this can't be set properly. > > > > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for > > tunnel packets") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> > > Acked-by: Shahaf Shuler <shahafs@mellanox.com> > > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Applied to next-net-mlx, thanks
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index e70d52361..90f129168 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -636,7 +636,8 @@ txq_ol_cksum_to_cs(struct mlx5_txq_data *txq_data, struct rte_mbuf *buf) /* Should we enable HW CKSUM offload */ if (buf->ol_flags & - (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) { + (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM | + PKT_TX_OUTER_IP_CKSUM)) { if (txq_data->tunnel_en && (buf->ol_flags & (PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN))) {