[dpdk-dev,v2] igb_uio: convert license headers to SPDX tags
Checks
Commit Message
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2:
* follow Linux kernel standard for Linux kernel module source files
---
lib/librte_eal/linuxapp/igb_uio/Makefile | 32 ++-----------------------------
lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 23 ++--------------------
2 files changed, 4 insertions(+), 51 deletions(-)
Comments
On Tue, 19 Dec 2017 00:03:14 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2010-2017 Intel Corporation. All rights reserved.
>
It doesn't matter much, but it seems odd that Makefile is BSD-3-Clause but the kernel driver
itself is GPL-2.0. Wouldn't it make sense to have all files in one directory as GPL-2.0
On 12/18/2017 4:10 PM, Stephen Hemminger wrote:
> On Tue, 19 Dec 2017 00:03:14 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2010-2017 Intel Corporation. All rights reserved.
>>
>
> It doesn't matter much, but it seems odd that Makefile is BSD-3-Clause but the kernel driver
> itself is GPL-2.0. Wouldn't it make sense to have all files in one directory as GPL-2.0
I just preserved the existing license but that is a simple DPDK makefile with
nothing fancy in it, not sure if it worth effort to change license of it.
19/12/2017 01:03, Ferruh Yigit:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied (Makefile was already updated), thanks
@@ -1,33 +1,5 @@
-# BSD LICENSE
-#
-# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
-# All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in
-# the documentation and/or other materials provided with the
-# distribution.
-# * Neither the name of Intel Corporation nor the names of its
-# contributors may be used to endorse or promote products derived
-# from this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2017 Intel Corporation. All rights reserved.
include $(RTE_SDK)/mk/rte.vars.mk
@@ -1,25 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
/*-
- * GPL LICENSE SUMMARY
- *
- * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
- * The full GNU General Public License is included in this distribution
- * in the file called LICENSE.GPL.
- *
- * Contact Information:
- * Intel Corporation
+ * Copyright(c) 2010-2017 Intel Corporation. All rights reserved.
*/
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt