From patchwork Thu Dec 14 23:32:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 32289 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED51C1B019; Fri, 15 Dec 2017 00:32:30 +0100 (CET) Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 9CC6C4BE1 for ; Fri, 15 Dec 2017 00:32:28 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id g7so4507340pgs.0 for ; Thu, 14 Dec 2017 15:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PbHRbnjhohKF8XXkK7MDC08J6zFG4/8uXYg7jkHk2TM=; b=vFPuI8PXcfS73S+B4earCZ4IgMHZF9iFm3FKTiRZMG0aaKunVrIK7v0FgrkH3EZlgT /1iGT0RzcG5zxa5T39DeHjXz+nfCqLN7JWtAdyxxbwvtdJ8sk/u7G9yriPSntZPlCJzQ Nvs7qPIBJ7SJlFI6FpkP7JcZxy1ktTxBf/dsAxiSQwkSG6OpkOLSEgEE9HqrUYUFgB6g vl4/6inCm5QtHiyOPIB/HJCYf/UFr7grattIhwlP3Vqh7w3mkvYVArWBBQTbPMAcBjCM aIQndnx/5SBQkLap/Krx0p7HZQOsaU41yHplDlc02vSAzwg7/9j0FN+BlaL0GVySKDq/ yRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PbHRbnjhohKF8XXkK7MDC08J6zFG4/8uXYg7jkHk2TM=; b=mbkEKSbtLndXFJ/JNYLvdbyEMSiV7dEiKxbJYYTFI4egUPqmuFsO4l1X7bluGUvate 0GEl5cy/6f/53oCUiT4iToC6Xh8dMcIkA81tY7zBy/490m2j1S78pkoffVsnQ+emurCq xNvvuqpbCyNCWuVUqnPoSpatpSpONg8fveWG43EGo2jMfOC74tYgy+2qCxbZAeuYFGUn pgpNnNjKx4RRiZwjgxcvq6kWcRrrVgodo1HlK2VfS49r8y+IKK+Hp3wRkTVzexEZyoBp 28r8msR2M2PkZWtCuiIx+2sNmlmSu5pe35/zEc4swh3urLXf0YtijnW2MbVLRkWqXIte mjZQ== X-Gm-Message-State: AKGB3mJF4zI1pUKa82x8hilyxvAA3xAW2/xpUgnKMrfNv7w2T6debJPr F1ENjQEQ3UGCoiLxCVg5ipGP3lKvfLE= X-Google-Smtp-Source: ACJfBovz/yo/6KGpxZqy8lHNHivD9GcAXhL1J9Sdgzs9OLgFV30wWYd6UAabfZAZID3nq3BZBFjfQA== X-Received: by 10.98.64.153 with SMTP id f25mr11315654pfd.213.1513294347482; Thu, 14 Dec 2017 15:32:27 -0800 (PST) Received: from xeon-e3.lan (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id p87sm9706584pfi.95.2017.12.14.15.32.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Dec 2017 15:32:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Thu, 14 Dec 2017 15:32:18 -0800 Message-Id: <20171214233221.30928-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171214233221.30928-1-stephen@networkplumber.org> References: <20171214233221.30928-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 2/5] kni: remove (redundant) parenthesis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger Don't need parens on simple if expression Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 4 ++-- lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c index 99338c5c8071..089fd4962a07 100644 --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c @@ -2993,7 +2993,7 @@ static int __devinit igb_probe(struct pci_dev *pdev, case e1000_i211: /* Enable EEE for internal copper PHY devices */ err = e1000_set_eee_i350(hw); - if ((!err) && + if (!err && (adapter->flags & IGB_FLAG_EEE)) adapter->eee_advert = MDIO_EEE_100TX | MDIO_EEE_1000T; @@ -4988,7 +4988,7 @@ static void igb_update_itr(struct igb_q_vector *q_vector, itrval = bulk_latency; } else if ((packets < 10) || ((bytes/packets) > 1200)) { itrval = bulk_latency; - } else if ((packets > 35)) { + } else if (packets > 35) { itrval = lowest_latency; } } else if (bytes/packets > 2000) { diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c index 2c861de5d6e7..1a1cfe574cd1 100644 --- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c +++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c @@ -2415,7 +2415,7 @@ s32 ixgbe_fc_enable_generic(struct ixgbe_hw *hw) static s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32 adv_reg, u32 lp_reg, u32 adv_sym, u32 adv_asm, u32 lp_sym, u32 lp_asm) { - if ((!(adv_reg)) || (!(lp_reg))) + if (!adv_reg || !lp_reg) return IXGBE_ERR_FC_NOT_NEGOTIATED; if ((adv_reg & adv_sym) && (lp_reg & lp_sym)) { @@ -3279,7 +3279,7 @@ s32 ixgbe_set_vfta_generic(struct ixgbe_hw *hw, u32 vlan, u32 vind, vfta_changed = true; } } else { - if ((vfta & targetbit)) { + if (vfta & targetbit) { vfta &= ~targetbit; vfta_changed = true; } @@ -3392,7 +3392,7 @@ s32 ixgbe_set_vlvf_generic(struct ixgbe_hw *hw, u32 vlan, u32 vind, if (bits) { IXGBE_WRITE_REG(hw, IXGBE_VLVF(vlvf_index), (IXGBE_VLVF_VIEN | vlan)); - if ((!vlan_on) && (vfta_changed != NULL)) { + if (!vlan_on && (vfta_changed != NULL)) { /* someone wants to clear the vfta entry * but some pools/VFs are still using it. * Ignore it. */