From patchwork Wed Dec 13 14:03:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 32228 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8DE51B00E; Wed, 13 Dec 2017 15:03:32 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0063.outbound.protection.outlook.com [104.47.1.63]) by dpdk.org (Postfix) with ESMTP id 94303107A; Wed, 13 Dec 2017 15:03:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=flzQdyGZ4FxyRh3NdLnk0k694BdgCHS/4KNYVvctRG8=; b=dhmqGimtQagdJgx10RTWkKCJ3HNFNIGHQOtO4jt4D5ZRHIftk+evjo5TdiDDVnw14nJKDFTVgp5PAlYt7KdzuZ3MNJP7SFgf5bKo4z/i4BUqS4mcKQZhepxH7wLqKCewoTyESvCftBg1g75P0hQjLPplf6Vxu1kvxiFQV94Nim8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by HE1PR05MB3145.eurprd05.prod.outlook.com (2603:10a6:7:36::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 14:03:28 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, yskoh@mellanox.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 13 Dec 2017 16:03:10 +0200 Message-Id: <20171213140310.136853-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM5PR0602CA0020.eurprd06.prod.outlook.com (2603:10a6:203:a3::30) To HE1PR05MB3145.eurprd05.prod.outlook.com (2603:10a6:7:36::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 72418d59-c6ca-4248-47a0-08d54232499b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307); SRVR:HE1PR05MB3145; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3145; 3:pkN81GgnDcVdW2eo2YxuQWORjUjz0qwU97GA/qXSFPfZpFJiKdMnHVr9bujaepoEWb+ormLiyU1W03k/wjFLCqnvUA9Y6tDwEXQHQ3Q7IpakzZY6aoVgt3Gl6YZyxp8fzjxyW44vfxzl7pOeBsNz2MzcVASRiIMe0YkBO523r74T+GJD5TFAqxb79ClvnhVUAlxhzjBYMmP4OI3eOCaQ3D9iLTLhciwaiNGkLh9LYJx8h/LrXAfNGJImjTaa2DYm; 25:wx64ZG0fSvgIMR4089/M82xw+g3GeoO0BCfnWp80Gj1LL3MRI5qE9PhFiTotvn4S68/gEHbcNisl7kSCQy8HDfkdqlRSzPQqv8qHv4mCI8ZrWi5lAzJD7wbu5I7oZ0GKQ3y3fZGCz8shQWUh7AZDUs0yGP3mZ9yTzysPMgY2IrNRYhTArYkLEs9Vh/JTwfQl34DgDk2qJXPm/3kfeFAgv8SRDInuvuOa/D6UKMDGvsL0hywkfoixcyvlEeMC5qer4B9TbIEpzSn8z6jvu8Ll5AWOB+LkA0yETt/QL7Vxtr5aIFAP0Mg6op8wR9vPLsm/hmbcIRrOgNdgbJjoSE1Gmw==; 31:G5QuI6HBJyrUnS6O1vjXPGd7RPMzK8VM/MgpgF6V6CegG6xE6FWPUOa+rITi+PzMkq7au6bhYx+2COknzVxRBgJtDtP7D1jKgLQ9LFLlyStfx02dovRA4pBJ3cS2omj8erOOMCuo5A6PU87cxfoRt5UqG8xPJXl3EC19vEKD5D113GN28gbXhGBzFDt5AL/FUkGjJ5a5Eu0owQzmPm30Xa4ZqaDycYOcNRweeMMdsnQ= X-MS-TrafficTypeDiagnostic: HE1PR05MB3145: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3145; 20:6J/+26A3Vcltsqd2WwLcc0Cm8a/laiGDlivokbu7JUg+L5zkGtgo1j7foggICCe25VZ358Fv4HqPE3c+gvmbMj0VDubN5mGaxWWFkLv57ICEaThIvKHd5wGQgxQVjXvrp4SEVgSwHeR98rGfPC9uJyKCWbr5gkITJA4U0RQYKbHXlNBJdQ8Y/yCzwqPMa0j5HwRBIS7OGQvOSYn6A9Fs4agXIqqY8U7P1tWGR6VH1lQ4AFjUElxRtvJ8Z7WvYGsZRc25hQuLAAl1KZemU8djZ7dJVSWYhuwiYM1urpRwx9ZOMzmBPxX3VWq3p8iv2PIikOtfR2+2df7CqjRJ+vbwx4T5CJRpM09ZqRIzFYLxwZUoc1DJyxUoGkWcFJP2AsimKOa7m/2rztDjsuKExgKVDlU5Fzy2tK8KZPYaO109S5H+sIVRgjx/lhLPrfqhgQcu1taFnkJi5XTp0P0XiSDdgqYCXT30sFIsf+IgoS3LvhGsGketfL22yyAHfi0ZO1sU; 4:DzXEQ59KUAv+RghLXVLoKpgUHrhMO76jf058x6Bgaf2R9PxffoIqZCht61w9tAK2ki3uRBv+PuXjL/ykG5K7R17Y7wNZ/5BteVSQnGJkNRtsX4PW3mphQZv49UXExoKfjmDw2gU1urYDaO/Ex8r9H+xS87JEIBe2KsVDyIPCzJwCreDqb4O4uQk4miqEKLGk215DoQ8BC2LIbcxOmkhYL1H2k/3Oc+13sGbnOzzoLb3xE21ohialmjUguLDbtrwxLpIVeAyqRvHUxJKWt2Hfsg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231023)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(6072148)(201708071742011); SRVR:HE1PR05MB3145; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR05MB3145; X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(376002)(366004)(189003)(199004)(305945005)(7736002)(106356001)(81166006)(3846002)(105586002)(81156014)(68736007)(5660300001)(6666003)(8676002)(86362001)(47776003)(66066001)(1076002)(50226002)(97736004)(69596002)(6116002)(7696005)(52116002)(51416003)(8936002)(50466002)(48376002)(33026002)(36756003)(2906002)(316002)(53936002)(21086003)(55016002)(25786009)(16526018)(59450400001)(478600001)(386003)(4326008)(16586007)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB3145; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB3145; 23:6x0eHJ7FpXpEVRRDJtdxY+XBA+z05p/8inEP95feA?= Qybo6APlrCX3zi9mJE3xMtyaVuXh9a7631/ROPfs8awtxy4fkaOQ43VudPZoy48gyU8p2mPEMm6a2v1D+cMHtPbfbnhuxcHnnZ7rQZuNciHeqXeIV5gXD/thYnQiNGTwKyrppRAMaQ9/ynAMBoWjJ2fIVy1jl9YnhvYFopj9bRkZl6JC/KzBwOy1wTyeF9gA3J1FM19hT4+wUca/il75yz/9Ww37ys9iBgeietlHDaSKE08RUxPWdrwDRbfD1M30J/Nj63hFEaBPlVtWlcZi5ncBJGbkqZdg1r2wWH09I49qg+jVSEs5x07F9DtV3cf91fOEB4MGpD0zuNo32Xz2J/jIdSXTZG/Jn3nSURzMrHVzikny/cRv7GD08aAjHq9wkcHycR/EpbuBWlWUQ9t4yGd0Nbhb7sOaz+gldm8L93j5WUp3VI2zYd1U3+cuXeNruZaG9wcPziX9yq3IeoPoFkzmPgrEtUNCDkmTWXDJBYYR1Z+/l/UIvEV/1D13AcEFbNR6zW4n97y6Pa6KFAfXrN4uiohMJPX0ksyjV3zsEP4v2PbZh4ZpR/s7PszpMI9T2R7LTH+DJ8Ofujha6KRMrgTInVzfH65YPgE5wqksf8imeTDnULL9sc1GiCYdEA9yDoICXl9ZP2SYDehdGpMixpo1F8ldwxuhNJMlF4sv5AjOrt5naZnkMax2yBH4kwzHEz45+lf0JddD1vyZZSHGozXxDjVzVDobIfSNeA5OaLO4EOkBALq/zFpCKqHIkjLJnmua9JmysKM1nB+MjGKgHK1LFqAVvMiRDo1EwctgGToONUethC1Oi92pmoIAQ+6ncxvmz43i3v/9EG9xSTB1f0glR862SnANp+/wXiLq2srw+qMEq5ak+6OdHMZfUbpYRkRt2jMo4/qdOU/wB05dv3ysPcx59KP7IoJcjEK5miQ3yN8tjR+3hicMkvWCM9ptPcOV3R7Oci0d4SZuYKRHZrKr31szFLn+L+X+o06hgph2F2MT5CiUnUDqI2fKJMXnKxnZ8+fP8uAwsXOv/J+ZmJw X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3145; 6:LBIoPv9VM25VY291UKVZbSsvN+rUEv1amInX90rTHz/y0eR3/TOovIseiIbzVuWixZrmKkcWL5NKlyeVdgVJsOtAOSsYB2aAhZ1Bv0bhb9vrXyARO5/MGqUp4cFLWjyOBT3mamq20cxbWgCAS3ukMOTAAH1eu+05qeJzGLa7EktgHNLpZR6m/YTfH481SZjc4hM/AHf141NkTSd2JDkqvFIGSYFixnF5KgAxSi8o9ndqqD6iMMbQSgAujLDDZ3+R7+Al+TRx7FhVM6SP7/CPcAWdUGuO0RcINtqU3FrxvEg8R88kG9dGn5+urX/XjVYiHpeLuHxVYGVE1TIGv0TUHU0QsI5X/tXeMk/RqbpgG5E=; 5:xO9tfH16vvx0h3oTXJC0Eid8ksHZIA6+d8w88pQhZTxeRjLShJwz+OeafeGysVBLJq2KQrjhritGqXhkbN24TqUsu6bA/yyOc4aQpWFVbhiL7WqreQyGYrSG4IPjcEJ1+GTqXmEdIJBH3oPHuoMksu1ESOIsJ4kcEeVn5gTeXK4=; 24:dnbxUuk950NYxmPy029zksCarfn/89IrZKpmcuGWXG6YRymlZjdtrXXdasY/ezFhFIquxuMycun2525/7+9S7syJhXw8nz2/zMigcSerrjM=; 7:H8R2pgkBbphoTrmiTeq2J4klgDMTqKcteacXhPfVwZwlTCBY5wBNpY+QhnbeWia+o+S62MSKBH6nm0T+AeU4BiHJsrVJHIOJV99dGq8YnH2iSS/mtJDnzrcsoTCbRr3+6/aMUpKq7wZIf1zBKb5P4wl79oTINvl92x18JWMapJMV/RcdrC8iYyDbKZMOGekiQB5SLM4RItnBLRvmeahkUNOys7qTnmCxPLuKGQpqb40gZnbKaYZCPqs7ZNDjtFmM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 14:03:28.5535 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72418d59-c6ca-4248-47a0-08d54232499b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3145 Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN configuration after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ethdev layer has an API to configure vlan setting on the flight, i.e. when the port state is start. calling such API when the port is stopped may cause segmentation fault as the related Verbs contexts has not been created yet. Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue objects") Cc: nelio.laranjeiro@6wind.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_vlan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_vlan.c b/drivers/net/mlx5/mlx5_vlan.c index 6fc315ef3..198a69e3c 100644 --- a/drivers/net/mlx5/mlx5_vlan.c +++ b/drivers/net/mlx5/mlx5_vlan.c @@ -127,6 +127,11 @@ priv_vlan_strip_queue_set(struct priv *priv, uint16_t idx, int on) DEBUG("set VLAN offloads 0x%x for port %d queue %d", vlan_offloads, rxq->port_id, idx); + if (!rxq_ctrl->ibv) { + /* Update related bits in RX queue. */ + rxq->vlan_strip = !!on; + return; + } mod = (struct ibv_wq_attr){ .attr_mask = IBV_WQ_ATTR_FLAGS, .flags_mask = IBV_WQ_FLAGS_CVLAN_STRIPPING,