From patchwork Thu Nov 23 12:19:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 31568 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7E9A1B1A0; Thu, 23 Nov 2017 13:20:15 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30081.outbound.protection.outlook.com [40.107.3.81]) by dpdk.org (Postfix) with ESMTP id CF67F374C for ; Thu, 23 Nov 2017 13:20:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Bq+C4o5TO0iONe4NzCgKgxpP9MrvwZhKtpQduTsY4uk=; b=OZKQ/ndk7ISncEAKsc+BNxr1sDYnOz83NkJoJZHXf/Gk09qm62E4u0ZPFjlzEniiJZgO/9UO+TLOoFbofG1YPx05SjQ4jKUuTJUHS66fTM0ZKeNBBRTSdQpQ6Wh+xEMqqOjtZk/wer7qVVGBCSuhjlrHFCfTCgLm9MI4E9E7eN8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by DB6PR05MB3142.eurprd05.prod.outlook.com (2603:10a6:6:1a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Thu, 23 Nov 2017 12:20:04 +0000 From: Shahaf Shuler To: dev@dpdk.org Date: Thu, 23 Nov 2017 14:19:23 +0200 Message-Id: <20171123121941.144335-12-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171123121941.144335-1-shahafs@mellanox.com> References: <20171123121941.144335-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: HE1PR0402CA0044.eurprd04.prod.outlook.com (2603:10a6:7:7c::33) To DB6PR05MB3142.eurprd05.prod.outlook.com (2603:10a6:6:1a::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b0ef444b-9345-4b6c-d27b-08d5326c8753 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600025)(4604075)(2017052603199); SRVR:DB6PR05MB3142; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3142; 3:vpwqHQlU9Wu05FdwoUSkA9zJkmqkTbhVmvGoDC1YMTbcympAoAaSXgTZmeW1Ol+jRNEE5oc2RCNHkblks1nvnsOGHKpOmAqs33KHPDvr79sw7D3b8t/pMKqrwkiq4zzuZh+TxMx8StV0sL7No/V9KfFDYnQ68cUnaHYsKqNuzDz0DK4c3i8hK0HUEWb1ZS3Qwlz+DAiulVM5WolAyIzr+3nXGgepGOWevCK/8NSkwab8T6tZNIngdKS/KykFR6IJ; 25:x1wS24OvwlIGhaK4AKys0rgxRshNVemOn+4lI195J1MnwCYZ5rCk7iac4ifa8/JJTW6eQ/l0Rn+u2fHrEhq5+wrnWVbrNaY0rhFSZQjoxeYFVr0UD6udThappuZ4DrS81uRGB4AcSqDf0NfzCKhqpZ5kbGVF4j+VIeyDqLNzM8RrnpRBU9RqhCKP2raKK5xYCAFYwFH9dGwchZ5B57YHAvPYncZ5qwc8EI0nWD4zkcqlTvj8yozxmfKfU/6U68DtHxu/jPse+86Own7sOjaXHRGERv4PVsyxOJz0Gqc7mMKrVFXt1hPE8+uQ/8tn1y1vbsdVyTswzsK4Lzmr/vvClg==; 31:LYQMjhfbaDpvhWfo8rtRb9d7cKKOdZ43mscnEBmQ6d9rteOMRrrrRYvkPXXTWmHrYevlfMfzT+wQZ8E80RwqYi9gIzSF6/r5ZupxpSu6yKtZhpkEPvR4DuCsLu8RBvkjjjm2uW7oUSk3LXZxYW4kkKR3hSU+FPHB2s4eEZ613FLrNeoIgdvbGiUq658iq00NiJmvycKw+A2AWiC7wHgETY5wjcxwWfwCRyIBOsQbm8E= X-MS-TrafficTypeDiagnostic: DB6PR05MB3142: X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3142; 20:MECZBeodp77bQk4VdLErv2b+TbsUseDEp7Lh4CVDWH4vsN0cvcGj8mEyd2e09tI2LA6pbySx8qS48NhtikMzZK8ecq8xaopwgdAvSsTS2YeEOAua0Bf3Uq16Rn5JEHcWyUppuyuaT1VSdiy+k1YrePqlpMr0qULaU30OPvvvG73Y3GmWSzPH40RVmdYOJrUxFvvu2lOUnQTN0IH011FZyGACLm0ZC9LFpY6+SJm1Jv6orWaRU2WesVM1QxC5D7jcvS6PC2Z3VZcBpv3ZgiNmMTHpVPZ+D5SUl27ELH/QIR0Jh6IP9st4CtqVoiNg4FoF3vnbEXxmXweKQ0kfEwEBDlWkpntPiDcdURH2cRfMtQWDrrnxEJxT0Xvk58LchtMpiVtl1YystNpUTqwz5E3JGIueGOqof2u9++HBDxtZvg5s6Zq9bR7TsInwKMidcYvA8IeVYZH+JQOJ8RBrwAd/vqTURp0rC7XPONLD8cHm/UJIvoQwPfj4OEwF+Y5Lj6dH; 4:jGRRVwyuootOX1tKJDnZY8q9LXB0z3U2skZnrZSop1RjoLjgSQF9gatd4gEcPzigTAlQhMnD7mTwLRMZeLyQPDD7WFARqR38/Hmzkv/hnEF3MDO3A5QIlHo3JC2B0jwg5h3ahLql0TIkB3FKiDHSo941B8x5wKrx0yXjI1HZwGsA1Ck61OZlQZI+1MzbmGYrMIZb3sulU4TOGco8mOJDVG/CoYhFKbKcd25SLlJhEOVedNLQh75c+RwnRRoykZK6xBh8s5QOlaReuJt9kxhw7w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3231022)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR05MB3142; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR05MB3142; X-Forefront-PRVS: 05009853EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(366004)(346002)(376002)(39860400002)(199003)(189002)(50466002)(16586007)(101416001)(5660300001)(478600001)(6116002)(47776003)(69596002)(6666003)(3846002)(33026002)(97736004)(52116002)(8936002)(36756003)(16526018)(76176999)(55016002)(5003940100001)(50226002)(48376002)(50986999)(33646002)(6916009)(81166006)(53936002)(81156014)(8676002)(21086003)(1076002)(305945005)(68736007)(86362001)(2906002)(189998001)(105586002)(2361001)(25786009)(66066001)(7736002)(106356001)(2950100002)(316002)(2351001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3142; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3142; 23:KFkJ5JC7cCZhrahcS0JP5HObnWx0SN+jdIHniWYOh?= AUhrn5QxXnmj6b1EJKp5XSuguG/ZSLfizT9klT/rm4CXW8oU9/CU9720utgO8O3zw7xflOJzuaQ9lWqwPlLkjOd5ELuU8p5umqVoXE8JYhUOzm4yk98aNZqMJnABOQea6WEtBkYyCyqWehA4/3jQjpSsrmLkCSFpuqygspp7Evd3hSicO9/OpAAQjtR6nrd4pwhUyLhxqeewy4vCU7CgdgnlLto0ivS06zrQBV/4dmNZVuIiuUlsLk6w9p6lx6Twp/PNcKCAGnp/NcRneFS2+UahO4n4IZSAHCHWGx91/eEQuN3Vfzq2BNAixiISwPiocWzvDAEpZ2sX5+3+XwWDsDrYqPVIQ96vNAFBqBw/5W3RKe4Zf6hF33woFpSLwOGAzga8rIvmTdXNuLCKXzAU2ZTVWcFfNoqKB+jrIUdSKaDMSoP0G0udBl5j19AioYlV97YiNfZcFQX6L80+krLOpSbjvg2YbwpojwbxB8yEzZqXYLSPOraBfBZald/F8PpBQC5S3um0X+7M0R+P7Fhl8neWdlp/FXP/Y0b80MX+rfdgy0E3AQPO+9HrJOOT2k0174g4o3ipTI5qaUUXzzPW1O+5Vc4g6QF429wbjR12x+PwmPuef/HXiuKo5yIR2dV+pWK5B2Iw5N0RgoRjjJOkv1Z6AmTaIHauCJ2UwyZBDwUNwZoWtG1D88oKzPdIGSqet28ysA2q5YksYifZvFK5pkfd979lh86f2puJPNJoIUr2e0adcMI8z6GDZ4j2QudssTVN2li2xHML4qAwu6tvBDNJDRe0j4wyRghOrOiqoXPVvIyRMYWs44TQUTevOTsEzvIu59pQLCndKaBBKQdPbV99BYyMBShjFRfPPaYBSIH9XJyVJi/QUSOkguZ/laCb2euz/cqJPNJPosj1SKgm19FMM19HbgxeUivXPIMyXbxr9Qsi2D1n8lwFWcZwlvP4Xz+w65fK3QY1Sr/E6CtsBRiSKbkDOAcv4NfJrDtq9Ah2rk/X+BjMrHAfDR73XwWvCgUkjZVksvD1V4ED8axG19Zjul50uLovGNEZXrXAuNlSfHpsSed88VHjWINKidCxmmOrWgjRP/sdd880YUTD4HGBiyywpDYDMsOQ7BVDtpnp6+xZqkRJSjv/HOKnRGsz9o= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3142; 6:3Ws0/nZTAj3ZWB60uEfnArXFSX/z9xj2SXkzIfywKTQarHCkmNGrdlzh0d76XKlR3ZWHxLRwA1UJEu2ravRAhXOVLCbN/T4Vp4/gAvYtPHx5XRy22UsV4aukKW4MuR3BgmqKvIEDHEXBfuqDuTt9XseU+NnnFcivJ9+FbUeS4gPFmO3DPuY4puFmA1gqEdNVipDdr7OPjdqoNs3MLVc/qKrclEXTbjeGDFoXIqaGVbrhXLAUlWlrvhAevp2uqLd90hgDh2PGoI3pWnB2tK3ct/s/iWPp4JIlii5zAR8I9ZFTjXFwQmACYx7jAWpA0xqBpOAyBWuZYGydTh/Le8239CPEOG6b8JLMiklyO6XRlCA=; 5:15VXtgvf0cxhjhckz9cQG1ElkBQknmID5jdOOGgZGU0GQBRGDGwZZn/lMNrYQTc4YdII3pP30rnPpBW0SVfSrB4yZmymvGcsmZjUNV76d72vPyDmpse/Me0eg9lhPcBhRWokyzy6Vs34NnPE1fCXv4E8ppv8iAyZXmWH6v5zq94=; 24:Ut6Smt/BF9lGnw9PTkV/q9lIWzDtGdAc0r9cf7WsVsObtDBMv4gU5wMka5inSF2T1QIAfL5+J1HG0mkkaaMmcjadAqwrNe10VFXmj2Pz/hs=; 7:kVc4esL6EKLvYm7DXYOc4oMrJkBkedaCp9kvU0v9bin5ZvFyuu183E9uoiL63daq7s3XjJUM9fkyWlIZ8zpQAqvpC6DWah8BhIYYVfH6OKUASEei/z76RZdj3K1dLHnlwZBq3FiCJ+KX/uNZWoqEe3jKbEKbk4EpHMZgT2ELB9nWi7LKuaWBSWfQLdCaomlhFh0dH/gIDgc4ibe/DFEjkOZDOnk6olvdnnrd7e5pB6qr18Ps9yA0Zh12o4bK/OI3 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2017 12:20:04.6379 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0ef444b-9345-4b6c-d27b-08d5326c8753 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3142 Subject: [dpdk-dev] [PATCH 21/39] examples/performance-thread: convert to new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/performance-thread/l3fwd-thread/main.c | 42 +++++++++++++++----- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index fa65234f3..49ea80102 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -335,11 +335,9 @@ static struct rte_eth_conf port_conf = { .mq_mode = ETH_MQ_RX_RSS, .max_rx_pkt_len = ETHER_MAX_LEN, .split_hdr_size = 0, - .header_split = 0, /**< Header Split disabled */ - .hw_ip_checksum = 1, /**< IP checksum offload enabled */ - .hw_vlan_filter = 0, /**< VLAN filtering disabled */ - .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ - .hw_strip_crc = 1, /**< CRC stripped by hardware */ + .ignore_offload_bitfield = 1, + .offloads = (DEV_RX_OFFLOAD_CHECKSUM | + DEV_RX_OFFLOAD_CRC_STRIP), }, .rx_adv_conf = { .rss_conf = { @@ -2999,7 +2997,10 @@ parse_args(int argc, char **argv) 0}; printf("jumbo frame is enabled - disabling simple TX path\n"); - port_conf.rxmode.jumbo_frame = 1; + port_conf.rxmode.offloads |= + DEV_RX_OFFLOAD_JUMBO_FRAME; + port_conf.txmode.offloads |= + DEV_TX_OFFLOAD_MULTI_SEGS; /* if no max-pkt-len set, use the default value ETHER_MAX_LEN */ if (0 == getopt_long(argc, argvopt, "", &lenopts, @@ -3567,6 +3568,23 @@ main(int argc, char **argv) n_tx_queue = MAX_TX_QUEUE_PER_PORT; printf("Creating queues: nb_rxq=%d nb_txq=%u... ", nb_rx_queue, (unsigned)n_tx_queue); + rte_eth_dev_info_get(portid, &dev_info); + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) != + port_conf.rxmode.offloads) { + printf("Some Rx offloads are not supported " + "by port %d: requested 0x%lx supported 0x%lx\n", + portid, port_conf.rxmode.offloads, + dev_info.rx_offload_capa); + port_conf.rxmode.offloads &= dev_info.rx_offload_capa; + } + if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) != + port_conf.txmode.offloads) { + printf("Some Tx offloads are not supported " + "by port %d: requested 0x%lx supported 0x%lx\n", + portid, port_conf.txmode.offloads, + dev_info.tx_offload_capa); + port_conf.txmode.offloads &= dev_info.tx_offload_capa; + } ret = rte_eth_dev_configure(portid, nb_rx_queue, (uint16_t)n_tx_queue, &port_conf); if (ret < 0) @@ -3612,10 +3630,9 @@ main(int argc, char **argv) printf("txq=%u,%d,%d ", lcore_id, queueid, socketid); fflush(stdout); - rte_eth_dev_info_get(portid, &dev_info); txconf = &dev_info.default_txconf; - if (port_conf.rxmode.jumbo_frame) - txconf->txq_flags = 0; + txconf->txq_flags = ETH_TXQ_FLAGS_IGNORE; + txconf->offloads = port_conf.txmode.offloads; ret = rte_eth_tx_queue_setup(portid, queueid, nb_txd, socketid, txconf); if (ret < 0) @@ -3644,6 +3661,8 @@ main(int argc, char **argv) /* init RX queues */ for (queue = 0; queue < rx_thread[i].n_rx_queue; ++queue) { + struct rte_eth_rxconf rxq_conf; + portid = rx_thread[i].rx_queue_list[queue].port_id; queueid = rx_thread[i].rx_queue_list[queue].queue_id; @@ -3655,9 +3674,12 @@ main(int argc, char **argv) printf("rxq=%d,%d,%d ", portid, queueid, socketid); fflush(stdout); + rte_eth_dev_info_get(portid, &dev_info); + rxq_conf = dev_info.default_rxconf; + rxq_conf.offloads = port_conf.rxmode.offloads; ret = rte_eth_rx_queue_setup(portid, queueid, nb_rxd, socketid, - NULL, + &rxq_conf, pktmbuf_pool[socketid]); if (ret < 0) rte_exit(EXIT_FAILURE, "rte_eth_rx_queue_setup: err=%d, "