[dpdk-dev] net/ixgbe: fix tunnel filter fail problem
Checks
Commit Message
Add a mode type check for tunnel mode, if fdir is
in this mode, it do not need to do Sanity check for x550.
Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_fdir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Hi Wei,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Friday, November 17, 2017 1:36 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix tunnel filter fail problem
>
> Add a mode type check for tunnel mode, if fdir is in this mode, it do not
> need to do Sanity check for x550.
>
> Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check")
The patch is good, but seems the fixes tag is not right. This fix should be for some patch newer than this one.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
@@ -1277,7 +1277,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
IXGBE_ATR_FLOW_TYPE_IPV6) &&
(info->mask.src_port_mask != 0 ||
info->mask.dst_port_mask != 0) &&
- rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
+ (rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN &&
+ rule->mode != RTE_FDIR_MODE_PERFECT_TUNNEL)) {
PMD_DRV_LOG(ERR, "By this device,"
" IPv4 is not supported without"
" L4 protocol and ports masked!");