From patchwork Thu Nov 9 13:50:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 31302 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96B3A1B6A0; Thu, 9 Nov 2017 14:51:03 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0068.outbound.protection.outlook.com [104.47.2.68]) by dpdk.org (Postfix) with ESMTP id 5CEC21B67A; Thu, 9 Nov 2017 14:51:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UHWlg6BfKJcB8MlY8zLrxyh1FZKlyQYzBIAf4mv5OzU=; b=VMqyQCr9D/pEH+4NO4TPi3PVRHRfUO+Ct4eK3bP5MPVUOq757c8YcE+SEaycMjR4LADoQ3q0R6hcsTbH/lZARFBRjAHEtmo7tJFQm2kVGjxkvll0B/wy7O8yyEoq6v0guLr+vHFJ2ODbdSJoKBlHaz34ympAbjf7K3dTVVX76WA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by DB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.218.12; Thu, 9 Nov 2017 13:50:59 +0000 From: Shahaf Shuler To: adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 9 Nov 2017 15:50:49 +0200 Message-Id: <20171109135049.63062-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM0PR0402CA0025.eurprd04.prod.outlook.com (2603:10a6:208:15::38) To DB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 099a49a9-c1e4-4d69-b909-08d52778e905 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603249); SRVR:DB6PR05MB3144; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 3:UguGb+bsYb/Gu74N4mkVeO3P0AiAMAR6Ah/DQGIScmhPGHQ35MSvwB2S2zSkRNDI1Ynz/0UYYOSvjZAPCj0I1jEQ3sQwFnMRp/Sc6DKdexZVguM8qb9MNNIFbMMAJtB7BYTr4UtD8k6DOSTpxIUsaJGGeebH2Fz9FM8gs/O9Nx45W/EEfPGMJW/f81HLyGRIGokxxrzqUqp9MSE2k5bNXmJqRld0+jvq2V1WezOYFcBaTwQaqzhw+edUo++QjI+B; 25:KUK189kYE/XXOG2tmTwvQKRxYPEv/6jVSVme3ge2t2aX/1pz1EDmklUE8p6xZhkDdp30TC+lWF5dfN8ow4/Ynyh4Grft4njmJtoQFWbVvIIW7Fo16OM5PMTuDlCfX6GGiuGiIguj6J8WWJVHz0Ktpda6gArDi6joz5+ies4UgWcyrwsLmDHhsuQhNgtKPVRoSYAnwtotQnzgORRQl+umZnB09dcVKhakavj6Dp9OertgCdw7dxGHPDjNkIu8TOxWiEk/q1HldKH2uvc4tI6XDadWY+jYxEbVuw01C/N+wqYnZ+3Iy3z57S+aXwEQhxsI2KUOLWaQSVfa0+5Sk1aiNA==; 31:I3uhjYluOM3MtH5KbjQCrhtJ/W7QQRKbWkGH6MboWejv4237/+B+StQEc59uon1zDVoy1zN375xzKjtH2H5z23tS5HS+qQgJgnnIzfO8d+ajEN1ZhKzTmc6Vjy5KLesITf/VabweB9Ydl0oVtaLTZig4z7PW4/ifdz1W4kCqyjeEc5iN4P7FHBIE1SmcsnOyiNa4b1n6kay0+Ymwe/J7XUNVHRuRzsmQSbtaW21ajLA= X-MS-TrafficTypeDiagnostic: DB6PR05MB3144: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 20:y1N75oYdzrj3B0saycNQ3/zmPBTJYxXDPB96LZ2jiO1tHq45PkaXFD51HI5bKl/G08IvnPYttP2yoZBMjBWesYTL/jekRSZTUo8ej7k+lyE2t2LEGPn1rsTyHZJ6rhQGm6TA9SpfWFNBjfhXjQicb9W8nURexz5BwZhzyOftSBUKD7LceOl4Cr4EIZMMxdQ0aTu02k4EgYaT7laEIjjTk3RRuB1j0nxlPMrVf3m7WO6R7w0Ix9iRmFmCXTBlbkY8RJzdgKrAKsL9XJOkGWMjw1l1tQXZXj0KLTDp2DafqOtdWRlLFENZXVyOHR+5Yfoa6EyZJj0OR1RIxDPH57Bk7rH5r82O4F3aETjMYjopzRp23Sotw8AXI8OFPszpPNT1H6jQJ0OCZNG+7O1opx06wRZ8cKtrunzdpf0bpjFRKeFRB1MCmlzZbIcIo+H8Nnrl3EG7BPDEVbnHyhTEvibnmKrDoL8P90O79psBcDpgEzkAD9Y1pAPX9kx+vwiNhmNf; 4:xQ6++ksatRu1yDTRCby3Rzy2i4OLkt8mqQ+2K82GLJ4/nxc6n/vhOCsKhMZhrC+/d+UYcqm+fdKOFjamJwY6HHpDEviTQv8iEHpADaIdlEVNCxXHE7R1E2NOBGh0dtWK8DomLc1vgkS36YrbRj3+HWY3XpaCBmuIelnRE7roxusiq9G6w3MrUu9+cK4aQlD9UWf3vCWGCjl0VLHlsqH5RL/It7mgPab7bxpP3dHc5kEoCXlky4rrYLKGKhdaKp/GM/GfWcHr0bXmYeK0BEIKaA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3231021)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR05MB3144; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR05MB3144; X-Forefront-PRVS: 0486A0CB86 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(199003)(2351001)(2361001)(7736002)(1076002)(68736007)(6916009)(33646002)(106356001)(6666003)(105586002)(16526018)(2906002)(33026002)(101416001)(5003940100001)(8676002)(16586007)(50986999)(8936002)(81156014)(81166006)(6116002)(3846002)(5660300001)(48376002)(4326008)(69596002)(50466002)(66066001)(47776003)(316002)(189998001)(53936002)(97736004)(25786009)(55016002)(86362001)(305945005)(478600001)(50226002)(36756003)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3144; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3144; 23:qZ54Eq2eKjv74hZkm19MKG7xOdJG+Oz9QG7/UDuWC?= f3Ik322RMeXp5AOjmKdQJrRt/I7Xyu2OJ8tM1hL/7DetBj5XObv0ldiNvixxmnOcVogckO4n4wY/amWdVbz4P6QFmz5IBq5Q+jp5DOrCnZF2OoAAKahEtgFcNpRx8vafhjR3KRUQjbcC4W/kQ+lStNhdukFqp6756s68cXXivAIcGzHw5A+l0k/h/01QimfyuCqV6wuigst0H3YE1ivCVC1MYv5CGNuZ4TNzn2Tcb0xbehUdTAZQmq7J6l7pdeVT+amOG+ZfDeLD8EIy57MnH3wDjjcu0H7zkvf3jqLAak0D/CO/tUwR6wujxs8fHbB52kRNNCqGD4BThq/73L6lOn1GU+IE8RIF9rxFX5bY4xxcEhHGHtOwFLRJBle0K0nw//HaXVc+NY8BUTjwnlvUTLUwxUoT0x9ov4AZsvCGUNoiF2yFwwM+6F0biHVXzaQ+atdF8aPsc8CmDkl0i++eyuR3iGAucCCBNYhPOwdGhRl4tnNc5/hQviZc0Uk0DM6EZJLUmbAAM8gAuLorN8kQy5nlsTVxrSXB6JVgLCjueeg0OP88BNbcvWt5yW8qRtt8m9+A1AklkYMv1PZgryoyk7uYMPeznp/UMgq3JIlXFfHPZ8Wg8H/qGKs4TUAdpY6UsO0xVWcYjDFQufrXwKiMnN5FxCImuvBpLmcyNHoJpqrYw/imokmWSddKmHbGlfZ7+/zum3zQj+YnIKmJj0NP+xAHhf9L6QHL2BT0g3IRJLSjxlD8KJqlEYDabEXfE1GyBs6iG+qROlEYXuCiB+JHMvjPHTG1p58F9H7ud8IUiHKRGv7YIcIBDNzVn3iUhEDHkbcDrRfBSRVWNF9850hQIOyAsr/Uo4WlIegU36JSY2V0Tr49Phf4rYAQdhF2VuXWndeR6ZWb8VmSCrzmTPw0qhwsE1X9cUJz1gV3iTwCML+Og+iLbN58h5DFyqBcqFbDwRU29m8TrwxZ18Hd3wsPogNDJdYDgdwaBIiwPKFOcgYrS3bRciMO92K9rrcNxiALW8A5snJacUS+4VtOcbFELv0Xp0SEjdiQvT6g4L1P33x/HL70mY+H6dhoEAj0VeTIG0= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 6:CjEPhRBeQgYxF/FVuu5Nk449Ga3GCrsbqaP0XIFOugeKsJmn3nCBGyMMeAkJzusGLvmTXbHbjfY/vYZYZvkhxw69Od9l7eo5/QVOulD6hsUwM7NJtxjDRmKCiW1zTmlGQXIYlkxew0p4TKt8/GJY+4uAoxgFb5vQ4UWUhhnGmaU44CXYVkRR2wuVda/kpLG8qpM09bp/tFBEg6N2D3zNqFgxtUqIUSeG6jwJsPIgP9hP/HKcUmegzeo3mrKbS8cuPEj+GxSyX/rVd1Hgnb9XPXCXGdG24y7K5mzXopscITCrJndnU35cnBG/xvidzYFW9q1E8ICJYWaPTnqV5JKXY3fMViAMjyyKc1Jxh2rIgIg=; 5:77GBaUme2MMqLNwoUL9KNigmz4hk0i5opkHl+Q+GTlnipBe1+iqiAOmrZERenGRItJ2VFfJZO5vURT+X99LMd/WRa5YNxoSVIgIFTRl5UF/VtaSwYg//TRX1A93Jcj3NMKT+iIXLVGcXHsXihitQhk9XUmTCPTjMt7L44sSy8Rc=; 24:SH1ibqtAm9WAaG1q37SqKX24mat9lHsQp6IW/flr/NxFeWfNh0G8gBtmjXN5B90MAyT8K/lG9H7oUPZW/iabb3d1CTKh24y/cLKvtPKWerk=; 7:cHQy/s9izms8pVeXLkErjCm44fyS6BnDZ59YfTtQyumtLmZ/yM+z9fyzcOXOTW6WBR0dvbyaXcQRLS3o/NREG/OvpeThCZ7Mh4tXDsoF1plnvvwM8qKHYsJcm5FX0rmCkuIZ6hgCNnnnhszjOVR0fcj43mfEihKmlCBN81DyI2ZFa9GE5LhbdUKFMnzAWm9ND3+C174lUkEQn2KMDDn0YB0B77bOO3REPRxh3gtTjI+rwKDj1RYJnCe7mA5QVFIy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 13:50:59.5880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 099a49a9-c1e4-4d69-b909-08d52778e905 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3144 Subject: [dpdk-dev] [PATCH] net/mlx4: fix rxq interrupt memory corruption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" intr_vec allocation size was wrong causing a memory corruption. Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management") Cc: adrien.mazarguil@6wind.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_intr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_intr.c b/drivers/net/mlx4/mlx4_intr.c index b17d109a3..50d197698 100644 --- a/drivers/net/mlx4/mlx4_intr.c +++ b/drivers/net/mlx4/mlx4_intr.c @@ -98,7 +98,7 @@ mlx4_rx_intr_vec_enable(struct priv *priv) struct rte_intr_handle *intr_handle = &priv->intr_handle; mlx4_rx_intr_vec_disable(priv); - intr_handle->intr_vec = malloc(sizeof(intr_handle->intr_vec[rxqs_n])); + intr_handle->intr_vec = malloc(n * sizeof(intr_handle->intr_vec[0])); if (intr_handle->intr_vec == NULL) { rte_errno = ENOMEM; ERROR("failed to allocate memory for interrupt vector,"