From patchwork Thu Nov 9 13:10:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 31299 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EB461B690; Thu, 9 Nov 2017 14:10:43 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0070.outbound.protection.outlook.com [104.47.0.70]) by dpdk.org (Postfix) with ESMTP id 73D0E1B68C; Thu, 9 Nov 2017 14:10:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hTSo/THqORsHRjF1/AQnaIIbVw2IsJ/eS6tyGAyfQk0=; b=JqCvh/mj7iUM5p2FRX5KE+D8pwv6rpbNnz01nffnerqTsA/08UEqlC2m2DDkR0aUWlUc41s9MW1s17mAdXUNjoKDBG4WyVJKdPqfPY3hW1YNeqJQTNYM85eQrAXssiGBFmboVQDts/xCZ5TRSWVoqlSyqpeTi0HCyFC4Oydiqlw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by VI1PR05MB3150.eurprd05.prod.outlook.com (2603:10a6:802:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 9 Nov 2017 13:10:38 +0000 From: Shahaf Shuler To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 9 Nov 2017 15:10:14 +0200 Message-Id: <20171109131014.61309-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: DB6PR1001CA0034.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::20) To VI1PR05MB3150.eurprd05.prod.outlook.com (2603:10a6:802:1b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f39bf5e-71d8-40b8-e56a-08d52773460c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603249); SRVR:VI1PR05MB3150; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3150; 3:ZEVFM7xXTjW3HsY8r8AlkAmW+L8x84wIENPcFEtLV0mbDxzu2G0n7Vw4D9iO11BmOL39lKMB/fjrBOmDnSYERoNtrWugPwqqCy9geH+9l+CTT/z1tK8PWWNi7DIdOFB90k2TItO9mGpidbM1ILMW/K4+8NNEMICAlnw/IFAQrhiVNVSNWTiiTkrOoDlweZXV4IRVIOZjryxeYoKLyUN9k4BDy5/G85Vfz8mDfGny2vzFFqgw1zVsTgBUu4k5YpvO; 25:/YYl7fsO+bqrWH0QO/gB0hEa8jNSZcQiLcf9mUD021CS2xn08HgrBziCjdXkJ5hR4QSS5t5FiKJ1FmJfClbVb3dPqvVooJiePRMiPWfKQ2jDPwf8AaDgW9L96qAZ2ymCKcO/sPn2pa20QMDhruvHCiipYWmTcfe3+l6/SEC661Ul9Qyc4+atTaiUAGWKoc3DEaHmzeHLI+KmZJspUcL6U7LTJKnEH0nHBHfnd2qpw6fwVG6CbSLXgFTzO4Uw2NFYWZyE31FPpoxl/WlcgWCfRQKtIREVbVqO9isL21sDOxD1hDPRTydP+gzvqE9kF+DtKt0BEaDnd+GIw/4zFWnDHA==; 31:BKl8CTkgdwQXzXm0fNCKSUmgpcanNJ1NILBLk0qNsnx+ozwEIw0BN/FpBZmtGISOpdB0evlrHGjIz4n/WYVEqwrSsMUytiI2iL/6h3hymwvrUlu3dIhFmP6nni2XrL059wyf+qh5t4zz2YQo+H3bOajkCzxylgbXsdEnMhtfDmzEMjr3VYBUS+gljKEZ91yYM0ohDAa5KuyqM2+ZrelfmTXpyVMC3rq6vTLdkP2HXDc= X-MS-TrafficTypeDiagnostic: VI1PR05MB3150: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3150; 20:stHM+LTdlvLf/s1HxtqoCOUo6thYrHG3ZlJ+nXHIyZ08INxONsLbJ6oWzOgZOzB5WE3mSPVNk6Jn/MN1PAuyWxJN2WsJuyFUP+j101iKBMVdhIU9fsc9KZGRRplNf9amoAYcgBLrAr9jpU1GAYWMKFaUXKk/eXHg0ZxGhxINACb90maTNrUySa8dNX78NWV8juFA1Cx6hpUvm+IeQ0CIuPm8k7tLqXszm4CoKWM7Q0+e7CS1Aa5vsocyZ5dIKPJUefhyjkjZd0d5/LDw1atPjDmfEFOkwhnCEKooB+HstfOaJVoTnpa75/8nJ+KG5ux1QLuFXmLWQqXwyhNPwkrMEyZtmRISfW4+vz6B/LzcK6RdNQioiKA6mb12XRdErS/ETgzdMo8YxRyRZFCSlIiN9qmS/+rKxNU1kCJlaHKx9Po7lfy2SQTA6rVlwMq/LearLXLCtotBqogif6XvAx3JzX1vt3A3Frksmz2baBcZq/PHqBeonYvZGeumMNCStPpO; 4:oiNxRT4suqsNZIkNn9EhyERTC57WlqeIjkccrI8u4ovRvYS6Uvm3e1hXDeHirtBcW5qfB0oc4ANuJ9twioIYAebxHistnQdjgy2Rz/FFLFp93G+gIF2J6BT7UZFtRY5mycDkLUMNEbZg9REv+XLWzrw0LPjhyjJcv0g+KatlYzz03JhNYhtraRZLKFotBCqthpxshN5vUXLDQjW14rUSXa5NlyDmar8nVu64QGZuj0y/9u2xl2gzrrj5wAFfFJN7qFe/y8Om51ID+uoUrccPKw== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3231021)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3150; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3150; X-Forefront-PRVS: 0486A0CB86 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(199003)(189002)(86362001)(36756003)(50986999)(101416001)(48376002)(5660300001)(189998001)(97736004)(33026002)(16526018)(5003940100001)(21086003)(4326008)(66066001)(68736007)(16586007)(47776003)(1076002)(53936002)(50226002)(7736002)(305945005)(6116002)(3846002)(6636002)(33646002)(6666003)(2906002)(69596002)(25786009)(105586002)(106356001)(478600001)(81156014)(316002)(50466002)(8936002)(8676002)(81166006)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3150; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB3150; 23:DKKWxyVnZId0yx3D6XiF/YDsgiYS+5NKI174lyWNk?= xdcjwNjMsLFGuZI9uGIenKef8Grzk5AxID+GHdXtvEoh8oaKDw5BmQb6/sbhDat61ZcxuMbzLAMwdj6YFisr7oOPDqcsIiCZBmxCfvioPe4tUE2ba19vrd9WpzAg0/d1TyMRcwzoRW/kFls9Y7EOK/ngEcolORTCOQbk3qWEgiaFwhm5d8hZZbiPaz2fdp+Im5j8xAJOkNWNypfgGq6PXg1GQB2OZz69989aiLyr2d2x5J6XxFv6Xyt0PymWjY0t4Q6T+MKw2ZdZG05+nJGMj8hMRc1tvT3wVy1ND4r3ttAakkHfdpz7JxueU1iz3bZmCo1kDHqt1awt+YjWgvSQ6sRZW8R8O3XU+jbcE4joM0nldPUKGtXfWiNxGxZRZAURVtcmOeZ5CzMZ/ZsQTAA2oAEewmRNnQGy0rlfpWZNmf2tJr1Z8hRZ5zWqgTnIsNe+shHA8exMzD9Gk0go1u5Y2LsA1auu7OA5wCQLWuuiMBitQHvo6+ubnuGiVQvmd0zbwmGWHyzqm0kNGy62FcOFmvAOg4i/LnagKE8KDqWae4Ou0/fGZjdD8HwYCYbsAl/237DxFOdJzh7hih1l6QsXgrckYXBFqrlXVRvsVNjHtvCQfjyJVvQuYLcifmXZw/JAobMSrJZaLIF2kFNwq5GjitEur5O1+DnWb5ybfZRBXxhDYn0dqsy/uPy92LpBtlvi+szFrykgtnTXNpVfEfTMcfruMifPwCujCyWIFXdj1AbTXW5VXkwQSn58hAXFQ6HoA63hnUtx8mdevbrEKnFWmJxwI4n3m6+uN6+fF3poTcqEmSdBfOyACjJrhOuntOAFkmzhD0mCPBATnT73r/Vs86V4j5bhMdxmGuMRKoNAbTAzqQ+h3Xi1gTI9IDsDfMA4VHa2rujJdew0+d3siW+CkSCRAdqytF9Pj6KTjRIL5CsiJnu5lvYoRNKU79bKK9SLSysA2fOKtlCI9FPLekTnyrhVR0CANZECTFBnS0RkkvMAvzQKwpWS2/XyKwP4Kr4SLhsTloNVfHsrfdUXHCGNO8FikjXatoLFbwgyYoeepJ9pw== X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3150; 6:kksgRc0FvemkvMwe96zXOPF46BgjB96WHDMMme8s+A1W9IA7wLyDc0MDBHTIbPpEKnYzldnw8MVA5c3Lv3oMPnQeoUaJ51/SK2Y4EEh6Jvh5N4CehXLor82ClZTnIKm5U3iYKoWaIVVqy2A9+O6hgrUh196XWcVFJUhV4RoMaea4p8JgSll1olaU9xLgPJPm//DT9tmW6inK9ja9KrWtRcsdaccTT4+aRKfUxdJcFMxZ5iLceIYyc5v1Ra9+KIP+ds12NowG8hlR5P2pay0uTyBuzi1Xyx9pXjy0sj1N9MZsIL4U2YHHzKdihqkqSZxjZBtjN6NOFFpdttxKIi1O9LEWiIhiSELWlUWwpms3qU8=; 5:PXKMqiRDbXmEfNgdTLq/yldNYrYMd3zElGgtKuZiPlhvQB428TYXCV0O9l7OJrcSj/AenNBaW38KgWLjIjGtrBS9K68kwkgqBHlnsrCLFI2FIpEtauq7Pm/yVhda7+fqIKapjtSSRf9x9Ma5grT15dgLGbQnWzcCXaM1KyNK/dE=; 24:YdFIo2JA8Ss7yyLgdghY+DkwldnJsGRPXpzrcMoJ60vr2LHe6jW4s1hiVi9E+Dm1xn4WgMDnkBM3WKmDix3B7+FRAC0EKBkXpFczZSmuMck=; 7:a3AhwS83TJXEl1mtSO7sBqd7j9qMSX3zES5rbfLGjBAohZerUqpGs0UcnxMUEVrWk+3DrKw7pZk/xXQgKyrTSioKh+vmu3nvSyofqrxBhb0h9/N4h6mz8dGSaWrXJaQ0kNV7pOoFrKOHx5ukDKcg0qT75Re+gbuY8KeqjvEZPjOqWoueBf60qTJ1FA+4l6teulukyhUXZyNYgnVroIkrLu9MDL6bVN8glkHg3/V/7JHIjqJ3wKNmvki9fhfwSqyn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 13:10:38.4015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f39bf5e-71d8-40b8-e56a-08d52773460c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3150 Subject: [dpdk-dev] [PATCH] net/mlx5: fix rxq interrupt memory corruption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" intr_vec allocation size was wrong causing a memory corruption. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") Cc: adrien.mazarguil@6wind.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 6b29aaee6..85399eff5 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -331,7 +331,7 @@ priv_rx_intr_vec_enable(struct priv *priv) if (!priv->dev->data->dev_conf.intr_conf.rxq) return 0; priv_rx_intr_vec_disable(priv); - intr_handle->intr_vec = malloc(sizeof(intr_handle->intr_vec[rxqs_n])); + intr_handle->intr_vec = malloc(n * sizeof(intr_handle->intr_vec[0])); if (intr_handle->intr_vec == NULL) { ERROR("failed to allocate memory for interrupt vector," " Rx interrupts will not be supported");