From patchwork Wed Nov 1 20:38:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 31089 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FB601B381; Wed, 1 Nov 2017 21:38:29 +0100 (CET) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 38FA51B37E for ; Wed, 1 Nov 2017 21:38:28 +0100 (CET) Received: by mail-qt0-f195.google.com with SMTP id z28so4258205qtz.13 for ; Wed, 01 Nov 2017 13:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tIIUBba+nAFe5KhxspT+ojVkFQNtdMgyMREfnQCNVys=; b=k/xDtKL8hDoJA71v5KgtYgCGdZojvdO/MnU+QthMatvebn5c1RJ1dtCRgXkteCXgYm acZ5iFWybCVjgI+20rBnDfEPlhVHSM/+7sfbhGZDxlHTvJ0Xrp0yYMvZPgvb6w4rEila fAhz7TPAXj8XnCogdqbxPnxCzBRPUXhBubUk/wi/YEb2Gd7u0rzbVP2B80CvqCj44pIm 85EWdGuBIDemMZgpRajOMit5QWB5JEZ1krb74HIGnbXgO0QAc4k16sMMXatIMyrpoNX6 ShZIzUUDWom7YIfP3zewCCzhT3/PQryxz902CLWzh50evnmk81z4VwOJz/9UtvyYlMYd TynQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tIIUBba+nAFe5KhxspT+ojVkFQNtdMgyMREfnQCNVys=; b=V52m86IyvPfM14v6vEHaNHCQY9kqImLAJL6sdk7D/iX+9dZABOjbIcNZG6gLG+rSTd c3cXbyytB1uHBpWnfjl184OtVnjAB9959J2X/y2CFNXmzyktoyhIqjbf69ByZeGfkn9Z rBedGbNrgvAHeuofNUpJGOdG8YgdWwrUU216u+5CRz2lCj4w33O43JL9vCfwWhsFNccD AH7IRxvro0g6Szmf1s6E+2JVthQoLbvntCkaFx2sRcblKtegCtsUXWV9gTXvlUSOvK0L MJgPWn8ZhwGM8ipZ1A1ODhBBDJuShYS2+N9BgJGJUQLeGvqCkISFx2BsV/T7ibBsmR0H ttqA== X-Gm-Message-State: AMCzsaX283AEpkbMQixcIs84yAyvqkxZCtAlExfm6vBFEJfmE7d+ZduK gexcEfFJISryDmZcrL58+TID3Q== X-Google-Smtp-Source: ABhQp+S9YJuHWphZdA908P64oqhTtqRYN01BRwiGuh4ENWMp7I3UbYW5pQGZuHsHOEN617l2acMv8w== X-Received: by 10.200.53.89 with SMTP id z25mr1951628qtb.58.1509568707542; Wed, 01 Nov 2017 13:38:27 -0700 (PDT) Received: from monolith.home (pool-96-255-82-208.washdc.fios.verizon.net. [96.255.82.208]) by smtp.gmail.com with ESMTPSA id s14sm1053136qtc.65.2017.11.01.13.38.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Nov 2017 13:38:26 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: skhare@vmware.com, Chas Williams Date: Wed, 1 Nov 2017 16:38:20 -0400 Message-Id: <20171101203820.8021-1-3chas3@gmail.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Chas Williams At the end of the queue release, we can free the containers for the queue objects. Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation") Signed-off-by: Reviewed-by: Luca Boccassi --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 01c85f1..18dce72 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -203,6 +203,8 @@ vmxnet3_dev_tx_queue_release(void *txq) vmxnet3_cmd_ring_release(&tq->cmd_ring); /* Release the memzone */ rte_memzone_free(tq->mz); + /* Release the queue */ + rte_free(tq); } } @@ -223,6 +225,9 @@ vmxnet3_dev_rx_queue_release(void *rxq) /* Release the memzone */ rte_memzone_free(rq->mz); + + /* Release the queue */ + rte_free(rq); } }