From patchwork Thu Oct 12 13:07:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alok.makhariya@nxp.com X-Patchwork-Id: 30287 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D5691B2DE; Thu, 12 Oct 2017 15:10:29 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0060.outbound.protection.outlook.com [104.47.33.60]) by dpdk.org (Postfix) with ESMTP id A2D601B2DC for ; Thu, 12 Oct 2017 15:10:27 +0200 (CEST) Received: from DM5PR03CA0033.namprd03.prod.outlook.com (10.174.189.150) by CY1PR03MB2363.namprd03.prod.outlook.com (10.166.207.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 12 Oct 2017 13:10:25 +0000 Received: from BY2FFO11FD011.protection.gbl (2a01:111:f400:7c0c::169) by DM5PR03CA0033.outlook.office365.com (2603:10b6:4:3b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Thu, 12 Oct 2017 13:10:25 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD011.mail.protection.outlook.com (10.1.14.129) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 12 Oct 2017 13:10:25 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9CDAKSK008029; Thu, 12 Oct 2017 06:10:21 -0700 From: To: CC: , , , Alok Makhariya Date: Thu, 12 Oct 2017 18:37:21 +0530 Message-ID: <20171012130726.4332-1-alok.makhariya@nxp.com> X-Mailer: git-send-email 2.9.3 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131522874252247108; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(376002)(39860400002)(346002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(1076002)(106466001)(105606002)(2906002)(81166006)(85426001)(2876002)(47776003)(2351001)(97736004)(36756003)(189998001)(33646002)(50226002)(86362001)(104016004)(86152003)(305945005)(5003940100001)(69596002)(53936002)(316002)(48376002)(356003)(5660300001)(4326008)(16586007)(50466002)(77096006)(8936002)(498600001)(8656003)(68736007)(50986999)(54906003)(6916009)(81156014)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2363; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD011; 1:3B6f00zBMDkjcEAPZao9atNmw9amcsVcwHE6pAk0+AwrocdUkmy8JYaSGfKABhTqk+j6jvePaFqASFwxljqByFMDz3smGsyJRickcW9Kthuh8mVH+2/DovRrBHeQONcW MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 562ac529-253d-442f-c044-08d511729a1b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2363; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 3:MR6QkMmxunjA1rpz2wt4dOFyT+ybUsjw4bKbwCh1Pz8Ta2x1ULRPKmga+jXsQMf2V0pGHO+jAWu0Iwd1vMqiFyMiK4SIbIMqTcgiYS1Rg+TQU2L/xV+egPo1EHzRqOZgLMTV/EUZP1FK1fj1ihmZ2Q8eLJFHs6cIZeiuwPxmw+PaKqbxGrE+6Lka22tLNo2tY0Zg7PS1Ke3uMq6W1XI+76oATz2ou1dxvGAtXZfzfWXC677eD742nYHBZUZapXN7cNPI89y3mTAxW/8A8mNly3F2tpGrJKOZFGh/qZVflHxpJh1guZXtxyjXd9l917KbYBLJVKneQLuhKk7aPwxx/W9ofwQ3rDddzxKwe6qE7Bs=; 25:ijzbu6OtBQZW/iJzP+8LlIfhl/QrcMPJhiF8YwmXGE9r6rSeOSvuPQRL5daAXjJrSZ93wqMQreoaOBq9uYtWGCaBsz39ujuxezpfnwhQSUzznRCw7OlOG8tlOhnnB4alNG99IPqYhNnKYkFIBbc3bRGZ9np72ECjdGkDMsKJLkzMyAi7yy9Jjz46LRuuVEbx8xGz01A4fcm16Q9xdoiEgtQiDLoJ1udp9UtDKeyZkVJEkLhiecZcVTVsVt8vgpvq+BXbemui+qDcEewF78jYNG6dhxcEkXQvkG835xqDr98zRwB3UP06rYOGlBMLlGQ8D5JuStImMUnK4yqeQQZ2PQ== X-MS-TrafficTypeDiagnostic: CY1PR03MB2363: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 31:1bkfayruRn4yyAe/4uhndxQZvviJlKMGdhGJt7tsozAqL86YtaAQIV3d1Aodpnx0qBSNoiVA+dMrUOl5paocOEZ4airpknAqmd1abIufXZg8j2bOoOrFE7oXgbs/ct5zKnLkXeeTb3IpjIuzdWdKxUPfmRGb39An1xSK5xPk8UsSybTfZ8sVYni8vPsTHKrYYA98vNRICnG40YcrHppmdI0No7oWCu5EXiJSwDhf6t4=; 4:VVNI5BXZUkhRkWOI81wFtCjY4jUDnBTBJ8WLtsdC3n/ypvLjYaf6EOIpWT3uEoHZokh8v0nWEfIu7KoqskWYGWor/0EslpJay/mH1kF7i3nZi1qWIgEYMCoMv+yzuHCVwSaXDaUeG7sSFQCCbSYYAj8feVSGRDI/iA1cb+mWXDu1JROPhHTfIUDKLgZrdqqN8rQuUixLmfI3QFJUbYAIa4q23nUpaWtHh6ZzqpXJYsEpPefueO6E6OHUMLTHotTLq8Eysf7UyUb4G01WXN4cJSWkuq84K1oOdapAwCfgfLs= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123556025)(20161123565025)(20161123559100)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123563025)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2363; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2363; X-Forefront-PRVS: 04583CED1A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR03MB2363; 23:JDBf8r9OwH5YJHN2J9aHLPH2YDJnytimd5m7PbRfs?= nVX5wwN5icgfy4NWmwPLsr380XPjavbbEtYEfL4RSugETIBfnbQtplbOpr60sGoOgQJaxjIqGTKLWQBpKQlPvoVcTXmHwFr5PB7xsZGPoUu/5ja+fsbrRnDtAglXuVgepWONsIbgA6LBoGrwp787lf5DAI16kk5Wn/HhRD1qHNMnIge3b0Nomf0mZll2pAhDCmRz3P9TMCrycVOcNNcyMXLmJZRRxC3hAt8ZqOLf+2WsAXZFLiZFK6QC3PHJRIvMS0arlSHAdUP56mxWjsxl+m8ep4R6Tv4NXfzRhK1HKsYLk3qo3FjUDbpAZFUMEAurYH8LOYQ0CKdF059Lt685JkBI0yx1mJiYlpMwHGTksapm488T+Q+aKT0yaz+xdvJ1vnLQm3Hclago+/+5Lqb5ViO0neCx0Y+XIHQIBldq2lXUnxkB76/+IGG0DRGbGfYs45Lj5Xt9NKEQGU5pCo4bOlwNAvlAC3RWT/Qtmlnvf48eNmfTC9qZb6Y9IopfhwuQBH5mZktdh4vu+Cwano9OGLHV4tk7wNZFIWm431dvrhbOdY43Z1TVu6/XgsrXn6IGa4Juvr+4RQAONsDG/lswJ5t38gepHJPKL9tb1j0a5egXtI80Ge1O7jyhBf34N3ZOKAx3b7UCigFhKQQ92Jj+hdRSBoV57MPMqdL8oFIZXqp/l78EhOCRmIbJ0TYHJrIy5BC2bvbRHlVmbr/6lZq/tnTLYKVGaqwdzM/9f1v1SFtLbJDeUuiCjIj3+z2RwZylGbLT1HJq4YngpC+6isFpyTqWwRtjeBZrb1FsO+WSKhDBBGLLcPs2sTtBUlu+tjZrapr0cCQ2vowrrx2xUUnJG74z9jViIApF+7uX5QeGcNv/z2vjPF9+cPY0vIOQCq+yz9rmRi1udnfluDPG7Cd9bNdOYQItDkYopyQ2ONFXCWVKKgEENJ0TUGSwksPVOhaRALAcMzBjnTM4yqfuwgdEopSOmNPtufZC67YgFL+gydeTPFoH1hZhYtjqWnZ+QCL+XZ6wd0g+w9is8JGA+etOam0ouHsua8mMCB6rzNsRhpIev5YGAIX95SomzxuWVXrbSCKb1QZ2lbPMRVvPq0VPsb3KHvlhbxBG0O+8YVkZdMtOeFxhirGqfRDQbMdfuaId1D7foeNnHyfZEiPSRU/j30U X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 6:So2lyUcPPuyYdBK1DsuktiKYXJh/OHNcX8stDob4sNL8DVi4czPi4wptkn8NegZ4kiZLaUDS25O6HUmiIJflFhT9a2iRmcJYaziyQkHbzjs+oUJeO/2FFjwbLOyaE0Ju+LEYC2Ago+zI+elyL+bottiFTnN35Cf7CTpcm7ZCfIok461hFpL4Solpf9sVlm0k5T19tdS3QskYL1p9jGWbcN4S7OTAr97ViCmN1Yp8usrRfmUU+BmlbbpzZFKme9vxxfjmAReNWeNin46hRAkONTIMLprVPH4vOKL6XHR/JDDbPaiX96QPuEkRbDaIM7NQXW7SftRgQZD002RYUvKHBQ==; 5:kW6vhpR35rtpueAXe5GYH97Pj1lqm9jkLIXq2UN8yXcv9ewSbnHs//cNPKc0SkYnMBYUsXSP3DqrELf5Kri25F9IYN1aSqKe3M7YjuDL9DVlrZLEUdiM34sctVcn4DrfJbSCdpPBNGP7ejenrMwUJQ==; 24:+88YPWK+qDoyIN3b/YryhYwI7eCYgVM78KAXrksimbxtlX82PWhyd8gQdiFgdU9md7ZhzUNBwtD30XUDDWYyTZttC5+D7TXz/zCOjQvOUjo=; 7:vK/H/50yrZsZzD+qEXYtceWnhvHceeeWQApA7h2sRQp2IaMJPOGDhrtGVc597fzg6ERyT8UujqyMLAKvhFt7nUvEZpcHmUx82VdtzT3e6O/patTZ2Bf6Owqbg1HgTLdduqch8LOhwIsdvNXFR4W4dyJ5mgnPXFiUoWD6RjlArkhtoiV+hTr+q1sbbEYT7xdyFN/WzFybif0Z7Skt7qKIhWAixQveGt8WLhGCxr4wP68= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 13:10:25.1155 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2363 Subject: [dpdk-dev] [PATCH] crypto/dpaa_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Alok Makhariya The code would crash in case of segmented buffer if no check Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 7b9a683..8a57b96 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -893,6 +893,13 @@ dpaa_sec_enqueue_op(struct rte_crypto_op *op, struct dpaa_sec_qp *qp) return ret; } + /* + * Segmented buffer is not supported. + */ + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { + op->status = RTE_CRYPTO_OP_STATUS_ERROR; + return -ENOTSUP; + } if (is_auth_only(ses)) { cf = build_auth_only(op, ses); } else if (is_cipher_only(ses)) {