From patchwork Thu Sep 21 09:57:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 29054 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B335D1B1A2; Thu, 21 Sep 2017 11:58:04 +0200 (CEST) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id CB8A01B162 for ; Thu, 21 Sep 2017 11:58:03 +0200 (CEST) Received: by mail-qt0-f195.google.com with SMTP id l25so3413695qtf.2 for ; Thu, 21 Sep 2017 02:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6VnwLifLU5fRpcb4Mi0VMmncdzv1sRB/KXZLLhFDle4=; b=ibTTfOaZvxg0W+TFvaSK9G9suxuST2ZcV4NiDvHFLBbKVppPTqpXxoqlxmsoT7NbJK oW560iethwxY0DPO4lNtfwpuirXklyfR0WzcaINDjkJtbJKOFytvl06icyp+aJDAQ2C4 SwXMd3ma+oAL+pZOAjvhPUDgNSMgJlexTcTWXbkPybacLB4QFA99ytKCv0bEQ5921xOI P0oTvz19CCHCSn7wZen8aymvsQ3xZOAhMv5Oeosi29GmdtUgJOLL0PN2Gv5F9VUrdkSs +zPNoFNd/eBE0yXwtrtIhsIEAw+D3w5kVmytLHwKzqyhrRpSS00gTmh7sO2UXkFN9Jfv gw+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6VnwLifLU5fRpcb4Mi0VMmncdzv1sRB/KXZLLhFDle4=; b=a6/mgl1XnQ5agaTfrEgi5jKMtVEDchAboCB79Z5pVB+sN/O76gvgqIAUsa3sW6wSoY agqCi4eIIKvRNVH00pgrV1BLf6Gn91hgZX2PSJgh5L7PgnuVQYRvPNpur0xGC8CtELbB LXX74TSNSE1fbVMis/6Oa0WdGa8gYr3KLoAsOXwfWK79I7KigG00lh9pfejoj5QA7Nnz n4G/to2/hvRLdBQ8fIJ5nzscWZx5jd78I0V3wGn29NLVd+SoKjUghr+3GCwdozSD5H6i TiTmxfhWn44zo7C6kLiExS0wGteHQHo70uXbvDqXFSQe7OyPQLjfmmTJsudHU//yycE2 rhGg== X-Gm-Message-State: AHPjjUhizqmjwoWAANd3dsiXOMUVvWsfct1fWuK4/Do05x1wNUhSPY3G TK9LnyoVgfENO9QdWniA9obcvg== X-Google-Smtp-Source: AOwi7QB4cX7CWYsBbmLxq0n8LqKlTx4rq1utENxrbpVbDFIwwz3GhYc9MlMhdlnGcMPu3+WHO6XC0w== X-Received: by 10.200.8.131 with SMTP id v3mr2203270qth.262.1505987882898; Thu, 21 Sep 2017 02:58:02 -0700 (PDT) Received: from monolith.home (pool-96-255-82-208.washdc.fios.verizon.net. [96.255.82.208]) by smtp.gmail.com with ESMTPSA id n34sm734402qtf.10.2017.09.21.02.58.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 02:58:02 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: linville@tuxdriver.com, "Charles (Chas) Williams" , Chas Williams Date: Thu, 21 Sep 2017 05:57:58 -0400 Message-Id: <20170921095758.30121-1-3chas3@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170919212131.7006-1-3chas3@gmail.com> References: <20170919212131.7006-1-3chas3@gmail.com> Subject: [dpdk-dev] [PATCH v4] net/af_packet: make bypass configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Charles (Chas) Williams" In certain situations, low speed interfaces, it may be desirable to have the flow control provided by the kernel queueing disciplines. Signed-off-by: Chas Williams Reviewed-by: Ferruh Yigit --- drivers/net/af_packet/rte_eth_af_packet.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 7aa26e5..8089eda 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -59,6 +59,7 @@ #define ETH_AF_PACKET_BLOCKSIZE_ARG "blocksz" #define ETH_AF_PACKET_FRAMESIZE_ARG "framesz" #define ETH_AF_PACKET_FRAMECOUNT_ARG "framecnt" +#define ETH_AF_PACKET_QDISC_BYPASS_ARG "qdisc_bypass" #define DFLT_BLOCK_SIZE (1 << 12) #define DFLT_FRAME_SIZE (1 << 11) @@ -115,6 +116,7 @@ static const char *valid_arguments[] = { ETH_AF_PACKET_BLOCKSIZE_ARG, ETH_AF_PACKET_FRAMESIZE_ARG, ETH_AF_PACKET_FRAMECOUNT_ARG, + ETH_AF_PACKET_QDISC_BYPASS_ARG, NULL }; @@ -559,6 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, unsigned int blockcnt, unsigned int framesize, unsigned int framecnt, + unsigned int qdisc_bypass, struct pmd_internals **internals, struct rte_eth_dev **eth_dev, struct rte_kvargs *kvlist) @@ -580,9 +583,6 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, #if defined(PACKET_FANOUT) int fanout_arg; #endif -#if defined(PACKET_QDISC_BYPASS) - int bypass; -#endif for (k_idx = 0; k_idx < kvlist->count; k_idx++) { pair = &kvlist->pairs[k_idx]; @@ -698,9 +698,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, } #if defined(PACKET_QDISC_BYPASS) - bypass = 1; rc = setsockopt(qsockfd, SOL_PACKET, PACKET_QDISC_BYPASS, - &bypass, sizeof(bypass)); + &qdisc_bypass, sizeof(qdisc_bypass)); if (rc == -1) { RTE_LOG(ERR, PMD, "%s: could not set PACKET_QDISC_BYPASS " @@ -851,6 +850,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev, unsigned int framesize = DFLT_FRAME_SIZE; unsigned int framecount = DFLT_FRAME_COUNT; unsigned int qpairs = 1; + unsigned int qdisc_bypass = 1; /* do some parameter checking */ if (*sockfd < 0) @@ -902,6 +902,16 @@ rte_eth_from_packet(struct rte_vdev_device *dev, } continue; } + if (strstr(pair->key, ETH_AF_PACKET_QDISC_BYPASS_ARG) != NULL) { + qdisc_bypass = atoi(pair->value); + if (qdisc_bypass > 1) { + RTE_LOG(ERR, PMD, + "%s: invalid bypass value\n", + name); + return -1; + } + continue; + } } if (framesize > blocksize) { @@ -927,6 +937,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev, if (rte_pmd_init_internals(dev, *sockfd, qpairs, blocksize, blockcount, framesize, framecount, + qdisc_bypass, &internals, ð_dev, kvlist) < 0) return -1; @@ -1021,4 +1032,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_af_packet, "qpairs= " "blocksz= " "framesz= " - "framecnt="); + "framecnt= " + "qdisc_bypass=<0|1>");