From patchwork Tue Sep 19 21:21:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 28969 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59EF1F04; Tue, 19 Sep 2017 23:21:41 +0200 (CEST) Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by dpdk.org (Postfix) with ESMTP id B4310235 for ; Tue, 19 Sep 2017 23:21:38 +0200 (CEST) Received: by mail-qt0-f194.google.com with SMTP id t46so575952qtj.3 for ; Tue, 19 Sep 2017 14:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CzI11EH/RYvTQpP0KxVY91bps5BJziGdN8QHNCOQ2Wk=; b=WN+5mimWMXuE+AqzCoifcivto6inWe6tqTP0GQMKPfFN5gdTlhZn+aFb22iKlxk8lT UbESpYi0xPwxieR08YwzS5CgoV7ntHZuXNhvNoM0cWZACWoyYikoEotFKgQUwGdrlYAZ ZJsvldTRduRmYcsxjK9bGedjW0o33uKYgjF7TYqEIK54l6xFpae86fyhpOhd5xAVxNA4 mVHgLme+BsmHf+ZQ4IFWqvdPvpzPRIds/Jt8HywOmUPyIhW9ZSWvw9O6wXl194rIOYVS H4NsQTetc7UvnhHT32GaBn+Kpm/jfcsOfjXQuRO9b4K7HwIrs/b0cuzNMKGZ1ScVGVeg rx9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CzI11EH/RYvTQpP0KxVY91bps5BJziGdN8QHNCOQ2Wk=; b=EIHNgRJMdhGjM2agKcR8IcHtXnRJwbbEjD0a+ApAWniZ9lt110LCLu0kAidnvImWNS MceV3CL2T/tps/77YxNKqmYtaqounFIgQWqosHyvzmkWT1ewIJDSmgnVT7CWORtvu0md gFNonBwlSglbfIpxmw3ybl8FgNcJWmRzraH+QBWsQNm18s9uBKk4rCLUDYwAXCcQpuhe Q12lcP9S8OjAvLLQ9JF8tTMtlELlj5rHyIHINKR6vWLgBboUaTG83nAy3aiO9iU1QCLp LgvNUDUM/WqMckO14CDA9mgqLHSD+ao0kgFjhqyI7ZY2tbm0Sx6ktpHele79yWuoFQuq J9hw== X-Gm-Message-State: AHPjjUg/JLaON5fQZFq7k1FyiqDT3259ZyPUbqwlN4IB8I0A6SgDswHR jYu0lWtwPy9qm4ocqHQya8vFyw== X-Google-Smtp-Source: AOwi7QCeIorjSbz66LVwxFQwuZOKnq9DNz1r+XmhOeyIthPoCTA0JNPEnKAEnE5RJaePiwYpxb15lQ== X-Received: by 10.200.35.186 with SMTP id q55mr4377694qtq.193.1505856098172; Tue, 19 Sep 2017 14:21:38 -0700 (PDT) Received: from monolith.home (pool-96-255-82-208.washdc.fios.verizon.net. [96.255.82.208]) by smtp.gmail.com with ESMTPSA id t26sm199700qkt.89.2017.09.19.14.21.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 14:21:37 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: linville@tuxdriver.com, "Charles (Chas) Williams" , Chas Williams Date: Tue, 19 Sep 2017 17:21:31 -0400 Message-Id: <20170919212131.7006-1-3chas3@gmail.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-dev] [PATCH] net/af_packet: make bypass configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Charles (Chas) Williams" In certain situations, low speed interfaces, it may be desirable to have the flow control provided by the kernel queueing disciplines. Signed-off-by: Chas Williams --- drivers/net/af_packet/rte_eth_af_packet.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 7aa26e5..a299a4e 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -59,6 +59,7 @@ #define ETH_AF_PACKET_BLOCKSIZE_ARG "blocksz" #define ETH_AF_PACKET_FRAMESIZE_ARG "framesz" #define ETH_AF_PACKET_FRAMECOUNT_ARG "framecnt" +#define ETH_AF_PACKET_BYPASS_ARG "bypass" #define DFLT_BLOCK_SIZE (1 << 12) #define DFLT_FRAME_SIZE (1 << 11) @@ -115,6 +116,7 @@ static const char *valid_arguments[] = { ETH_AF_PACKET_BLOCKSIZE_ARG, ETH_AF_PACKET_FRAMESIZE_ARG, ETH_AF_PACKET_FRAMECOUNT_ARG, + ETH_AF_PACKET_BYPASS_ARG, NULL }; @@ -559,6 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, unsigned int blockcnt, unsigned int framesize, unsigned int framecnt, + unsigned int bypass, struct pmd_internals **internals, struct rte_eth_dev **eth_dev, struct rte_kvargs *kvlist) @@ -580,9 +583,6 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, #if defined(PACKET_FANOUT) int fanout_arg; #endif -#if defined(PACKET_QDISC_BYPASS) - int bypass; -#endif for (k_idx = 0; k_idx < kvlist->count; k_idx++) { pair = &kvlist->pairs[k_idx]; @@ -698,7 +698,6 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, } #if defined(PACKET_QDISC_BYPASS) - bypass = 1; rc = setsockopt(qsockfd, SOL_PACKET, PACKET_QDISC_BYPASS, &bypass, sizeof(bypass)); if (rc == -1) { @@ -851,6 +850,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev, unsigned int framesize = DFLT_FRAME_SIZE; unsigned int framecount = DFLT_FRAME_COUNT; unsigned int qpairs = 1; + unsigned int bypass = 1; /* do some parameter checking */ if (*sockfd < 0) @@ -902,6 +902,16 @@ rte_eth_from_packet(struct rte_vdev_device *dev, } continue; } + if (strstr(pair->key, ETH_AF_PACKET_BYPASS_ARG) != NULL) { + bypass = atoi(pair->value); + if (bypass > 2) { + RTE_LOG(ERR, PMD, + "%s: invalid bypass value\n", + name); + return -1; + } + continue; + } } if (framesize > blocksize) { @@ -927,6 +937,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev, if (rte_pmd_init_internals(dev, *sockfd, qpairs, blocksize, blockcount, framesize, framecount, + bypass, &internals, ð_dev, kvlist) < 0) return -1; @@ -1021,4 +1032,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_af_packet, "qpairs= " "blocksz= " "framesz= " - "framecnt="); + "framecnt= " + "bypass=");