From patchwork Sun Sep 17 08:12:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 28802 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7484D4BE1; Sun, 17 Sep 2017 10:12:58 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0050.outbound.protection.outlook.com [104.47.0.50]) by dpdk.org (Postfix) with ESMTP id 454CD127E; Sun, 17 Sep 2017 10:12:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OAdDvZB0p9UQw4AMTBhy0x+4KltvqAL3X0OTpnvFwSs=; b=Fu0OzWMMlvJFncfehj/2ZFklDmsHa/GSUI/eUjqkao7Pwl2efhVdKWz3EYoU4wIT6vQ8oyplcdxaFIvoEH8TumabfWlnZLto5+YMqTrzc5vvNABbYIWZF26K1FCOZ6cSWpv9ZVFrK/kl7mbyRb4IgZa1YMDJA7cJjxa4y26s4fk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by DB6PR05MB3141.eurprd05.prod.outlook.com (2603:10a6:6:1a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Sun, 17 Sep 2017 08:12:54 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org Date: Sun, 17 Sep 2017 11:12:49 +0300 Message-Id: <20170917081249.65181-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM5PR06CA0012.eurprd06.prod.outlook.com (2603:10a6:206:2::25) To DB6PR05MB3141.eurprd05.prod.outlook.com (2603:10a6:6:1a::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef2e409b-54b7-4adb-5409-08d4fda3e692 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR05MB3141; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3141; 3:gwwbzEyEhv8ryO4pc700tNUhVC0Sbs21VvJNXuS2SRDEuq3quDwE996nyGBbW5uX71jqEJ1qo5BhzEveTh+y7S9KprQKqg4eXUwfdPByDJYUxXuLODW/cExvAk2OC6DfpjLA4Z98j/pitHYSN6Ejzq1+P1CTghAyk4Mz9qYaxKpOvjkGSrjbF9VpsLCwWZ/zHjwTNUcfMiEqwnhYM1j2QiX00jL7/QMx32geNuL5QTgpJRdDPkrZ3hRfzkEVlPXu; 25:+vMesIl1x9ld7BjFRv9YTAY+92no4yBbgrrcaZdhXmUHGEN3+fByq9rL88wvJljIcOoePBQIN6yqza7Elq8homPFntnEc5MRkLu/GoljPoUu2A63SfyHZReq257ItwxbvwG6wK0PEzdH1sh/D6Egl3KXl3y1o3wJN4Nz3nbfzYsDB1CEKr1pdSkKhoI7d72DKiGwpJO9sCNbtN3MySAn/2QriJlmHlo0YttTiivNEF7EhftybVMnmT9sflOU6ZOKorppLJfv1HDkYxIyRlBucg26OWbbkyDryPB7VUgyJrOLW5aBVjev1imPwwSJisjIbYVdJVrOi4KaJX6z5Tk7XQ==; 31:Saf3TcKjT+HGwYsY5mVjvsyuuE13I4WHfUiI4LVeyh5BCEnKKKMkz5xry2RscPZYF//PUPSQmGakgA+3T8KIbllXrUUcI+xStYS0YChjOw0C/M41HJe2/9DGp0CMKP7bJOHMKl2sxlThmBlgsy3dtwHwUJLN4+oxOqMpn5DfiUsYBcdJGmVr5V5qjaTVoCDZobgYRTn3J08q00D1oGE7fhM5E9wgGH+E/mTvyfofAj0= X-MS-TrafficTypeDiagnostic: DB6PR05MB3141: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3141; 20:FUsprlKca4KiNsjzQAqGgz5c7MODBWyp51u9BZZEUvZDXndEDo67sNxIb/o3fUr8HFCR1aWRxcDYC0K2tUk6TBya9YDzsH1QiIAoP86Cant//b2fVAYItRTwHCCbhJIlGQ1ToH6eWt+cDjhoGI1YCnaeMh+NeshNBTVGDMNh64GRO9Lr272Td+UOBmvznZDS9KDhrW1lIUNmFQUTKxG38RbN6jUL9aH7Rdqy8Xkwf/S8VM+QG5HGDastAqEA/rlKyZO4suMczcsN1pmO+AAFFHazp4dmrrLuRNvrpQMe1w9o238AL7ZA7AZrVKGQ6wWGjEujnphyk2S9SAOGlLzhm0OGA0wAo2aKUOXzKCCI5Luw/zdQ+ycqwjIQW0GPznpr0sLv2My4X/uzFoMg2petA5P47CGhuJcHw3JiirHZripJIsDqk1l/bSZaxtSMD170MyYi6c5eU8uvEi+eFks/qxmfNFmvndhz3wowC669SE+hpjpRiz5++NDa9jnIFwfB; 4:h+vtC0kvgUdphBAbcEgInGJcsXKYdBd6/AdqTvrbx0R+p6lV2+xnFxunB09eUjQvwfU4c36NNPJEAuex9lzWMRaIL+9qUgQaSiAXnmU5DhYuvt0VvQcH4t3Iyv+Ex6ad5HfPxAHqDO5Ose5u2MO7bDzN/+jInek1NxeN590cB33N58gMf/N9lwYX8/eJIgC6iCsD+ktjYJhN/XzM8GVfw5OWyv46lm4rdV9+Ntv/zX5H2fYU4X0W28lBi3r/AY+F X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR05MB3141; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR05MB3141; X-Forefront-PRVS: 0433DB2766 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(376002)(346002)(39860400002)(189002)(199003)(55016002)(2906002)(7350300001)(3846002)(86362001)(81166006)(50226002)(21086003)(33026002)(50466002)(50986999)(101416001)(1076002)(6116002)(69596002)(81156014)(8676002)(4326008)(33646002)(6666003)(5003940100001)(68736007)(48376002)(106356001)(110136004)(189998001)(105586002)(47776003)(6636002)(36756003)(97736004)(66066001)(25786009)(16586007)(478600001)(305945005)(316002)(7736002)(53936002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3141; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3141; 23:y/Y3wSxZqNKTiG8j05XZ2k4PuBktBmQn8tDZvyow2?= XweaWMIOpcvLP8JfKn6rv2eug60VNT+kEHkbx5RIrpHdwII3/G062hPhnI0IgIXeFTz7xho1Ho6Quhp+wBK7PYd8Ossm/aiFRUweJU8Y9Jt1WbWSy3iUsTvlPgEQTbSJcmA72xJVv+Hn/sLqwZ0nfxljQgKnzO49LeN+xTRlv5u8YnRIuxK/d30DDE0E00nYT5sNh2ODf3ZThQvAx6thRjMRo5hB8rmHSruOULS0MBPIzXYznepShm5JHYxGkshv6Ji132kLKc7J2cbUB63SrZW6fXwZYSAUob9e3XB5yMRw0/DvupJIuzCmODCo6KvzmDxMCvMs1FcRk4krOXBA9jXh1N1V++Hc792Klh6ShW2zbuHZf7IPtYxhAHCmWbL+EiPJCxde2J+wbDefqFoyUoxv/95eqkYqkYhm0ER1qZsBhTfDbt3PBuEuECtNRmueDxP0q3SjnmTwr2Ak+xGChxXsfB1CIObMQzV7B03s/IcWtp6tkXvGLKJn8tbsDz2m2s4WxwfrGQc+f7ZjkcLUWarlPWZGjcjiuXhrCmbbqVcdHOl+917JtiGdL3XCnSqEQY4O0B/D452sSVLzBqYz5rmd77t93ZdtClQv4vwFS1PNlMeOj5U/xTJyGnis+NCYaWIUNIU2esb00ioPafWo6zZYLcVz7A4qRHsP/abBk+UvF+TsY+dnzQbqzNE6tWT8UKISKhv89D6rBqp00Chdw9r2xBBasvdneHrD54b0aQ9SpNMYXs0Y1LTVTw1UukG9RdLRCr+xvoYBWbdsrDAcQHOJz2oy2ggdsUByteaEmc6uUent2xOnpsr2N45Re2Su+jxRHbokcLDWw6A0G4eEBFr+Q29CFJ+eNGpL3HxWKLEFnaDWHhHl+lb4bZ469q/ouH+v3wK+Yp06Q037KJd+/yE1Bs4jd5ZDUDDnFPX6mhLQskVwRY8p/Y5BRAFecVXXuv0yvDwk9+DTg9aCNYG9UM6T4swkjy5ketOEsSXBETqEMtL0cUQpfX80FHN95QifLSEW22PotEYIMfJWAp/CrbOpXNZ31W8VXqE5Hm4lTP8JcNcMYKWefcpD8Dz3yhLrGUBnc2nR2/Mvi+GM8h9PV3+5rCLYqS1r6qcCe8BbMZ97w== X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3141; 6:Sh61BW0tqL9sdTeTWufQoHO7kJ0U0pG2fSekeQ+bMqVHb8QipMcu8a+wUY1AT1tJXnB70MSRBA3MQwlPhvG6DtSydXfx5o57S4c4c9Ra/F4CDdLGi7uvJ50s0FRrZULTRniX37dKLdw9H5QqIYO1JgJ5bYyyttSuxD/mnMWmZAQy0uyuEAdLpa/SoiBIBW6C/YsbADVS0zRlTD6SwBaKlhzH/iotLBW9u5I3uR2ItxS16OAj+e0ynAV547L7PWh7+ko661WOvEhWswSfmWg6HfFUDbpXpY/tmHkvV5DS1+Ep22ZzZ95hbKUgmmZW5E3FWU64y2fBPKJLO5mycH2yiA==; 5:nQGlt4ASzDRVq3gitl6n7c6Ejo5xdobDVRC4s0f5KS0Jr4C6GxtMEo2mKvSjKAFsCG6fNs0y/XvlGQ5GZwVX1en/uyOBq8j6147+TT9CyTu9eVqSk00Mr7j4qsvzc56RI+muVAnises2AZqRTlDcKA==; 24:q8diIFEry0xjIFBSg3cMp8EDPPTdOnJNRn6K9suV8aeTNLgPl6eKQIw/UMPRKzAXo00rNV91klaQCe/+zD6Q7Muc13Z/CCCjPfvKMDbUyBA=; 7:ZIReKED3UEqf8hkkB2hquulZgpxcYaTRNl+CY3gL1swbPK0TJA4dmUcYkCwNIU+uO+i2tFoDQo1ijEv/j0eNdMcHgM3f8LMWtkWWV8JbusE4ljlduE3Cjd+ydj8144mvjIT7p4pE/MfxFjnY5swz/9wS/zcgcw4cVTjsfJWQnQdpwpkOwyqiigGk77FI05flQ4VKGpLBCLheX3Q18BhIbuz972vDvFA0K1l9nn19iMs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2017 08:12:54.9990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3141 Subject: [dpdk-dev] [PATCH] net/mlx5: fix TSO segment size verification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" TSO segment size must be larger then 0. Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index bc1f85c93..8a1829aa7 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -475,7 +475,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) tso_header_sz = buf->l2_len + vlan_sz + buf->l3_len + buf->l4_len; tso_segsz = buf->tso_segsz; - + if (unlikely(tso_segsz == 0)) { + txq->stats.oerrors++; + break; + } if (is_tunneled && txq->tunnel_en) { tso_header_sz += buf->outer_l2_len + buf->outer_l3_len;