From patchwork Wed Sep 13 10:47:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 28657 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F7651B1BC; Wed, 13 Sep 2017 12:48:11 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0063.outbound.protection.outlook.com [104.47.0.63]) by dpdk.org (Postfix) with ESMTP id 346B91B1B1; Wed, 13 Sep 2017 12:48:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2UIn0FmyZO6vZPypL8FVoxzWa4gyCKy6GTamOSJ+nqw=; b=POgOl0AnuFTUYi8v5JcNm399HiNBnbFbqGdmWd8Eor4xEdc+ThbRXnGDS9mI3ytWWC7NO201Gw8wbIyPapLLtbNb4o7bLrLoC9sRVHm3/WOqMm66e8ZniShZiRKk/yX+iyJPdvgvSJOV1pcTXVh8W3cDxwuYLttKl3cUWTnTPCo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by VI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Wed, 13 Sep 2017 10:48:06 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, yskoh@mellanox.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 13 Sep 2017 13:47:55 +0300 Message-Id: <20170913104756.129102-3-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: HE1PR0402CA0047.eurprd04.prod.outlook.com (2603:10a6:7:7c::36) To VI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30e3620a-7e4d-49b2-34a4-08d4fa94eb51 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB3151; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 3:ak2bvQuirjuINB3tVSBKZ4LzGK5gUIfmRc6M9i4qQ8MJJHXNZt3FfAFQMDV/XhcbL6O1TRzpBaqRqfJRRH7RzTrdw8FEwB1tWyE9dccOkWpOl4dbuTG8jhrCWmGH+hDn+t7vDLo5xaUBnxL1AEJj+lOFF0cRI3xSjkiqXDpAojSI+1DpG19vtiAldGKCU0VcI2ZrQda6cqiQeNeL94aisrELhmxT2G/A2J41/1t4I8h1A/+a0R964kmR86m0bd79; 25:JibTYxBsg9Iw3Vwz3z1UlBa0uoGkqO0ntbc/TEPyTmfHDYAPYYZj0+1Tz3N+vQosI40LDNiUKVcRZgraEQVVIV7mmhwq15JyU5/1RLPRBgpxiCJ2lAAJ24pz7etAdfgmFdx0mQG5KePi40NkDc2FSTL99Wjjr8L/7elH4JAfSNw2akKkcPnG49QrfJQfhbJwo9D715YsYttOlmmjzqsm8G+KKexvmYskSfIlObBaWX6K5WNnruTc+VT5FrCO+HYa9W29U+jvJt7mh2/dMUjWSeeoLjMTkX+cK1o4/USC+fh+8Kd1o5mQpMTbcKFOzVDnwI7GnMGccY629NEnhs0Oqg==; 31:6gMyPPGE7A5KY2uXBU8o1BPdlOMbUTGpQ4PFVRwp5ryWJEEn60TbQB3cJGrWi5Qtd5V8lKviAe/EsnLGIoroelhjgq1whV83Iy71k7V0T+iJ000mXURXnQuztKizmofjp/q5+ZmB6Jpd/5W6RQVLJd+FRioGsARylalo3ufezIkdpS+5KEQ0N8OxQlW+cjtQ7ULXhxfkzgzqJf1Vqbd7h39+ULBumU+hVbyHbVd7B+Y= X-MS-TrafficTypeDiagnostic: VI1PR05MB3151: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 20:C4fS+qBnnu4eMvndBSPGFacsz4bnwVuJeZRyu0hzkGFiMKzuWqrGhSVlDzyBh9B21J1ESgM01p0JPWkkCNImjJEh5W48puUggEQLlSrlmoGQto0+9sshxEIjrRRV0qpt+UL0YQEsplQeHFeXHcSHQ8VY5JA2X245PNIO/h49Nv+mteQXx/j9FO3S9xzRjzp6iK/3F4gj6BdGCUQiH152/dOUf2RlkGNgIw62I07Xtrke3PbqW4iMHGLoUDYvubuEjdXNuCYr+uNpMnKPW8Npsi+KqtCgGsiJPUSv21+zp3KSVfmijPIqwmaz+cnKFX7C+nV3uAXBeYaecq0dHfifYMgn9Fruix4RvXz3gEg7R7d8jxXTDOzaEb7lGq6Q14a0JS8UEanm9MobyFqL7yEJXHchETr5TaWuNyiIGH3Ty8PQENL42BgIbV8EdjodczIhAdG9UEeGD82wQjpiQBSr/RpA1rAzGIJqeQpLgTm95Z02hT0MkVFs12N+wTTzMCJQ; 4:yaVMp2rXMKJC7c20HSpRsDOXet9C/7oj/gUrXJoaA74ISAEADg04AcV87S0Ypljb6g1A5lYu/mIzsrfuL3uLhSFTRNScIwf1QyTa87/a4ZoPcF54TtzzNGWO0mqed/6GLzjFeXww3cK6vIhX5hG/Y2cqIQFUErbGqv943qVuSnzwz85YtAJOKwxJOVNM1rZWOXl5eTnrX1IfXZdjGg8Kz7As1wnJwpzxWusLGPPaIFr4cu8Luqk5IEyegtxZsaUX X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3151; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3151; X-Forefront-PRVS: 042957ACD7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(366002)(376002)(39860400002)(346002)(189002)(199003)(6666003)(110136004)(5003940100001)(4326008)(2906002)(33646002)(50226002)(55016002)(33026002)(305945005)(53936002)(189998001)(97736004)(36756003)(7350300001)(316002)(81156014)(68736007)(5660300001)(81166006)(8676002)(69596002)(50986999)(25786009)(50466002)(105586002)(21086003)(86362001)(48376002)(6116002)(3846002)(7736002)(1076002)(106356001)(101416001)(66066001)(478600001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB3151; 23:Cvdi9ZnsdHHcDNCstEbyyBFB1aJPhz6kGW8O1mnjv?= fqyrStR8o/43N7KY1MDh6c1bzfZjhc7wPiZ6oFHGZTCBFINvgiAOGo27qLz7oAxDSi31VFCUh3e5cJAT7sgfjZgwJrBqLlg9XRJo/8ctShoMdpfqlyX3KI2QPwVG+TKmr++Y2uD9dMD0i0x44y0ozA9tEy53+G43pWhirMyrVoYkZHbVzUXDBJOk8oMGxK6HSqY2XaKnv4lyvwcpKNl4wWPNL7V8GpIWPSNP/WpFMIlV+9o9A1u/L/5CN5DE52oChdeb8H/xbyRxFkAG5HLLs/05CEYGKhn586hgsE3fwIhBysXPQx/J6Txg/kAMOJji/mzougWgXXgnxhx7OQkjGPGm49Qq6WMI7mIRoNm4mWLCNcuQZfokvKVKNLAK/4XGFoyHDNFGEfXLuosICc28aD3DAJxmgfoFipTuAwFbhA4M3Y9B1WTraaw27opuQMsETkWSOrDfRiH2Udjg8e2/6tv0dtx+kmuCWdRC1R0g2ksLP0mtTryYyRXjkGHopbvg8PC88Mfg1opP8juJYjG33LRzMwdMJLm5mvp13edTQO7AS++QV1zpcq/lWGVOywZ2ydiQfg8JpqEcdi4rvL6gzI1Mh5e9T2W8Wf5h6nMBYGGawwDijoFhaxinGGvInCtDjU9TYUYDMz8IsKw1p4W22Nueumr7z19DKXZ1waBmrARlC+sZRxR2Rkvpng9wuIJLm9m+g01rg88ErsxbNClF+NMG9kZrtmRYPmoN7Zt9r8mgJk3o7/xge3vlFfKq1mK9E3JbujKZr2f0daahq+r2OXjY+TvChxFPsH1wejui+lz7Hckjf14+vN1Gj+vbhKTQZ6t37wMsU3SxIr9vh74nqaGRPsO+fNe2iHwJNc6o5HCf236Wy2pkwIb6duowzbRb3lCt4Koi5uXDjKNUfjDUH4iTEaosvWbBy9wFI4E+cJy2S0QNy3m7l2Ue4f8JHQ2DfC0k1oph5xmfWMMwHhuxtCH+jtOHiBe30dIKdVvovSBDVlisGDPdp5WpnS+7u4qc6VktG99tmbAJjkdWCnw1QReKYOqlavBzrgciRKm1ml+242dHNbSem1DBclLPSuTYRwWnPAKJdAzcs3zrIW1bgYN X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 6:+/be3zaBSt4kedZDgf9doKL8/Jx45uuIMeY2lbciMRrF/aC8b20+jrIC7GWJUzQibsCW4WTjh7Mv2V3UVS7/DWSF/GWKcqKMkDDum6DpSzaboUOvZycdbzvfJpni5P8FGXvSn0VC6fZmwGIyusCVHG9glnVDnXfgFYuwSxRjId2KPj3dYjiVXJ1421YXI+EjsQeMq/9/ZwhaE85YJiqqRrG4zqTRtHTV8NLnBzDkq1q+HOogQvbOApQwiwJlSXpjNNC0j/WA2GGzYbOQx10yxrtbbtPnjr4ciC1sgB5tJPyq8cninCx6MLlUuLX9UWYp4blVxsvfwuOmJNgagrHUig==; 5:Y4xfERk+Iq4iR90iGL74G46RQ+M76BSIVHNFhxd6PB+VLahjSoK/4WLGhCF3jHjrBEx4tROrGRYDorzR2tUik2e0fcnmmaktRw4zeoFYjU5sLepq3a962OkfIxXURXEkm5GvPn4ctOWUmQ0YdEe6lg==; 24:898O9F9I12Ekme+om/IYWycc3EhaYwIo++OdO2xfcCaMFzp/HPoIOPREltN1fydZWWkUdYBY+c+3WpuPH7Uj17J3HUJ/BGIihviNm0ZCZCo=; 7:s7+Elw7qEqRe5neXPvqzb2m6pEKwMrHd7lO67Y+X+TSFtgWpe84UgjlJ+x0nW06wu87hjYXA6bIqMMerbZNekitZyyjIuZ0zM01f15GxW9PyNZ96yAAKkp7/WR1sxPhE1c8czmQFHEA/0atmekkQxGaAb0z3OPDELW4rEG7If9/I42PCtcD5G0JBX9MSW4D3ru7dtLM5wAkeQ5UKoVleF/sf+k8zn/PHpQJxDFDObzE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2017 10:48:06.5841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3151 Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: fix Tx stats error counter logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tx error counter lacks the logic of incrementation, making it useless for applications. Fixes: 87011737b715 ("mlx5: add software counters") Cc: stable@dpdk.org Cc: adrien.mazarguil@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index fe9e7eac0..7567f2329 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -406,8 +406,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) #ifdef MLX5_PMD_SOFT_COUNTERS total_length = length; #endif - if (length < (MLX5_WQE_DWORD_SIZE + 2)) + if (length < (MLX5_WQE_DWORD_SIZE + 2)) { + txq->stats.oerrors++; break; + } /* Update element. */ (*txq->elts)[elts_head & elts_m] = buf; /* Prefetch next buffer data. */ @@ -481,8 +483,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) cs_flags |= MLX5_ETH_WQE_L4_CSUM; } if (unlikely(tso_header_sz > - MLX5_MAX_TSO_HEADER)) + MLX5_MAX_TSO_HEADER)) { + txq->stats.oerrors++; break; + } copy_b = tso_header_sz - pkt_inline_sz; /* First seg must contain all headers. */ assert(copy_b <= length); @@ -843,8 +847,10 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) if (max_elts < segs_n) break; /* Do not bother with large packets MPW cannot handle. */ - if (segs_n > MLX5_MPW_DSEG_MAX) + if (segs_n > MLX5_MPW_DSEG_MAX) { + txq->stats.oerrors++; break; + } max_elts -= segs_n; --pkts_n; /* Should we enable HW CKSUM offload */ @@ -1064,8 +1070,10 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, if (max_elts < segs_n) break; /* Do not bother with large packets MPW cannot handle. */ - if (segs_n > MLX5_MPW_DSEG_MAX) + if (segs_n > MLX5_MPW_DSEG_MAX) { + txq->stats.oerrors++; break; + } max_elts -= segs_n; --pkts_n; /* @@ -1353,8 +1361,10 @@ mlx5_tx_burst_empw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) if (max_elts - j < segs_n) break; /* Do not bother with large packets MPW cannot handle. */ - if (segs_n > MLX5_MPW_DSEG_MAX) + if (segs_n > MLX5_MPW_DSEG_MAX) { + txq->stats.oerrors++; break; + } /* Should we enable HW CKSUM offload. */ if (buf->ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM))