From patchwork Wed Sep 13 10:47:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 28655 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE8AE1B19F; Wed, 13 Sep 2017 12:48:07 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30083.outbound.protection.outlook.com [40.107.3.83]) by dpdk.org (Postfix) with ESMTP id EC3CD1B194; Wed, 13 Sep 2017 12:48:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=U2BHMXFtdqljlZGjf2zqLGTbEH/OBeFTNl1xC1/8LxY=; b=oQGbIKgn68Pq6dzy7ReulaMCePwoBqd22M4+bsaRjMrLjH0vMfonrbs0zJNYDPSp2KN2b2RBjjqTMX18V+hq3lggpuoR4O79xwe4/x+LRP7kCOzENez7Ya7/oSw6Rki3x2siGA1BSuNxiYCnrOq0nJHDMdCUcpr8PHSinsBDmtw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by VI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Wed, 13 Sep 2017 10:48:03 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, yskoh@mellanox.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 13 Sep 2017 13:47:53 +0300 Message-Id: <20170913104756.129102-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: HE1PR0402CA0047.eurprd04.prod.outlook.com (2603:10a6:7:7c::36) To VI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0b2dfc4-2e31-4e65-3456-08d4fa94e98c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB3151; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 3:4R4BeTMqlcvJISsKgd16UgL4VhH77+Vp82FC00uVT+k5J4MHECDYoF9Xwz861MEWe45uD8/t1hkwEuBtvM2fGWtBHs8JPV3eZDqcDW2yOIRgy6LbVFtidpQshNhslhgrNUlE2S+tbkxmVTP59oauO0w74KGwfhMR/Y394aiiKBdVyEuj34GIuEm0rKg92Yf79b/LO2R5TW63FXxbSW6++/Tq7MjqXH7Ci7Wpy9S1EMKrtGRZYQ8djyK1TtST/e5m; 25:TEdH/3WXo0lAP+Sj4achMC0PEkTLhxQZoTS3+F8k2CDZD2LQGmALZMRALKms1oxdrzY4+zRn23dweqvHd+dsDUxMWcH+rGvbfNR2oRAue7OVbi5tEnE5erCQk+8RZnePeFXC1YxrQjUWifC+WUxu/JDmqwL9UixuiDjZZynh+WT7lChrykSwJNfNUG3qmLLjCRhwPVSVuf5Xy8yw9GEcVm4vQGffi1IZ0rhA+YDgk4uG+3sbZH+UTyoNXqPS/hQDC3f6Ia+WNpFcAmWR3leGyfd8m+ex3NJY9r+HyKGAi7DDucBKmXbTIhGkbrjCw63ZhEwL6RfeYsWjWUH1CHMedA==; 31:foVrkbDvf+JmU9XpmQdkNAf+QX7q/BZbJhBGUqWtBTMMvt1LzqZ8WoQIB4txxVAjVAwkANcZo9pLh/dJW3h4q7FOUPccWvbZRFXOM6tjAP3LNpIPQoo/SZkPOMtcNTBQeFGp6lYAveal47gYRNygejNfXdmQu1YTKEx+/ly9Je4ACRUs2V9o8LKZAUwsEQ3CB13Fp8hw5iKsOv5hMk5FHRE1ScS+F/7IAQsFbDqs3L0= X-MS-TrafficTypeDiagnostic: VI1PR05MB3151: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 20:C3CR61KxqVEFNj0EFzUw/5WqphIzx1mx8PhWZtKgwDvOLdiDUHmAzEK0x21+bdHDwGpPXYyWW3l4RlvO/OKcrXDs7W7sjK8hSqquF4/W763GHfeItbwEjh4ExQ19HqM0fHyr0IH8sw+GRtnREI1Oiz6ji1V+NlV6+H97+ZHC2zgcn7VjPBgVQv9uXgaGbdBRO1lqh96yn64feRDSuXJsCgWqNPAswY+X6uszZvk0Mpnns6FXr7PwdrxI+Ac4358eUag4qJF/x8VgfBbftNmnTluQ6YWV3+oROrzAhnQuR7ez3Ayvk0BnrLO7Oyk7a3LYGwVaYrNhnZsouT9z5w3zm/RqmXBD4cLDHPOX3OP31ODWR30Wr37aD0QEbheyJBsbR6uxaGVe1s5cAYOStLzfxXdtMVtvMNK0QiPZYqIkaP6YMbK0t6hHGySMowRjewz75Q3/ZJQLBvAhkMJhuPZJlOBSAMr/E/LltYy8dUtkCX6uxLAP+hqorEnahu8t6ywF; 4:kZtcFDqdVxBHEv77wjQJIrnTpV7IR+Q2c5PhaXW9znfkJlruTC8yB+gqkkmyiVbzm8rOY2jzvCUcS1uGBGvEGRZSnbNAE9PgdhC3ZhiB3o1QdlYYfhROOlXC7oDnmrZueTPxRoPVgypKnx9gxHD5y7ClQ1Lp+xhWtPY4EdJwuFni7jLXe5wws8mYkK5OrNw/nWj+S0u2b4x72EbSFhAow2TaHHv349kcNejEXBjVp+5cjd/ynBYnxmfu1FKCKbXe X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3151; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3151; X-Forefront-PRVS: 042957ACD7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(366002)(376002)(39860400002)(346002)(189002)(199003)(6666003)(110136004)(5003940100001)(4326008)(2906002)(33646002)(50226002)(55016002)(33026002)(305945005)(53936002)(189998001)(97736004)(36756003)(7350300001)(316002)(81156014)(68736007)(5660300001)(81166006)(8676002)(69596002)(50986999)(25786009)(50466002)(105586002)(21086003)(86362001)(48376002)(6116002)(3846002)(7736002)(1076002)(106356001)(101416001)(66066001)(478600001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB3151; 23:2XG6PWsTdC+t+cZM8N4bdfgK49h8Ti6rNLbGQeeWe?= YYDIOOAdaOUJe344gv2m1TuxBjlF8MIXoR5OzP90zMGLDyrtKM+pan1psnyWWargccXK+xGMqjfyhN1tpvdvjLxWrZ/hbHmEmSRrBLqRGSZN1g1SstpyoCSXqOR+vvqPY38w6lZ6u6DJKgVNKiFo0geSetewPBvjCK9AjPAd6dD+wkC0GM30mOY3CkMjgFTyMWBPhhLmgeu+ao1MAw9WsXq0N5kR8aQv4fLT9YdvgpbBFQCZn6iBVWYiFF4XHTtFpsbszEC2Co99xfbT1JxCgletfbw5QRWuqJJEFwOW3Ca6En5MUdqnIf6mm3WYSiQPazc6rSbr3AuyX9rM6CpNzsJvYu3shtcYS0NZtYQNS/X5nX+HkJtwKI0Ci77dZNGED6rm0phfGDgoyC3RO1m/5dSKUw3ENM2RqwNMQfUk7Ow3xonr9qn0laTfYPIBhszUvGGdWYdA8CnXtldbbHzQsuUrI9mvrQOExzO+sZUh0IpGBmpKGd5t0gA39EcFx8X4F3j0KVIEQx1RRETYYM5k/bdeNlRbo+SMaO+Fh9GY239yUGDx8wEIo4YwrCFBt9yvSA+uePvnAi7OKebxKBHRyedNVuGX7hJ4/KmPhmu9fuDD6SLSyknT1GxqxmktaCZhPfX4Z8+VHIpuYz1WLwvqO3cZa7+Eu606Lu1yI7qozGAxWPJfA7CAH6E3jsJ73nkOhnfu+yiGyvXbdirHeIi+ED/NLZM6tcPeDhCHQkwtQmszqFJpBYqp9XOL/vROQNssNge6R41v5eY4DRQtNVuF7u2PTGiXunvln2SRNQco3ieQVQxHPc9uxwrbbSE+Vsc7z2opf18ypm1LTVzEDdQVqcLLbFB86ppp00iENrhaGOcgbpTqnrn5FBbN8g9KfYnSnvRZFWlj+C2PNJW3i5rMypw5p4to2oXWoojmtVgrwjxM51nH11GOK65yaOHBKnuHAwELpLuiJwpT0WOc3AgKR/VJcSKSNyDKmOHEDKErdWtBAZ5q2EYuODLtw81kP9+4EqPyd6EUc0FJiO1EUcFWs/xHYel9Cuh08C+WVyeBvdD5hQUi/YB/LounRByyW0km3A6nC+6NTq2JosgnLgxI4iw X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3151; 6:IuidDPp0kblnvXxLGUWZlcXMsjtcZVn/uijIdeqxI2zgKVFqEewnl6rpT532st5rDfWWQ1MMyagS6vp+Puzt1hVM99ZD5zdgeZzvnDNQ8TgolHuOxDaSG+U7aIcRlTcylox0Z4qeuFDU1VSAv+H5fv9OdrjvLR1N3v5zvkM8bXVQSnHuuDg9QHvnSMinUcBjjpkmWPEOxfKSkGsAORLAZiG3UIbbuSprAvf6l01qyKojPeVOt67r89wvJ6nfptAtx0KLqucxTU6QmIpf4W7hK8jM7/eJ3DvC1wvtdhe3zrJoK5v9bseLgMpjdT3ML/aM550Ph44WsMAZKK+3UHPfyA==; 5:iV/6MOpC9ptAJ29uyq5fZ7k3JwDIuG4yg3w6hialeT87YpFsnapwXXFPfLhk8s3HZtDvihp1YTuxNqjadjI4P66zlgwUf7Po39dvy2k5Lj2GrBaLZ/b9NpjM7KE4IVmLtYX3fxg8HWERv4avcwr7MQ==; 24:/WrLRk2+AJFwWwrC3N/YErJxOt/sxN4ak2RWljWgrNQZPn7HRF40AmmKrT1VWydP2zOqwaVlRx4f0icO7+KoVusMyAdrvxe6h78GpGeg+UE=; 7:Dkf0yAcKXtJ9/E7ff4NRzwN97cr33pOTwsBNOX/53YEtf/TtfopG3g2xW5Dko0MmyjsS2Uw3A9BSa4txZYHiLJjYs+3ITtKHYaT6k01f2IkwVin6aGPwzDs5xj3zoSFIwJ3U/JX5XocRXoABIzL962pWXgC7QD+BS1H4/OuYaJ1sDcSK7I30ZNfMwrnNIespoA+Qfm3DG3ci5bW8i8lKxlU1P8uFbwdJy4TvHxIQuWY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2017 10:48:03.5997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3151 Subject: [dpdk-dev] [PATCH 1/4] net/mlx5: fix num seg assumption on vPMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" vPMD Tx function assumes that after the scatter of the multi-segment packets the next packet will be a single segment packet. This is not current as the function can return due to lack of resources without sending all of the multi-segment mbufs sequence. Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") Cc: stable@dpdk.org Cc: yskoh@mellanox.com Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c index 37854a73b..f89762ff8 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c +++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c @@ -112,8 +112,7 @@ txq_wr_dseg_v(struct txq *txq, __m128i *dseg, } /** - * Count the number of continuous single segment packets. The first packet must - * be a single segment packet. + * Count the number of continuous single segment packets. * * @param pkts * Pointer to array of packets. @@ -130,9 +129,8 @@ txq_check_multiseg(struct rte_mbuf **pkts, uint16_t pkts_n) if (!pkts_n) return 0; - assert(NB_SEGS(pkts[0]) == 1); /* Count the number of continuous single segment packets. */ - for (pos = 1; pos < pkts_n; ++pos) + for (pos = 0; pos < pkts_n; ++pos) if (NB_SEGS(pkts[pos]) > 1) break; return pos;