From patchwork Tue Sep 5 14:10:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guduri Prathyusha X-Patchwork-Id: 28385 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 31D783770; Tue, 5 Sep 2017 16:11:31 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0049.outbound.protection.outlook.com [104.47.37.49]) by dpdk.org (Postfix) with ESMTP id 6478B376C for ; Tue, 5 Sep 2017 16:11:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=derTOoLow2dEVZX3lCbbCWap6kx300cF23676BQBWd8=; b=hZAgzXteGL0kyZwIuhyezSS1F7LxOkbkjzJC2oUHg+Nql3pyOLjaiZDYS74b7HuAgDTDAtaSPsHy7qdq5pYMyaFjXjrxn2dgg5Wuz8/JdwOJUGHncTlZQAQ23T4S8LlvBWh0TwG/1Vx6cjyG77y/HUCGLwxBpKaK/YpHEzmShds= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Guduri.Prathyusha@cavium.com; Received: from prathyusha-Precision-Tower-5810.caveonetworks.com (111.93.218.67) by BLUPR0701MB2098.namprd07.prod.outlook.com (10.163.122.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Tue, 5 Sep 2017 14:11:27 +0000 From: Guduri Prathyusha To: harry.van.haaren@intel.com Cc: dev@dpdk.org, Guduri Prathyusha Date: Tue, 5 Sep 2017 19:40:57 +0530 Message-Id: <20170905141057.8998-2-gprathyusha@caviumnetworks.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170905141057.8998-1-gprathyusha@caviumnetworks.com> References: <20170905141057.8998-1-gprathyusha@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (10.174.56.147) To BLUPR0701MB2098.namprd07.prod.outlook.com (10.163.122.156) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b52d74bc-2759-48ce-adc1-08d4f4680075 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BLUPR0701MB2098; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2098; 3:x6kgphqpK46uL8zoWJUg/nmEJrJhHN6V2c1JI0hPnttaTTnCeueOcdz8BuVeb5sjrq7Tj+I6y1ngF9kn3YZJQrcG3Bhw75mcgsTMTKaUUZMpeSzHx0owB0bVMNMHbP1q4fUQ4XzJVtxtp45cysPP5J/Ou0eNemtcPPVMRHEBnXiLQUQnqKP8MzKSigvHArKpBquojLcPpctydDi/uRKnsA4VzCslc6INJ7umZxJdprgQiLAQg/CTfmA0yNKRyyQC; 25:AKt8hhMtzHsxvnqHjb9TYx0krZaIgbrQibIw9q4YAzhFLbywlt9kYG5uXddClW4FPyM3mjCHxc9qepKb3wj9e4UrN8hGOD6/vS08gn3fwbrw6HNwruTKMxojPhlkbC+puvs7XZIIawO/HTlbidJ16FcYFSyfRQBErlP6qK0I5Ld4qZcI3LOQqIqTqksl3jOXpnzgSxkrMq+xqJdiD/cNVMIwbhz5XlFmcA4OFRHqnnAtLCKk6K2e+0CSkHDCVCSsTy9gNYiOrcKatbynxrSeqGCEloM27mKN3Ji8AYZNxNHWlmWhcSPncHg3G5eJhaC70xR69QaWy3peqlFWnkPNMw==; 31:LnXooncu/cDgsdZ8cSX1SABd3k5kUXQ/Nt4KTChLdXwcdtwypgMLVEMQlpyVmRe6hMi0/EjpQf9AZx4yWFGpSGtjQqVGF5E4K9Hyqt9SUY9EBW65yo+Oe12DuR6pJwTTnoMfrXwjQvErGt5vDoQh9BVCjXfFVL4DC1rFxwgz5ZyZqxdcPN27s3lNx2AoX+1FJOzDxHaP9sgBOFLMdlmgOGWxq88KLJ+WHnTX4Lj45uA= X-MS-TrafficTypeDiagnostic: BLUPR0701MB2098: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2098; 20:mkqbwQIzU1svpyi2ko98TD5T7VJxqSYOxz/Mu1So74dOvTa1QNELT0UrS0kO0bKHaH5GoL5mmE/gOP4rOkpy+Y8rGvj84bWA3aTkVfa8YgqqZEjnxKmC6Oa+djXZ9alb6A47ocQ8X/lmYoGeCcZ8BBHribEFo8AM5UhPR+73T+ox/mDvrUFmcZYNTn/TXOWIp+ZaMkP7j+5sRi5FfjNzwz1qnhQwnp4VcsTn8JQa9111japgciYsFmwvP6Xp3DhiGPgZxq/t1dgSwLDypARTYyDqNrhz5/xH7MRbPtXltEy4CH48MU4/tlV/DXyDPMKwvGr1EUpltcJ0At6J+hh9HA4xglC1fUtQptxLdebzBh1fkOAHLjGBjtsQCrcBGyNFPuo9A+9VUeuEXpbC18QuxcMOlcy7QOmJ23fefvyCoH1K2PzayLlVz47TLvzM6k7RSMP5Ab3Wejp0v/kMQ87riVV6C+Cu1SEHQ3zZd7unWoOn3fIlajQlIEcPm7tF4SiuxsfIfDZ0nYBpole1T6fKENdtMyfJWonDXg4gd7UzhjZbubvEuTekVWQvyS3otLBUBExpYKu5UhhbJNlvTcSN/FUGGUKIze+W/DA1nrCqN0U=; 4:DQjwS3bIxhfh1Z8bVJaIpEhg7mdQwwXzPB2KHwR9iTff9o9Brch2oXVZHuwTat7N7jL3aRw05YTg7XBLqHbkanoEnHiF+TvnxxLMoGVR7vtqoW6dvyBxLF6ndrG5y8PwpWeH8jprH/uwZdcYGsdStoeZUeqEa4pkWPsSvp0B4be4PoJ5xulel634RX6MSwsY5LJjLbnxSQkXi9spwGYGP5TVOg1DG3Q+LUMuCgW3Qgq6fiB0y/jpYGgs04LViWDz X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(6041248)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR0701MB2098; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR0701MB2098; X-Forefront-PRVS: 0421BF7135 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(33646002)(6506006)(6486002)(76176999)(107886003)(110136004)(189998001)(66066001)(2906002)(101416001)(47776003)(72206003)(68736007)(2351001)(7736002)(50466002)(48376002)(305945005)(105586002)(42186005)(106356001)(50986999)(53936002)(53416004)(2361001)(50226002)(25786009)(6512007)(36756003)(8936002)(8676002)(81166006)(2950100002)(6666003)(97736004)(81156014)(42882006)(6916009)(69596002)(478600001)(5660300001)(5003940100001)(5009440100003)(1076002)(4326008)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2098; H:prathyusha-Precision-Tower-5810.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB2098; 23:ru1XSGSq5JGLUezHXjYfVFB5KQGbPQTvyHB9Nd6?= 8UKZPekybZ6PIa4VFf/EpopiW0d3QUeSGL4NvxcyylVkp3aLbWJ9r+a6uSvC9TUCUcznYJccg5VEYREW3nhYmSLhoux9PbHqtxBhjJ3SN/wBru+Sbc1Fs+7JvZOv58AM3CtdrkEpKymBM2+NQn4Lo2eQL9hCRJ7guDRybiIcBRgMIsZBDLR3nyrpGWtNjAO6zktOKCknWoZetyxGYtdUTLXcS4snkWPsmEuaGetisB9DBxe61on4zhZ0jPTREjTE21YTOjQkBHXs7MjB0E2aSp4JnAx3SSyNN+DgOaeno5+smml+aEBCUjsexkafR1xCNygZf3v4DP25Vp2V/HadABG6Ron22Cq+rsc9Lu5lyEnH1J/cbhvV9LeTqG489IzT16g3HyEQXI5i7aCAX7WDHElEhR+Xi2qhOC0BqmPuTAqq13WI06+4O8hV3vI/c4/xlE0PG7StGz2ON90k0qT30hKJu1yHTxMfcB615loC3VZ+sso4FW/Jo5ph+vOjoZQqHdG0qTA9JG9ILtwZpPlI98dnBDV/g1fpz18vQCOsyd4Cvp4/8SvGkQ+QCKQV80KRLx9ChdBen3F3mJsMwwbfBGgKLvS5LN5gDxMGK5gYAd9KHfnNilELM3/zFpdVMJGkeQKvOkhYO3LqSXAqI7gjDe+RHOQofI3C8hF591lSqunmGDO+PEC96ktW03iusRsNyzff7s6bW0HnGSTXM387dUiPiYw8UDplXJBywhpNb5xCq0MZrbzXdaNhCVPIKa2NOXZZoXDrGJzMaoOPrjdCD8ImQh3MrkCh2CGYRNWwNPz4CLLeciTDs+jJt/zEQYVpyUfTlvYI0/e3Bpd/zeNimp6tkbeQcj1000IHsI6SNVBpoatykLEDBEOxnZpXXX/Fcq337oFJiN9gMqemvCsLDSNYmF/J9vym5ia4WZr0oGU/hPyCr7h8vZpZuBd56FjjCKza9K4oDljnRnnwbEsRAUIKy0fMTcwq94idFBoSIBZNteufOh0/C5CjFQHu+QAjhwi2SYybTLBN3C7oVvJcEihmH0STT0XxeW6wbhjK3bFIQJfHVyT4kL8RuNH92IZcn2StaJlMJdQ0Dh+xfuF2yGlvf9O6TJj1Dd2hC18sNQ+wJ5uNAn65YuM3ejJkyCZp5tDY= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2098; 6:O2Z/gaN9S+DA0EP5Ft6JmtfYovQGgXx85s4gVZNh+WEfVbp31kseCicaEd4WNFy7C9m4L/r/B5wfCOkTTo49vhC8c+5dSAEzkzZ3vPJaY1HrD57YNq5DGsR57c1b+A+P13InrjvI08YxbmY/oFMxeCYJWu6TZOif9l6jRzauOQYa5tQ7SvPGEzCK7328hk5M+TIz4sx+viJbmjkpaHEAxtuzzUbeiwIOgK7P2cpho4lYq5wmp60lJkK44kAzun+QrF+0quRVR1eRlNP9fyENrlR/loCq7e5lLYaPEyKNRtVddNGIZpkiGd5a1O8sZdV9AsbJNcH7EN1y+ahoVN03sg==; 5:b1QbFb3Z91bksOUlNZ5XtBOvaT48qkQCIFMQ0n2ZrXy835dxkl6GQ+n2zJjkhLCPGusLCYhmsJj6q7vcciLljxEAPJco+Nn7t/Up5S3+f4mayhyT15DS4fIIeOphBEfXiEZ0SfsLRQhzzmybb++Pgg==; 24:kSqWo1HDSCD+DpnngfDf464JIHfbzuEQkNLCsGaspO16dAya8bTRdbmQDRKXhIyNmBUAQqjD2sYf7uVcYcAhrxBc3++ipMLCGHRlA9phjk4=; 7:FpjQE8VbX6R3JjkeEaaCiE9HbYknviQ+Vknch3meXaNu4VCMvWIQyEUWhak+Z8AkWSUjEfVGj4o3HxfoWT0uH7RqVoQvfZiRyi8ml+gOkotTPiLeSVJ4lAq3QF7fKIiFiG4al0aZmDB2vCDnmef7qc278FlA4hUPv3RNqHrVoc0uNkRp9aH3bbkK9X5p3QvoeEWQ3PoYNmA0DCBQZHchPTX7ZsFhysIsQxJEhb3vpGk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2017 14:11:27.6163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2098 Subject: [dpdk-dev] [PATCH 2/2] service: fix service lcore start stop unit test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Unit test case service_lcore_start_stop fails since the service core was stopped without stopping the service. This commit fixes the test by adding negative and positive cases of stopping the service lcore before and after stopping the service respectively. Fixes: f038a81e1c56 ("service: add unit tests") Signed-off-by: Guduri Prathyusha --- test/test/test_service_cores.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.14.1 diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.c index 88fac8f44..b043397ef 100644 --- a/test/test/test_service_cores.c +++ b/test/test/test_service_cores.c @@ -553,6 +553,10 @@ service_lcore_start_stop(void) "Service core expected to poll service but it didn't"); /* core stop */ + TEST_ASSERT_EQUAL(-EBUSY, rte_service_lcore_stop(slcore_id), + "Service core running a service should return -EBUSY"); + TEST_ASSERT_EQUAL(0, rte_service_stop(s), + "Stopping valid service failed"); TEST_ASSERT_EQUAL(-EINVAL, rte_service_lcore_stop(100000), "Invalid Service core stop should return -EINVAL"); TEST_ASSERT_EQUAL(0, rte_service_lcore_stop(slcore_id),