From patchwork Wed Aug 23 15:44:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 27820 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 301AE7D6F; Wed, 23 Aug 2017 17:44:55 +0200 (CEST) Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id 272887D52 for ; Wed, 23 Aug 2017 17:44:51 +0200 (CEST) Received: by mail-pf0-f170.google.com with SMTP id g13so1596234pfm.2 for ; Wed, 23 Aug 2017 08:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oJvj2us+H2YBHj04cfLN82/hH5Z9AJGMOSjIdUB1IxY=; b=vPEOzYlbKFcS1aFLHz6haPepoA5FHj9GyWwiAHiynxlBDh/QIrVHJyo5RnlyUj1OEF qc6iBCYFg+DopVAiM30zoc1jCJQJI8qbmoMMWdPWb1ceVsGGCGUGYIrUd1sSAsiyNgaP X0C/VauHOUe1pmutLbEcGCRZZVJL1Q15RnX4mZXd9Y68JLfyCu1RxuJyo/NuHOo0gW7u 3xB69SwRFmQqI0Vbl+zuVHG4L0AoZsr+/DvY/E/zwv4pTCUdwKy60vmdZReWOu6Sw9ux tvM2cgOfCD74Gu0GlBd3kppd//G497A/AecdrBk+FZQm29sNL6zrjzQq8uwM4VxcDLGg 5Vvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oJvj2us+H2YBHj04cfLN82/hH5Z9AJGMOSjIdUB1IxY=; b=hyRqyaXC8CNGtCGDFX+EH0Z4/ururNoLMnZ35gZFHZQKPmfX6r70QmYd3Oa4s7FECj ihgegb0kQnrCUst57EOVwaLwt30IDaJK/ejsMtnyjXbh03r3rydG/Y9uFyQReXoRCBmQ DKFolWXbmXw8mgwqTiNRHUG9AEaKtx5GWZVgfQYF2HHGwt5V/kKCQXmP8RpmXtW5Vr/f 5fo1rLH5KvDibHP209U6LFyPpGmpYLYu4/nBP6G96UTY/2dxz7A3GmM2aO4u0guGUv+d AQqYTdvlau6HKKMbRHUzO4G7ezMWrMX+tCvXs3cpZ5Ly8eEdkyNO89p8EHBOumkQ9YAl RAAQ== X-Gm-Message-State: AHYfb5glbrE45We+Q6z/8dc/aetcoPtXTFjNfk1xRGXr3zGfx9DyHTe+ 5JJqJayYoWsxKN8C9cc+Mg== X-Received: by 10.99.111.206 with SMTP id k197mr3198519pgc.205.1503503090960; Wed, 23 Aug 2017 08:44:50 -0700 (PDT) Received: from xeon-e3.lan (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id 62sm3666232pfw.34.2017.08.23.08.44.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Aug 2017 08:44:50 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 23 Aug 2017 08:44:41 -0700 Message-Id: <20170823154445.19494-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170823154445.19494-1-stephen@networkplumber.org> References: <20170823154445.19494-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 2/6] bnx2x: remove unnecssary void cast of rte_memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Stephen Hemminger Reviewed-by: Kirill Rybalchenko --- drivers/net/bnx2x/bnx2x.c | 6 +++--- drivers/net/bnx2x/bnx2x.h | 4 ++-- drivers/net/bnx2x/ecore_sp.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 06733d153280..44222af2f1d5 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -6604,7 +6604,7 @@ bnx2x_config_rss_pf(struct bnx2x_softc *sc, struct ecore_rss_config_obj *rss_obj /* Hash bits */ params.rss_result_mask = MULTI_MASK; - (void)rte_memcpy(params.ind_table, rss_obj->ind_table, + rte_memcpy(params.ind_table, rss_obj->ind_table, sizeof(params.ind_table)); if (config_hash) { @@ -6671,7 +6671,7 @@ bnx2x_set_mac_one(struct bnx2x_softc *sc, uint8_t * mac, /* fill a user request section if needed */ if (!bnx2x_test_bit(RAMROD_CONT, ramrod_flags)) { - (void)rte_memcpy(ramrod_param.user_req.u.mac.mac, mac, + rte_memcpy(ramrod_param.user_req.u.mac.mac, mac, ETH_ALEN); bnx2x_set_bit(mac_type, &ramrod_param.user_req.vlan_mac_flags); @@ -6879,7 +6879,7 @@ static void bnx2x_link_report(struct bnx2x_softc *sc) sc->link_cnt++; /* report new link params and remember the state for the next time */ - (void)rte_memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data)); + rte_memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data)); if (bnx2x_test_bit(BNX2X_LINK_REPORT_LINK_DOWN, &cur_data.link_report_flags)) { diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 91c5aec212a5..14e892c0ea7e 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers/net/bnx2x/bnx2x.h @@ -1525,12 +1525,12 @@ bnx2x_reg_read32(struct bnx2x_softc *sc, size_t offset) #define REG_RD_DMAE(sc, offset, valp, len32) \ do { \ (void)bnx2x_read_dmae(sc, offset, len32); \ - (void)rte_memcpy(valp, BNX2X_SP(sc, wb_data[0]), (len32) * 4); \ + rte_memcpy(valp, BNX2X_SP(sc, wb_data[0]), (len32) * 4); \ } while (0) #define REG_WR_DMAE(sc, offset, valp, len32) \ do { \ - (void)rte_memcpy(BNX2X_SP(sc, wb_data[0]), valp, (len32) * 4); \ + rte_memcpy(BNX2X_SP(sc, wb_data[0]), valp, (len32) * 4); \ (void)bnx2x_write_dmae(sc, BNX2X_SP_MAPPING(sc, wb_data), offset, len32); \ } while (0) diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h index e7ec96e941ce..85ab4c28f11c 100644 --- a/drivers/net/bnx2x/ecore_sp.h +++ b/drivers/net/bnx2x/ecore_sp.h @@ -113,7 +113,7 @@ typedef rte_spinlock_t ECORE_MUTEX_SPIN; #define ECORE_FCOE_CID(sc) ((sc)->fp[FCOE_IDX(sc)].cl_id) #define ECORE_MEMCMP(_a, _b, _s) memcmp(_a, _b, _s) -#define ECORE_MEMCPY(_a, _b, _s) (void)rte_memcpy(_a, _b, _s) +#define ECORE_MEMCPY(_a, _b, _s) rte_memcpy(_a, _b, _s) #define ECORE_MEMSET(_a, _c, _s) memset(_a, _c, _s) #define ECORE_CPU_TO_LE16(x) htole16(x)