From patchwork Thu Aug 10 09:12:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Mrzyglod X-Patchwork-Id: 27504 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 92701152A; Thu, 10 Aug 2017 11:49:49 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 764E814E8 for ; Thu, 10 Aug 2017 11:49:45 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2017 02:23:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.41,352,1498546800"; d="scan'208"; a="1161210530" Received: from gklab-246-025.igk.intel.com (HELO Sent) ([10.217.246.25]) by orsmga001.jf.intel.com with SMTP; 10 Aug 2017 02:16:46 -0700 Received: by Sent (sSMTP sendmail emulation); Thu, 10 Aug 2017 11:12:16 +0200 From: Daniel Mrzyglod To: beilei.xing@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, Daniel Mrzyglod Date: Thu, 10 Aug 2017 11:12:14 +0200 Message-Id: <20170810091214.72408-1-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.13.4 Subject: [dpdk-dev] [PATCH] net/i40e: fix return code not checked X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Calling i40e_vsi_delete_mac without checking return value (as is done elsewhere 5 out of 6 times) Coverity issue: 140735 Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF") Signed-off-by: Daniel Mrzyglod Reviewed-by: Ferruh Yigit --- drivers/net/i40e/rte_pmd_i40e.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index f12b7f4a1..950a0d6a2 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -591,7 +591,9 @@ rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id, /* Remove all existing mac */ TAILQ_FOREACH_SAFE(f, &vsi->mac_list, next, temp) - i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr); + if (i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr) + != I40E_SUCCESS) + PMD_DRV_LOG(WARNING, "Delete MAC failed"); return 0; }