From patchwork Thu Jul 6 15:47:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 26553 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0DE691094; Thu, 6 Jul 2017 17:47:58 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B7157271 for ; Thu, 6 Jul 2017 17:47:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 260A9208E8; Thu, 6 Jul 2017 11:47:55 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 06 Jul 2017 11:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=YAKD9cQPf4cNASmkD7AyRxGm+qY hNkhP0aLcFmKJfAQ=; b=YbYAmnUcK48zMqTvrvMnFfjJXhNeH3XNZUNXFe28+8i 11XfMazbObksoPT4RPEM6TNjT6VliPI60zTo26RS135HxfWyVBsRYg1SaWFvSVpk nZYWzqVQGSlHGXlgtHfetjbu/BRNtGSW49NitH99dCqHiaNEUEz++OjDvzIT5Jx0 = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=YAKD9c QPf4cNASmkD7AyRxGm+qYhNkhP0aLcFmKJfAQ=; b=nBA//zahXxb4H+gjGHe5hc mjksamBpge0E+j/quvE9M057KgnjMWGTD0Fd/HJtxGRqIkAOaJKKwH0NHwbiEubI iiLR8s+mpZ8f2+Kf+gle0IY6U935wKqRpt5ktGFltraAWNlAfP2DtVjIzQ3mJWx+ cp7NIkygT8yZz/kferDj1psZXVazDu5hGqRd9q+npqMzGhgseGLT3ORlgFkyZkgw LOhGNQU3STRVyqoSH5+dtDwjUiIHusWZInqw8Kj0KMv0Vsbg4jpjADw7SPPe/j8M V4pZXhOWqhcAoYW4jDHrWIOgX3WAK5NZZNn05atoo1WDci5YGx+Sbm/PZtxB3RQA == X-ME-Sender: X-Sasl-enc: tYFV+OelTH6DpeKLt+J9uUdbvIQ66nZZvk8WSMbCfjCl 1499356075 Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E46424426; Thu, 6 Jul 2017 11:47:55 -0400 (EDT) From: Thomas Monjalon To: bruce.richardson@intel.com Cc: dev@dpdk.org Date: Thu, 6 Jul 2017 17:47:50 +0200 Message-Id: <20170706154750.27393-1-thomas@monjalon.net> X-Mailer: git-send-email 2.13.1 Subject: [dpdk-dev] [PATCH] net/ring: add missing newlines in logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some logs are missing the newline character \n. The logs using only line can be checked with this command: git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking") Signed-off-by: Thomas Monjalon --- drivers/net/ring/rte_eth_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 820a41104..6ac96a6a2 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -494,7 +494,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void * node = strchr(name, ':'); if (!node) { - RTE_LOG(WARNING, PMD, "could not parse node value from %s", name); + RTE_LOG(WARNING, PMD, "could not parse node value from %s\n", name); goto out; } @@ -503,7 +503,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void * action = strchr(node, ':'); if (!action) { - RTE_LOG(WARNING, PMD, "could not action value from %s", node); + RTE_LOG(WARNING, PMD, "could not parse action value from %s\n", node); goto out; }