[dpdk-dev] net/ring: add missing newlines in logs
Checks
Commit Message
Some logs are missing the newline character \n.
The logs using only line can be checked with this command:
git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/ring/rte_eth_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 7/6/2017 4:47 PM, Thomas Monjalon wrote:
> Some logs are missing the newline character \n.
>
> The logs using only line can be checked with this command:
> git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
>
> Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Applied to dpdk-next-net/master, thanks.
@@ -494,7 +494,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *
node = strchr(name, ':');
if (!node) {
- RTE_LOG(WARNING, PMD, "could not parse node value from %s", name);
+ RTE_LOG(WARNING, PMD, "could not parse node value from %s\n", name);
goto out;
}
@@ -503,7 +503,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *
action = strchr(node, ':');
if (!action) {
- RTE_LOG(WARNING, PMD, "could not action value from %s", node);
+ RTE_LOG(WARNING, PMD, "could not parse action value from %s\n", node);
goto out;
}