From patchwork Thu Jul 6 15:28:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 26552 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 7E654568A; Thu, 6 Jul 2017 17:29:00 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 53A9D1C0B for ; Thu, 6 Jul 2017 17:28:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EFBE220B50; Thu, 6 Jul 2017 11:28:58 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 06 Jul 2017 11:28:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=vkenlgz/rVRKn+A/M7dZaEgd1P7 TBxf0sc4n654sIbg=; b=HKxbO3BgNrFCYGZi6houUpPxKd1Ir+Qg2uyYwcUDmt/ C6CsWuJ77pIjKM1fLrPXZb4zvd37dQ5Ytie8nEYvur48hwi+14LrWEWaT92MkD+g 8+3Yccxuz6B2TkcYVnLSbByLA0+mOcxYGACu9hsdlyUu1asJJe+/WuE2DQX99Keg = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=vkenlg z/rVRKn+A/M7dZaEgd1P7TBxf0sc4n654sIbg=; b=NZY9CkjNXT1HQt5zJJ5kTT V/OaYS+7S2DZkvOHT0hvw49DzqpBS7JvJiDom6p5iKMeUbf+YOuEYqnFlb61HpU1 mGOgest/DPLNZRZz8TMC8d6aUyIHXlIrF9UzWKXxiTGRLj+VsuPeCXMbqHL0Z6R5 asdlUSvVDMY/Ms19YFn9YwtUq7XIZXKFxPct8g9+NhHlQLbxBJ8VrSk/ObWSV6Q6 nvomeaL8MSnI8xt7EM3P+Jj8LHsUjb89holZllzTr2FwADPokxsReRQt/nkBiVDl sMzMoeJ5O01wvikJYYvxyt4ERMo3DAPqkseF9zkMNuCUj0aM/SzFbdlVjruX1QxA == X-ME-Sender: X-Sasl-enc: 2m0DF+VEQzq1tV3HsRe+02OUVtH/bvc/Pza4ygNiE69X 1499354938 Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5B5977E6F1; Thu, 6 Jul 2017 11:28:58 -0400 (EDT) From: Thomas Monjalon To: pascal.mazon@6wind.com Cc: dev@dpdk.org Date: Thu, 6 Jul 2017 17:28:48 +0200 Message-Id: <20170706152848.26632-1-thomas@monjalon.net> X-Mailer: git-send-email 2.13.1 Subject: [dpdk-dev] [PATCH] net/tap: add missing newlines in logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some logs are missing the newline character \n. The logs using only line can be checked with this command: git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Fixes: 268483dc2086 ("net/tap: add preliminary support for flow API") Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture") Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") Signed-off-by: Thomas Monjalon Acked-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 22 +++++++++++----------- drivers/net/tap/tap_flow.c | 6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index f82f08802..110670e15 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -145,7 +145,7 @@ tun_alloc(struct pmd_internals *pmd) fd = open(TUN_TAP_DEV_PATH, O_RDWR); if (fd < 0) { - RTE_LOG(ERR, PMD, "Unable to create TAP interface"); + RTE_LOG(ERR, PMD, "Unable to create TAP interface\n"); goto error; } @@ -1269,7 +1269,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, if (!pmd->flower_support) { if (remote_iface[0]) { RTE_LOG(ERR, PMD, - "%s: kernel does not support TC rules, required for remote feature.", + "%s: kernel does not support TC rules, required for remote feature.\n", pmd->name); goto error_exit; } else { @@ -1290,22 +1290,22 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, */ pmd->nlsk_fd = nl_init(0); if (pmd->nlsk_fd == -1) { - RTE_LOG(WARNING, PMD, "%s: failed to create netlink socket.", + RTE_LOG(WARNING, PMD, "%s: failed to create netlink socket.\n", pmd->name); goto disable_rte_flow; } pmd->if_index = if_nametoindex(pmd->name); if (!pmd->if_index) { - RTE_LOG(ERR, PMD, "%s: failed to get if_index.", pmd->name); + RTE_LOG(ERR, PMD, "%s: failed to get if_index.\n", pmd->name); goto disable_rte_flow; } if (qdisc_create_multiq(pmd->nlsk_fd, pmd->if_index) < 0) { - RTE_LOG(ERR, PMD, "%s: failed to create multiq qdisc.", + RTE_LOG(ERR, PMD, "%s: failed to create multiq qdisc.\n", pmd->name); goto disable_rte_flow; } if (qdisc_create_ingress(pmd->nlsk_fd, pmd->if_index) < 0) { - RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.", + RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.\n", pmd->name); goto disable_rte_flow; } @@ -1314,14 +1314,14 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, if (strlen(remote_iface)) { pmd->remote_if_index = if_nametoindex(remote_iface); if (!pmd->remote_if_index) { - RTE_LOG(ERR, PMD, "%s: failed to get %s if_index.", + RTE_LOG(ERR, PMD, "%s: failed to get %s if_index.\n", pmd->name, remote_iface); goto error_remote; } snprintf(pmd->remote_iface, RTE_ETH_NAME_MAX_LEN, "%s", remote_iface); if (tap_ioctl(pmd, SIOCGIFHWADDR, &ifr, 0, REMOTE_ONLY) < 0) { - RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.", + RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.\n", pmd->name, pmd->remote_iface); goto error_remote; } @@ -1329,7 +1329,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, ETHER_ADDR_LEN); /* The desired MAC is already in ifreq after SIOCGIFHWADDR. */ if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) { - RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.", + RTE_LOG(ERR, PMD, "%s: failed to get %s MAC address.\n", pmd->name, remote_iface); goto error_remote; } @@ -1342,7 +1342,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, qdisc_flush(pmd->nlsk_fd, pmd->remote_if_index); if (qdisc_create_ingress(pmd->nlsk_fd, pmd->remote_if_index) < 0) { - RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.", + RTE_LOG(ERR, PMD, "%s: failed to create ingress qdisc.\n", pmd->remote_iface); goto error_remote; } @@ -1352,7 +1352,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, tap_flow_implicit_create(pmd, TAP_REMOTE_BROADCAST) < 0 || tap_flow_implicit_create(pmd, TAP_REMOTE_BROADCASTV6) < 0) { RTE_LOG(ERR, PMD, - "%s: failed to create implicit rules.", + "%s: failed to create implicit rules.\n", pmd->name); goto error_remote; } diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a0dd5048a..e6a24d4ea 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1371,7 +1371,7 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, remote_flow = rte_malloc(__func__, sizeof(struct rte_flow), 0); if (!remote_flow) { - RTE_LOG(ERR, PMD, "Cannot allocate memory for rte_flow"); + RTE_LOG(ERR, PMD, "Cannot allocate memory for rte_flow\n"); goto fail; } msg = &remote_flow->msg; @@ -1396,7 +1396,7 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, } err = nl_send(pmd->nlsk_fd, &msg->nh); if (err < 0) { - RTE_LOG(ERR, PMD, "Failure sending nl request"); + RTE_LOG(ERR, PMD, "Failure sending nl request\n"); goto fail; } err = nl_recv_ack(pmd->nlsk_fd); @@ -1492,7 +1492,7 @@ tap_dev_filter_ctrl(struct rte_eth_dev *dev, *(const void **)arg = &tap_flow_ops; return 0; default: - RTE_LOG(ERR, PMD, "%p: filter type (%d) not supported", + RTE_LOG(ERR, PMD, "%p: filter type (%d) not supported\n", (void *)dev, filter_type); } return -EINVAL;