From patchwork Wed Jul 5 05:26:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "De Lara Guarch, Pablo" X-Patchwork-Id: 26500 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B85497CC0; Wed, 5 Jul 2017 15:27:28 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B9F7B7CB0 for ; Wed, 5 Jul 2017 15:27:21 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2017 06:27:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,312,1496127600"; d="scan'208";a="988933509" Received: from silpixa00399464.ir.intel.com (HELO silpixa00399464.ger.corp.intel.com) ([10.237.222.157]) by orsmga003.jf.intel.com with ESMTP; 05 Jul 2017 06:27:18 -0700 From: Pablo de Lara To: declan.doherty@intel.com, zbigniew.bodek@caviumnetworks.com, jerin.jacob@caviumnetworks.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com, fiona.trahe@intel.com, john.griffin@intel.com, deepak.k.jain@intel.com Cc: dev@dpdk.org, Slawomir Mrozowicz , Pablo de Lara Date: Wed, 5 Jul 2017 06:26:16 +0100 Message-Id: <20170705052620.34223-9-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170705052620.34223-1-pablo.de.lara.guarch@intel.com> References: <20170702155719.66530-1-pablo.de.lara.guarch@intel.com> <20170705052620.34223-1-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH v4 08/12] cryptodev: remove mempool from session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Slawomir Mrozowicz Mempool pointer can be obtained from the object itself, which means that it is not required to actually store the pointer in the session. Signed-off-by: Slawomir Mrozowicz Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/release_17_08.rst | 1 + lib/librte_cryptodev/rte_cryptodev.c | 7 +++---- lib/librte_cryptodev/rte_cryptodev.h | 6 ------ 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index c3d3b34..74275e0 100644 --- a/doc/guides/rel_notes/release_17_08.rst +++ b/doc/guides/rel_notes/release_17_08.rst @@ -210,6 +210,7 @@ API Changes the new parameter ``device id``. * ``dev_id`` field has been removed from ``rte_cryptodev_sym_session`` structure. * ``driver_id`` field has been removed from ``rte_cryptodev_sym_session`` structure. + * Mempool pointer ``mp`` has been removed from ``rte_cryptodev_sym_session`` structure. ABI Changes diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index c2123cd..dfced85 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -1087,8 +1087,6 @@ rte_cryptodev_sym_session_init(struct rte_mempool *mp, { memset(sess, 0, mp->elt_size); - sess->mp = mp; - if (dev->dev_ops->session_initialize) (*dev->dev_ops->session_initialize)(mp, sess); } @@ -1126,7 +1124,7 @@ rte_cryptodev_sym_session_create(uint8_t dev_id, dev_id); /* Return session to mempool */ - rte_mempool_put(sess->mp, _sess); + rte_mempool_put(dev->data->session_pool, _sess); return NULL; } @@ -1198,7 +1196,8 @@ rte_cryptodev_sym_session_free(uint8_t dev_id, dev->dev_ops->session_clear(dev, (void *)sess->_private); /* Return session to mempool */ - rte_mempool_put(sess->mp, (void *)sess); + struct rte_mempool *mp = rte_mempool_from_obj(sess); + rte_mempool_put(mp, (void *)sess); return NULL; } diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 0fb5608..508c672 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -883,12 +883,6 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, /** Cryptodev symmetric crypto session */ struct rte_cryptodev_sym_session { RTE_STD_C11 - struct { - struct rte_mempool *mp; - /**< Mempool session allocated from */ - } __rte_aligned(8); - /**< Public symmetric session details */ - __extension__ char _private[0]; /**< Private session material */ };