From patchwork Tue Jun 13 16:42:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 25297 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 61DE45699; Tue, 13 Jun 2017 18:42:29 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 33317559A; Tue, 13 Jun 2017 18:42:26 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 13 Jun 2017 09:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.39,338,1493708400"; d="scan'208"; a="1140846254" Received: from silpixa00372839.ir.intel.com (HELO silpixa00372839.ger.corp.intel.com) ([10.237.222.154]) by orsmga001.jf.intel.com with ESMTP; 13 Jun 2017 09:42:13 -0700 From: Ferruh Yigit To: Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Tue, 13 Jun 2017 17:42:08 +0100 Message-Id: <20170613164212.42374-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/5] kni: fix build with gcc 7.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" build error: .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c: In function ‘igb_kni_probe’: .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2483:30: error: ‘%d’ directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=] "%d.%d, 0x%08x, %d.%d.%d", ^~ .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2483:8: note: directive argument in the range [0, 65535] "%d.%d, 0x%08x, %d.%d.%d", ^~~~~~~~~~~~~~~~~~~~~~~~~ .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2481:4: note: ‘snprintf’ output between 23 and 43 bytes into a destination of size 32 snprintf(adapter->fw_version, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(adapter->fw_version), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "%d.%d, 0x%08x, %d.%d.%d", ~~~~~~~~~~~~~~~~~~~~~~~~~~ fw.eep_major, fw.eep_minor, fw.etrack_id, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fw.or_major, fw.or_build, fw.or_patch); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixed by increasing buffer size to 43 as suggested in compiler log. Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline") Cc: stable@dpdk.org Reported-by: Nirmoy Das Signed-off-by: Ferruh Yigit Reviewed-by: Markos Chandras --- lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h index d077b49e9..8667f29ca 100644 --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h @@ -607,7 +607,7 @@ struct igb_adapter { int int_mode; u32 rss_queues; u32 vmdq_pools; - char fw_version[32]; + char fw_version[43]; u32 wvbr; struct igb_mac_addr *mac_table; #ifdef CONFIG_IGB_VMDQ_NETDEV