From patchwork Thu May 11 05:52:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 24214 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CF7335599; Thu, 11 May 2017 07:53:13 +0200 (CEST) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0058.outbound.protection.outlook.com [104.47.40.58]) by dpdk.org (Postfix) with ESMTP id DB5F62952 for ; Thu, 11 May 2017 07:53:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QRbqSeU2T2p365QQAYUg6yibmwMPthm1eKHl5mOvYoQ=; b=KUXtoBLkHEUpHxoC2ZrUHaj08ygGLrTeKPY+TqYsAyMKT2LtwTPQnuHp3gPtgpNDknGZFfL1gq2P1nm9aW3DS/CM5H5VY7/BWK5yZn++jMk4WkMy1i+In+hcOiulZ2gctRzkkzV3U5uCHbFe9iWLRsrc3+wfaZwjJD/P15JN7B8= Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (111.93.218.67) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Thu, 11 May 2017 05:53:02 +0000 Date: Thu, 11 May 2017 11:22:41 +0530 From: Jerin Jacob To: Ashwin Sekhar T K Cc: thomas@monjalon.net, maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com, jianbo.liu@linaro.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org Message-ID: <20170511055239.GF3057@jerin> References: <20170510101643.30556-1-ashwin.sekhar@caviumnetworks.com> <20170510101643.30556-7-ashwin.sekhar@caviumnetworks.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170510101643.30556-7-ashwin.sekhar@caviumnetworks.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0084.INDPRD01.PROD.OUTLOOK.COM (10.174.56.24) To BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a86b9bb9-c18c-4594-7bef-08d49831ff92 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 3:0gl/jNRhB3vMteygfP1XkJ93wfx1w1CY8Ss8PWFXp3tcIWiJHic/OWP5F1djkcaNXH7q0kMTuEWJG+YT/CFg411nrnx1HSu2HZXaZN072kPjB99xJM4xmQhhnDOKisnvL28nl6YKFsyyCxYrcM0FoOjwKfDgjuRIbTdqyj45BMwIDJb3eL2jmWkhpgpCTB4mO5OOvCYF5d6kpywXOBSv1tCM7qjl7nxTowfWkczp4rj8idfiYnbHbf1/o0orqenZ2Wm9Qhe7LBmoI9eI0OpA1cAjUhf7GQsDKFROsnHqNcAf6D6XNSKLrivQv58eJ77aMVFDJux7OCxrDw6W7Uknww==; 25:ET0Ejd2l3wSqGA+5Ssx2K3jRzHr/Mxkg042d4B5/N0irT5wUA+kpR9jeRadPXY9kJ5UPjh2eW5Pea4I9/mbNWNgkmkRBzLBjWTUebddyJLQ/u623NekjwXhTydkg5qxeCzxNcznDKFJUoUbgrY0YH9AZb5Ele9pOomLp70KOlWpDMVgy27w6MTKkmheqW+xnB7dGnNwOMGqhNZ8He9jdXPiijyp4uso+rEykx6G130SFsiEIfHI4siT3kzfWzsfHO7Wz3WU1gZIigWSEzWlk/0KN9phdBzlYCdj3/bxuxJ1F4LYzQJCYT1BV0RMTQZqcZwYLHQOU8BSeAo3oZBByJFxgOi8Z6qVTjN8zwzGbiZj7Fiaq2H7YhcPJp75W+sjF7PAO7bP0q5z97Ix6Z1xadajO2ID49Z1Lvr4gC76gujpmvPnTS3rVBvCyoqW5f0EddH2y4KZGWzVHmVvjQ46yOtmoeswoVKmkgwxPLQOillg= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 31:t3lPvX14sQXSiViNIPSyEdW0gR5kgO+7ANlGsqyoV1wLvrq3o5895r/bjTwSQx6tvfWxtZs2CwZyQ+bUWy5k/AdjQfKqmx5naI0LpLJsasM6EOaLaJK0hg8o4qiVqBEewx7m3guFJU4pPggUtgdXVHKfDqPTmUojt+63Bag+7+fXOia9xJL5r0Suhc21PifYfQvjzrLDd75RLxnYps54GZG7kmNxWE7j9ZE3RFa18M8=; 20:4aoDwMrwSte8Lcwau3VOSfQdwEXXlu9MpTCIhJ2c0tGm2sWHtXGnpdciur3I5CL/WYooO8Xd6u83wZf/U1d1Rh0h296+R2UncTRsvvJr3Vs5LppNpWLMMm9kiGeYffMon71NVwepXgPgiZTeAhryo59g7+7UQksGoXmkptaA68Dp5rGucsw3qpeLXiDDiClx4FBj4ZL05qMUBzbTUOrLjFlfZqpTmlX8sE/qJqVIFKfW3zMQ8pPXdHmvCzkZ7pwnEnvLbFQojhbm+REYCduTngZomAcjhaJVAI5WH4PM9Gunzynv3FuD5FRofTu1cVcp5euILH7mL3ygcPGenV0nmJnGXiozeV8PafJgZXW7/Olcd96fjVSZmqL5QkIIo9ypPZrXcE8KTaxF7Xxkr1RgOSd6Ymzkj9HccT3utQ/uj6OGXZ+w2PNJXECyMSQsEPUhKBZ0m7JEtm1uiiwinUOc4+LrslPSIfonqHaPFaABphgXS4xll0vyrfEmsNjveLWoC/QFtSvkxAhjTa37pNe75KS3wJQ5/P5CmlmSRmqMPHzCaknqBkpvHpqXdeybw7o6iN7VdFkSffCODqrpJXMzh1v99bf3vOs8QUWrwtQpNms= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(6072148); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:iDcVn66/fduZKg21mXErHzwmro/AgSQ8RJgTYPZY4Qnas0DkM/EEbC0qUOyT9FGgeqwgWWweI19+kEhTMGqEUITVebhtrA/d1ZzTtBdYdlDuVh7Ej4Y4XRQab5M1NKVqURczFMUZkb1IfSuYS6dYJEwj0G4gAekW1zuMkHZVDQRfL7DmfSd0pXU7DxwHdnAP4S2SF1oaif5QUaHtUHvaUFiyPFW7rf6zOxBkWRlHJgyUO59frCV86BVFIpv64ZT3PYE8/WPwebyl4yNQz5id0yFYFwWvrFCNffiRvVP+ztCo4YDM4xY2Vm6jezPWRHLRXtfd5mXHo/jKwptwMLVl9rpOJcPNrFQV/FhgaxuwRWtAOUlh3y8CB579Xu0GiYBMCn0BujplIjG0rnndu9MIGegdzQR45lmt/XPBU4axMbxbiSJNSuvSXTvdKScOhK0Op9SFM9KZ9ahcM1ydMjj8zrerKGalp6kPNu8k2ZF7hhLNZzRDKwoN7JucW8FlkGYTvRbpZvPkLDO0WEq/ayEI34Dc+NvrV564VXatQFbPj9UDj1wMwT0rSvWQgqYZRc6iAo17TOVDEIbkxGImZ9LjjQ65t6fETUchKcXdUdRgROT9T3Mo9SqNEad1lBPn4fpxx6OTOz9RbnGpCRwAPM3yRXsKslDdQyYRItNI+WJkLDdVZNQk3DP6NDaoo7E+cF8Zr3N4TtmyKUoBzE/UvH9o++JV04QJknduyFu845eZbFNKUDCRO+I/3Fsm4H0vHHPCn0KsvxEt7nXfimjTxgbhLwK/dxMn5gFjEsnW5NV2SzucTiJL3FB3IsjnZsVGJ2em X-Forefront-PRVS: 0304E36CA3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39410400002)(39450400003)(39850400002)(39840400002)(13464003)(8676002)(53936002)(55016002)(6116002)(3846002)(50986999)(81166006)(9686003)(110136004)(42882006)(6246003)(5009440100003)(1076002)(38730400002)(54356999)(50466002)(6862004)(23676002)(4326008)(76176999)(42186005)(2950100002)(4001350100001)(478600001)(33716001)(6496005)(25786009)(7736002)(189998001)(305945005)(83506001)(2906002)(66066001)(2870700001)(33656002)(5660300001)(47776003)(229853002)(72206003)(6636002)(6666003)(18370500001)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:jerin; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBLUPR0701MB1713=3B23=3AS2?= =?utf-8?q?/3wsKbWt+pwYOrOtYSp+ldPOINVk6Is39ZrRwLP8NWc3sfp8dSxRM1me?= =?utf-8?q?fsHlJ1haMKcrjSFxrTCll0JJoFpARK5aOaeUbIFVaK1qNMhsdqBRS15j?= =?utf-8?q?qowyy5SPCvuq1zi2HHBp+fPjIdxsX8DWT77VepTdl0Md/CE8epc26UAp?= =?utf-8?q?itLoPpXTtWpCH3AgFv6a/NUh3sqVzGe+bcZ43jD3N1bprEDU8Oh+NvpE?= =?utf-8?q?Za4qso4LcZx4L49ARz9+RUW75zUlDypQ/7rc6wpPE2E/udcXeAD+JGri?= =?utf-8?q?fIp+L8i9UfKnavH414mhvTGv2KcMStk/b9iJzo2om3ZAvNHqAdHoglwc?= =?utf-8?q?6T+9k8MXBRMSZR7r21pRp/QON9fgRbChgvISNBhHOuBaU7xtNURv0GKh?= =?utf-8?q?96YMsVIc2+it1ZKKPuLDj/RnpWj1A0Hn1UwMV+C8z9BG1TckIEUxd3j9?= =?utf-8?q?1dn0vcyV+ibzgLBo5W75tLX7glXOWybNFq/zl9rhj1FAIOe/i+ThAGaS?= =?utf-8?q?qTUpDLEPPes0GB69F/D69eGcWqYgytZzP6jXlPNmm0nSlggr00V3s99C?= =?utf-8?q?HRulLjOkWbvTAHAm51wnI/zaZuSypd2Sao4o1Vqr5lgOocZTuYKSyTSC?= =?utf-8?q?RwmvUCODM9rqb9pQq64CO6MObgjekfgBXUYPPbeo1ypPaXKsgxzCJdGD?= =?utf-8?q?4ClLE/oNPGBNWtEikES4AmPO7+FL3THNc0PQZyUfpoOwXNsrCVvJCVL5?= =?utf-8?q?BlHaPlYPdN4GKXOOdPA3qcpIAeaI2z+VNZ80Tr5flTDYcs0AeRTccIFU?= =?utf-8?q?L2JIclu71twc4gMknmYi+OvWE8RdfMv8DHNfk14H8n7j1qhPbAa2DVhe?= =?utf-8?q?3nIwkjnW1FPs5JBgB9/FiVrzaO98gm+gOTnSct4I0NZPTLro4MA2Zyqx?= =?utf-8?q?q56nGIYxDfun3UiSPNZCn6xoPJy+FwnIPaFt9vyc4TKKFUi+p9pZxqOY?= =?utf-8?q?Iv+4KQaObg/XrMHEJOOEufO0PpkZX+9/5E2zYySQ9dKElp+ZTlWvuftD?= =?utf-8?q?xO6hf9Xf/HjFZDuAIRE1Y8h+u937DFLNYb7X3HYIlGhWrU7FeztVb7Qu?= =?utf-8?q?AYwbeVwt1mPcj6I2bgxk0B6msJugEuDsOVZfXfR2+JcB3i4Vu2hXJflE?= =?utf-8?q?2Jp21F+G7S/6hM0wB4VEc/okNkjZMKFzMWeYrdQ9425vgANybKa+56Wz?= =?utf-8?q?/ZvKrpV+8Lwn+BDOSiam1fKhTB8rGS2SfIZiIG/YBVLzfip6fUxjGeNM?= =?utf-8?q?s3QC2XdOw5FxSXqJtvL8DcHd3+bO4YUEVaKDipMshrmqX2?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 6:KJ64Tg4F1S1XmeynucM2yqwSSz4ykBiFVx4tEu25/T1zcAk/2jQyN90nZuDVXmbcsDz3faYBHzaMBi2uzZtr8WR37QxhuvzBwMVauDbnyLaZuBR6hcXlSj9RnsK8sPrJp2tchjMLDv1NpkqGpYYxs6CssMpNZQ9K7dLR1Mzak31MFlESlyWlU437nX/uLtcCQ2Gs+gNx6OZrou7XwdJPRWAeHODrqI7CS7LNo0qwh64YOgVzRVon6eu32S7IP3uBwuEg19810aLI3Y6YnWWNRSPutE4K/2Kv2OPwDSVjf/odXDP7xlsqQvToMgY4Hoqntxx4h94ICdqpS7MTTIGiYbVKpRZ0Oxx3ap7nTQRiEnfqXjSOmbvDQ9ffFJtfXKZt3zcXVHs2gTG0bE+Gvmb/EwXkj+DBPqTTCVuEvo+9wje9SKd/uIolMLWJTagUBjT2DrCh65ApAMcMDDB1ftuEK1N98qc/pzIMNZJYRLpsAVEdF5bw/wOXNXaeZSicDbW6dBdaB++SoTaZzFD7vp+Zqg==; 5:s3w5pLKP5LAzIxOFI3+IdbWQEWwnwxtkIRwhUYXzV5QTclMQ/u9OHNx3GBmGOOoS72AKd1h4gg4nEyX46r4XsDdqmZm/8Wo5BYWu9fMpLJr4yCzEfaDtegbUMOScMFR0zQeL5q8xh9yqZkSzvDXEKg==; 24:uRdN6Dlx+DWzuvkU6Nm4n9iVqAqUaDHSmP0IewX/mmhcb8yAoAb7EskInpbnd92YTEj7ciutXygMnOPwSJMuHor3rafEAQX/ouYC2PW4o/M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 7:/EZsvygkOcuvUNusqK19Dzqx4eaqZAH34LCawrBmfJNOnjG9kiaG0FvUT92JzWcAP4dOsxpN1PKIzCfSF2+tLlZlJQpt36bdVLmUbP4TNjbORZLiSzU6R2sht8HCpqEeOk4qZrol9rRlAp4sXbkD4vuvTgLgAmJ40gk2lJo8G+Nk/L/iw5X7/sKHZI+jH8PwPbLYl2VMC9h8U7MjfQGGms6TEvQgChvtMpf1YSxm4+ENuruc577nCfAZ5bbf2KCdVH8Umn8ayeZCiXIuaDnClVJmVoLjVbLKklcgDaJ+Lvf+3DmA8bvUFb2VSxTTVIKFeOxypY+AgtuSWRLq30odig== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2017 05:53:02.4666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Subject: Re: [dpdk-dev] [PATCH 6/6] eal: fix warning seen with armv8a clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Wed, 10 May 2017 03:16:43 -0700 > From: Ashwin Sekhar T K > To: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, > maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com, > jianbo.liu@linaro.org, bruce.richardson@intel.com, > pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com > Cc: dev@dpdk.org, Ashwin Sekhar T K > Subject: [dpdk-dev] [PATCH 6/6] eal: fix warning seen with armv8a clang > X-Mailer: git-send-email 2.13.0.rc1 > > Fixed warning -Wempty-body seen with armv8a clang compilation. > > Signed-off-by: Ashwin Sekhar T K > --- > lib/librte_eal/linuxapp/eal/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile > index 640afd088..dea1c1d59 100644 > --- a/lib/librte_eal/linuxapp/eal/Makefile > +++ b/lib/librte_eal/linuxapp/eal/Makefile > @@ -126,6 +126,10 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > CFLAGS_eal_thread.o += -Wno-return-type > endif > > +ifeq ($(CONFIG_RTE_ARCH_ARM64)$(CONFIG_RTE_TOOLCHAIN_CLANG),yy) > +CFLAGS_eal_common_launch.o += -Wno-empty-body > +endif clang pointed us an improvement here. You can add rte_pause() to reduce the power usage while waiting in rte_eal_wait_lcore(). That will remove the need for -Wno-empty-body for clang too. ➜ [master][dpdk-master] $ git diff > + > INC := rte_interrupts.h rte_kni_common.h rte_dom0_common.h > > SYMLINK-$(CONFIG_RTE_EXEC_ENV_LINUXAPP)-include/exec-env := \ > -- > 2.13.0.rc1 > diff --git a/lib/librte_eal/common/eal_common_launch.c b/lib/librte_eal/common/eal_common_launch.c index 229c3a0..1848466 100644 --- a/lib/librte_eal/common/eal_common_launch.c +++ b/lib/librte_eal/common/eal_common_launch.c @@ -54,7 +54,8 @@ rte_eal_wait_lcore(unsigned slave_id) return 0; while (lcore_config[slave_id].state != WAIT && - lcore_config[slave_id].state != FINISHED); + lcore_config[slave_id].state != FINISHED) + rte_pause();