[dpdk-dev,3/6] net/thunderx: fix compile errors for armv8a clang

Message ID 20170510101643.30556-4-ashwin.sekhar@caviumnetworks.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ashwin Sekhar T K May 10, 2017, 10:16 a.m. UTC
  Replaced usage of %a0 in inline assembly with [%x0]

Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
---
 drivers/net/thunderx/base/nicvf_plat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jerin Jacob May 11, 2017, 5:28 a.m. UTC | #1
-----Original Message-----
> Date: Wed, 10 May 2017 03:16:40 -0700
> From: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
> To: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
>  maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com,
>  jianbo.liu@linaro.org, bruce.richardson@intel.com,
>  pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com
> Cc: dev@dpdk.org, Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH 3/6] net/thunderx: fix compile errors for armv8a
>  clang
> X-Mailer: git-send-email 2.13.0.rc1
> 
> Replaced usage of %a0 in inline assembly with [%x0]
> 
> Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>

Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/net/thunderx/base/nicvf_plat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/thunderx/base/nicvf_plat.h b/drivers/net/thunderx/base/nicvf_plat.h
> index 36da12009..3536d8374 100644
> --- a/drivers/net/thunderx/base/nicvf_plat.h
> +++ b/drivers/net/thunderx/base/nicvf_plat.h
> @@ -80,7 +80,7 @@
>  /* ARM64 specific functions */
>  #if defined(RTE_ARCH_ARM64)
>  #define nicvf_prefetch_store_keep(_ptr) ({\
> -	asm volatile("prfm pstl1keep, %a0\n" : : "p" (_ptr)); })
> +	asm volatile("prfm pstl1keep, [%x0]\n" : : "r" (_ptr)); })
>  
>  
>  #define NICVF_LOAD_PAIR(reg1, reg2, addr) ({		\
> -- 
> 2.13.0.rc1
>
  

Patch

diff --git a/drivers/net/thunderx/base/nicvf_plat.h b/drivers/net/thunderx/base/nicvf_plat.h
index 36da12009..3536d8374 100644
--- a/drivers/net/thunderx/base/nicvf_plat.h
+++ b/drivers/net/thunderx/base/nicvf_plat.h
@@ -80,7 +80,7 @@ 
 /* ARM64 specific functions */
 #if defined(RTE_ARCH_ARM64)
 #define nicvf_prefetch_store_keep(_ptr) ({\
-	asm volatile("prfm pstl1keep, %a0\n" : : "p" (_ptr)); })
+	asm volatile("prfm pstl1keep, [%x0]\n" : : "r" (_ptr)); })
 
 
 #define NICVF_LOAD_PAIR(reg1, reg2, addr) ({		\