From patchwork Thu Feb 2 18:43:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 20134 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CA0542C39; Thu, 2 Feb 2017 19:43:51 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0060.outbound.protection.outlook.com [104.47.1.60]) by dpdk.org (Postfix) with ESMTP id 60F5C2C37; Thu, 2 Feb 2017 19:43:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tviJXgjE9HBEOIzC8CSwnoG521oBZ4ZseHw9fsZ43dI=; b=MRyoJiMQJ1IFCJ2J8M8LP6rVIWdcfOtRiB4fGlxnXW+9EVu2QUn6rZ2j3FIuK4v7fwJM1DZ+IbeYDmGCpSqGADtHQ1+ooqlzNqiv04AUG/MpwqVFdmJK5B5GTA5xHaxIPRGGT9EOc7H8mB5qCSWLvYMceSLA9/+2O7mSTC8PDsA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (12.250.235.110) by VI1PR0501MB2462.eurprd05.prod.outlook.com (10.168.136.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Thu, 2 Feb 2017 18:43:46 +0000 From: Yongseok Koh To: CC: , , , Yongseok Koh , Date: Thu, 2 Feb 2017 10:43:32 -0800 Message-ID: <20170202184332.22187-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [12.250.235.110] X-ClientProxiedBy: MWHPR2201CA0009.namprd22.prod.outlook.com (10.174.164.22) To VI1PR0501MB2462.eurprd05.prod.outlook.com (10.168.136.13) X-MS-Office365-Filtering-Correlation-Id: 2a608107-7a36-4cc1-b9ef-08d44b9b6c60 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:VI1PR0501MB2462; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 3:tvBCvJT4ah/7R4D0YanHAHknY0QN1GEjwba8C0gzITPVJsPwaly0c7wY+H5Km36hQtpnazfNmzG02aMAwJJvadn0F3dJsTz1iqjk8VsITExEH19tdi6Rpf6490mcHhVPbjjsaQKZyBixg6XWWdQ/dJ5ZuKzjg4phTCDiGHbqzubPuohv7tnmeO4I3KYdmjRZcpTlnxRPaHSyAlu5MFlFYK6YbRWM95vvnJ1pdZbnrfIIVsFC3cSekW+Jgc/MMVBlbxm1/WEueD2A8qXoogzI6Z+xvbSaUhxuhCoy4kF/1mA=; 25:aE5DVGm6S2qyilPasTYKE7Rzu1OVjytag8r2m82Byv1MZMt47tP4Qx1zb4hIrZo54eTz59ForHbAjU7vRwT7wJRutJH0KJPCmk/dzAB7eK0hdOwlLdIg6/mG1beGBsS1OG93iSKPKDfskf8CdQo7jEXx2FjgB858oNU9R0zkU220ZLszANyMX068pu9DzrqSRDqvB2+n3qUXsRKpAq3joTaJmqJyBDzfuCpw8uxRG8gfuPM9kZq6xJyJLUnKIaoXcOBTaFUVN8i54oMjs3cySH3m3bXu8AnM9Uh22tBsILRJeJz0wDTSLtPb+MM87XHq6lrsmtZlMShbNQ4aPVnRrEyvaXVRVIDeKA9Brh8wtprl9ZRb3fqTrAAlj1r/xNLVaHSd3w94Q4EwE3GIuNppGjdJhs6zmqs0HCdNpD9cWFD2C6sNw0CExjDWxfFTOjQR X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 31:V27WZvzBIKm1seojjhv/ws9jQOM5zVA42P7DDQMBokunOhjZ9rql3zdMRkiMTnDLWuufxJuiGh9StdYTXeqaV7i8zULp2jpzH27B7CJIcQXfra653ZQkjG1BrhvqJQd+2yXALnPh5EEiEdnYD6V8O49TM1h/OiWiZy1aXR3is+feVgY3gUIv0AlfRCdNWPfL8Ox0yN3+AEsNL/0u5dtcjLf8uk3e/OOEfbNP1QYRchh1dfZB+jG8Xh3JAMFNBkOYRBjVZyO5feW5qNhUqN/kxA==; 20:Mqj4W54eTMMZ6/PLq9sS+UEOCoX44kGhTcvoN/VfuS+enAlQhLIk/kbDroTk5oMEzzvIvQP4nE/lAT4wZA/8RzEK1rvl35IYW3lX46MRrApFMF4L/J/P3aAjRt0SmqkaF2Zw2rr+kOztekMP1sbJr4cxstGCf1KC/hnMDwnX0rjQRBxZrW75XfeNH6uacX5nI++fVj+eAI/91xRYMqVIee3X8oFu8pG6//r0UbwFJfXuhtjzdpurokEpnGEL9B1w8dvjUAstOQzlfgI6qmlZJpurDRSqoFIKfnubJSyFmC33rJbn5BtyVGf6YpSIKeGPbk05EorNamNTrzInL2JncUw1Kp3FQ8mJAIN6/ge4ra0pz/ZTZVj2SUm8VJ8N+EZBO//0qeaCUQIE8aYARzgaTPPRoG/2dG/OhLxfcLK6XCgjTtfMPA2IEfZm7Q6CUieoScLFnX6dhzXqCNSZCJC33s/6U0YhjzOr4TybyTmkBZ3s9tky7ubTxJOdOwU7yT1A X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558025)(20161123564025)(6072148); SRVR:VI1PR0501MB2462; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2462; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 4:rZHmKpL2eZIR5N43V7xbTlkj54cYh5gFJDhYzDItT+iPcDOMSHu/rpvgfk0EnLl3Lgy+YcLLPV4rSjjYTgKUrJNgiIC90RmVMhKz7xEgmwAH97m0NxjQL+O5slNYwX7Raj4sEC5m+72wszM3JKcVo6SDkk/ngZFUvFeY7izQgBfimcIaNpbh39eeNyE1Uc5PQYwTt7U3bK0HzoNsNSeT+Xx53TkvnWcALsYedmNMIQOTQOjX9dDqyUPNQ6EFzzkCrvA2ujqk7rd600HE187dq93zyO9VOCocrSs8+35rXcUL+sVHjPVG4kBdW2SJPTEhFHLm91CvWP4QX3Qu6dOlNRIxzlPEXn4Z+PJhh9SAvM4Q+gyShtttgkO+CZ1qCzHXq+zMksED16R+LlL/YenONTLFBwgtegjEy7JUJ5o8q6eo/a3thtk8TbAXlkRQhqkqUqqtOTJIJmIzsrwlM+PQKe2cMNvBDtRa0t7b4czBdau2O4/aNvKW9s+S9rDy60nlmlCGElEhTKqyw9HFB3YElskVjLrCoxmrwJfKpF0qn1Q/5gUqSvrdbbfBG7qg/lkqb9LZ5JOkKI4xR+orloIaDMuVVKEwFXiZS6KTXFFcMFxOBSXVckq1I9n3cjb6JtpD X-Forefront-PRVS: 02065A9E77 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(39840400002)(39850400002)(39410400002)(189002)(199003)(53936002)(81166006)(47776003)(33026002)(5660300001)(50466002)(81156014)(101416001)(50986999)(69596002)(48376002)(66066001)(8676002)(6666003)(6916009)(110136003)(55016002)(54906002)(25786008)(4326007)(1076002)(106356001)(97736004)(5003940100001)(38730400001)(305945005)(50226002)(6116002)(2906002)(3846002)(86362001)(7736002)(21086003)(36756003)(33646002)(42186005)(92566002)(105586002)(189998001)(2351001)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2462; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2462; 23:YVdb71lLkcSRXj9d0h8QaaP+YPWuV9MlzADpaYZ?= AbMLpDLONKL2ql8z4K0NKkH5JGqAcxrHK2/lsiuNWo16OJGXIWnU4AmEmhRoTRJismwqxPYGWOUsDqTK0amKM1r7MjZul0d2R5WEGPmcMKMBmPNeC/ah2OL9gMKbCB/lfdbZrgarw73BtgY5E65egoNibxrQesq7u1keC37WgHVcaUlTu/kmzSY//PfmKMYoWqeC/sgfDVxVJ3lLBqC0bT61SNvBsH/o9DZ/aicfphvUATph9/RKGbiF3TfTwQsAivecrPmlE6P/D4qfHKBkoyoLC9/vIuugNEuvkBRUjLiiFAb/g8hQjYUp93HaOHgvD+RosjyCKtkby97suKvLJPv28VB6Z28zmd+yxgBq2G0JVd4E7OEsS6D1lxGtJ20YhaPQcR5GwWzwJmLkuqkv/b49zJnHgUDTBySAR56PVmG9A0Fg9hbXeHcnadAnRw3GFknKsNFAZJzE+XWLAs/lAdGXx4+BRDJIhxn0uHy2Tok2hrRyCCW6u9v+w9fEnSdAXQXhfbmwAVimXg0RpWlUmVkaYNEhspXcIyI3/FHyqp+laNNwac+W7xcLYVVglAWcyXwXI2saHzxHy3v9S6VtLKJn23nCMtDf//HFM89IdubVt6Wy9doyx1WvVsJgsY+YuThNmALUm/2YVtp2ukpW0K9TijXQHzKwIBv8uNUOtfTcc/yHpv+UC1yfAUb4KWJQrAxjNVC3n1GOOQMfL9aIKL1xYX9I0dGgbEp0QNlegouISy3pxDqKFeY+3eClxqFSbs+GU9FzDVvhBEC48w/S+67AaqAsEPoZT7OsqOdANIMY0hVlAi6do5bZNofsZl5QScmpZ2PagVLKzEdv6BtiNZt0sltcpiwSH4e29V9/Idzk+iKnLB70AHEy+kG4NDFlGWo81gRsMgpPSdqbdzk0NdlOr/qw+wow963f6kdywaf9UtigjrX9uCyoeeqXQn81x5sYiJhPPwKZwivVeKi0S4fZkyKP4i/ZI+DwN9CC+vTm6TgzDX5J/bBuP9bg50fTKtpGKwaiUwaUgoF1k23V1WaPEmM9+HNsPpQD5QSHYVQGQ8pS7b7Sl8Al49IXvLZ9v1PrCW8F9cLrMiqjEGo8+PqbIFU7/4I+4UOW3d3e6AzrlxXEqLUSPFL3wsaSHf+WRXIy8A6DxXJuMYk5v7zHDjsHFG9NhJ/T8jzwazmd48WP/9g== X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 6:QzaEauvA+repwaCpVWT52Nlv7H3zoddMqkZzqGI9gtAqVxpns4Kyknjz5cSPnEJfOyQHTyTgp6e4IdHr4u623zjqIh+Jj92FM1Wu2n5YDznm07R+TRik1sLvBx28F2jZgSMftCqWY1XsqXK9o3W87spZ+ManqEKdXiepuazaWZys8M1GN3oZ+qwtWajrLuEMRALhR3WLqGv3M+0gqPZVDxiGvd8C31SnNbgEvMiKev74Gn6I3lID6v0z1dWelw8Pg5i9se4QRoKjnPpqu1a+C8NlzJSpy8VlJTKXe4Zr0kt5qwTQGB9PNOAeNJ5CfZxifzdDK4v4Te2J6Ecp2Ru2DwEZEJEmqHxuMXkv932/nT/sAzjWX9kYZV/RYVr/+B/JRfl1LVYigHkTB5Ufo/q1Tehi2vl72g5wkNONyrz29niQYm1EFicgPJZCcUmW22Iq; 5:TY+nMqWxSqBGwQKzxQ/kooCiXLHGzwJ9AnlUNgHYl1WlFKTg92Lzz2Zg3YD5rqUzN+BscrSPM0jD0lBUGcqHhj6RLIBe8BqoPoDldcedAdjJQjK5lMy+5vEjogmOQPzixTqT0Ft52KUAbf7xXkzZdzDKuki8dXEnKwmXz2M6hAE=; 24:AIFwXm3siaFrQhp7QQ7NRHmNeLebIshfAj8a2nKH5r2beImRJpKC5js24+6lRu64NlnSp4uPLLxGkjdqTHGQbuHn6gs5dDr9rIixiaxTQOA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 7:/LaBxVfQLr9WWo1VumFYwb9tS1q2XdnD2adpHfmy15Y5BXRDo88IgHvrwxvbjIXsg65+L2FazTGe4NTEI0q+Zu9VGrQuMSs8pEtN8HP8Fy3ysmMhCTkL30XpFH3W5Y8WBkh695xEA7ur2B0c1hSCCS4GCZGGOPJq/uwb8YSqY8O+w7G8Hq5Jhp2hfSPuNrdJhhbXgOYw7XFDKSOCvpe8G8zizjohISS1AxhgePtfMcZDPnrJy7Ps6ktLeVQd9RCHnKLATZ/S/9Odab6g7IThTR3q5hBcNMlSsLAyP0S5wP22+QCCqz++3+emNMMGKypDEatiCBIsbGuXDBBGU87EIRw4RMZO8kJqchSjl48zDMYiobUxe6nuvJiDVBStD4EU2Yg0Qnze+wxVEAM8Uj4qgMGwvg9h1BGSmfD9v26zWJAGKceob1sR7jr3CVU79jN0AtuANAM6j5NTnj0ldkdLxh8t5AjWxN1JlQQMnEkmhQ2QH9lcaT8cGwoPcARhcCJUs5OALTDI7B65ZxGcrk8xpnD9nW5z4RQhgMveXsuoJdnczmn0fMSsFjR/IRkEH/y7 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2017 18:43:46.1412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2462 Subject: [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The total length field in descriptor of inlined multi-packet send must be updated before closing a seesion. There's possibility of updating it afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets silently dropped by HW and impact performance, escpecially lossless test. Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send") CC: stable@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 94fe74763..1043ebbc0 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1046,6 +1046,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, mpw.data.raw += length; } ++mpw.pkts_n; + mpw.total_len += length; ++j; if (mpw.pkts_n == MLX5_MPW_DSEG_MAX) { mlx5_mpw_inline_close(txq, &mpw); @@ -1055,7 +1056,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, inline_room -= length; } } - mpw.total_len += length; elts_head = elts_head_next; #ifdef MLX5_PMD_SOFT_COUNTERS /* Increment sent bytes counter. */