Message ID | 20161222201700.20020-2-akhil.goyal@nxp.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Pablo de Lara Guarch |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 87B2C10D87; Thu, 22 Dec 2016 15:51:29 +0100 (CET) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0050.outbound.protection.outlook.com [104.47.41.50]) by dpdk.org (Postfix) with ESMTP id D7FC810D67 for <dev@dpdk.org>; Thu, 22 Dec 2016 15:51:27 +0100 (CET) Received: from DM2PR03CA0009.namprd03.prod.outlook.com (10.141.96.19) by CY1PR0301MB0748.namprd03.prod.outlook.com (10.160.159.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Thu, 22 Dec 2016 14:51:26 +0000 Received: from BL2FFO11OLC009.protection.gbl (2a01:111:f400:7c09::131) by DM2PR03CA0009.outlook.office365.com (2a01:111:e400:2428::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Thu, 22 Dec 2016 14:51:26 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11OLC009.mail.protection.outlook.com (10.173.160.145) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Thu, 22 Dec 2016 14:51:26 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBMEp6TD013482; Thu, 22 Dec 2016 07:51:22 -0700 From: Akhil Goyal <akhil.goyal@nxp.com> To: <dev@dpdk.org> CC: <thomas.monjalon@6wind.com>, <declan.doherty@intel.com>, <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>, <john.mcnamara@intel.com>, <nhorman@tuxdriver.com>, Akhil Goyal <akhil.goyal@nxp.com> Date: Fri, 23 Dec 2016 01:46:50 +0530 Message-ID: <20161222201700.20020-2-akhil.goyal@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161222201700.20020-1-akhil.goyal@nxp.com> References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161222201700.20020-1-akhil.goyal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131268918867173382; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39860400002)(39840400002)(39400400002)(39380400002)(39450400003)(39850400002)(39410400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(6666003)(81156014)(8676002)(106466001)(33646002)(69596002)(50986999)(85426001)(81166006)(1076002)(68736007)(50226002)(2351001)(8936002)(5003940100001)(77096006)(5660300001)(38730400001)(47776003)(36756003)(6916009)(2950100002)(92566002)(626004)(305945005)(76176999)(50466002)(105606002)(356003)(4326007)(48376002)(104016004)(2906002)(189998001)(8656002)(110136003)(86362001)(97736004)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0748; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC009; 1:WRTizGXX+QgNbJ6GLFXuvVLuAY3uuyE7STw7a5fq1kvfb9T2mMb4+9GTXk1XbAANSSW7VpJKvtH4tWK9OKvhqDV65Tod2e3v7+wQWvGMBDVb5PROVQLac2sEAsH2GNjgIlEcf2Gl/ls2PDwjYizg1UdoogzZNEBHOXDhbY/ckd4YqFHBD4b/Muwcvh1H7hC37pOvF/o8sLOuDghp+w58IInxWvljcmukXI4Oa0pXuOd8r8UXoA9/BTG10MZeWKJnQGLvBMroIjO6NGDFpMlaQlsHg4zvESrYIIQOXVPQUDQjnRxY43sUCg57gC6NQsLJhB2rvfmsXBqp1f4LQnHIc6RETrY89aukt7CA16Q1LSqoIL8/Gi6fuu90N7b/VfTbL9tz4wEGGcS8yDlN4tn0pFYXPusJ4Yhk8iuzxOC0S4mreBW2NRJm3s/GDIoseskLcAzhVYPHi8yePmd8IaO3OJWeplcK/LvO9FQJwycO1mhlUbDRwTevoXJAFLSIcVr1ddeey3WhKvP/qLSEGzyoRGwVgmNhAP7fFkfASAy84NFLWOggE65vA2URp43KDtqnagVdQa3FuuGh7NKsP4PB1J/3MwMjwOi5x/VTmj3JUTevVcX+Jf2axXr0QC7hYCy4gcqotKVN/VAqvdB+dbf/bk1HmL98dUxUghvNayjFvsdteTzdQbfzgGZ1oYKaMLbKrimu1ppINtrIl/ZFxgnV3XmSmAE0pE7APis2+q+GMxeLFJw9UbZuBBOpgbB05BwSGfS5RVqoW7DNOmLXS1zeYg== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 47e839d6-31fb-4646-a006-08d42a7a0197 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0301MB0748; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0748; 3:SWSVFvhDdIkxLyptgf53Z0Byfyntr/7OJp4XrJGCEGgd24/zWmLTNPP0DQ3K7qi4uFUihoBlmOsuK/LrXi+7WIj+bWknM/eWBYA8oI0XB8eDAyPgseu/pKvCYmiaUxAzxNr2jVlaWSYWY6QiGwdrY2PIicIfkypF94zZ9PhAgr3CE2/DaIOtXvh4fNOyykTa+Y0vT1CBP7IJFwb07t/gTubqP0sxxmleTeC92rUrIE+N8QjMHOLyoUeeF1EWSIGrlpH0zFEr3HCvNnwmSL9KMpo0I2ef3c58QPfRZ2UiwDBerIm6TF56WmCZfdtlj/1m71oYes0LfKUx0x4LdIjyfqGlLeWFiWxg9WxAivakVDk=; 25:wLTgG3G5iLgPITt8+VJUE+nXWV1IaNSFWwdTU0Qpnv1tTwpLHQdpvySVwQtQDifaHGcBvtxk1YyvSoUZMXgzH8SuGP5ybvacEpJKspUqi+8L3wbtZ9WEVswgXR0CXh8ZiydMzQqhFsNBnUpSmq9kwzMNRSvuBoi8YAWHyhDXzjI7CtRMEYX/j97pkUdalg1f+BdsWfNPdr98ZvsRnwKQo/hB5xNVYqUWujDtby2+hkyW1oTEJhjqpAKVJverM/hLoxnloizZD/VfNGN72Px3OI9jiog5D2SDP51Y+JXR1YqeB7sHusVoAV9m4VfUH9KecmfBQMY2iOkERkKa22N7zMWOZIJ6CsPqn0nvKYEmzkb/Uu9g1e6Hn/Shq5iFBs4SLn1vaRM4YVqsLyIdQ4Iunv5uFbKYgAOT/pdndKroKA40QC7K7G9UHcTBvfMnKqCsDczWMVXACVClHv7iy8GcCw== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0748; 31:+U5mqn7B4u3FrMis/1Cob6fcEeFr0Fe/F9WjoTcIq3gDoZriHb1Msvk1KIkag2aUl371oPyLfuDLc7Wn/fcpd5Y31lPeovUKj2wRhXYvB2w2MQfE+LcR9lEmwzo69auQD18oxL87xtrLWyPZDxuUmCykuyekR9bFl41gFjxBKfrkeaEYNiWCWi6F0TVbzKwpnnPDK/+h+zyIk7+/nDyvkyA9eJ0PvIm2u+e4EwgJYOS6HUL0eLGXrXX8ZJPqDlHwnYiPNSggJ/jZhOfqzXWqIA== X-Microsoft-Antispam-PRVS: <CY1PR0301MB074831A0DC805C6A5AA4DA8CE6920@CY1PR0301MB0748.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(13017025)(13018025)(13024025)(13023025)(13015025)(8121501046)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123565025)(20161123556025)(20161123563025)(20161123559025); SRVR:CY1PR0301MB0748; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0748; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0748; 4:z6BoTmrz4IU0bVcuYr/aCQGwyWUC6wsz3ZpbZ+BAaCntpaCw89MtBVz7gN8Sptz7e3iC1J4CZx8CtE7HaCGmXWv2TUWYYE3NH/PztlU6BFZdWAN8QfgBOCovEF0ojYMLEC60JMMfamYX8k8VzuPg1h66rut6KvfVAtyX00L8L+DSLBmqT28KKqZwd8CDQ7nuVL1C12PNwBNhLxK+8iptxiEAS8e3zzHeRdR31y3uCNVHcHVKZmvWCF9AbPBtbvzal/lxkV1Ugn6p+e9f0+UupR6mxtJuZtwjpzo+VNw1da7KRRFQvolFjNnKh6xJqm/H/FKiMD6ocj40acQJlkaedJbMDBAqxwW8bivqHUA87CERXK3NVlj29LzQ6ByfXDJBKoe1Wmw2dYLEFmSbv11tHcmhTTE2nKxAk5uUDIdWmz3VL9rFFR/FRKKJlXvaJynm+TfvUhyPbwhJip60aVa5Cu5d/VF+nhjEon14naWNlX1Kj8zgmTNEuoQd9CS4qBqZu44QgPe2Gb9o1aB60T1MprajdVM/x2auluUirRO1s+xih+EoFAVKdo6TNS8hPkmd/R1obUhZfReFtZV6YqDxqqdFI9FCFrDqxeC3emINY2QoIIWmnSXTsAGpZWnca3TlfYcCpNpaIyxsVxlFtqTk/fgmY6AYrpPkEbF77Sc2XEpRyNY6Yv5pH6d67AUneZEJ7l87ITfko6hGv2DcsJ51AvNmRf7OQM0/77KwlufA4FMyeAiBPRinkNBMt1FChGYJ X-Forefront-PRVS: 01644DCF4A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB0748; 23:OwRP33VQv5R9JS8gBBNH0cYKAct3+bvXMufRjeC?= 9LkXc1gbE3+U0rCIGFPPLq98gtAy6tJITK93rlqajHkfQIlWeomDw0cVbH2fFus4B/9cgSYD0Q9/zCN8qWC2ixRyRKHfQMMWKZ8F9JKF1FDiJPAwHjS0XO7295EptS/vGBeOlNpxedq2LZ77IIqUWYfDCNO9sULVnmz9Y1wLH25kuUMJet7sWuaWa3bcVwZc3CyDDDhgePU2CvWyttCwLJrSWeIrkVurnv6d5ulqO+rugwt4OwPmeJDb/J5joJHnI+oOUyaKWSKlvEldhcaWNVFTdvMVVxFgwmiXal7JFB98Iyy5isRHHdsc9NFe94itc8PRbJ7KRQxk6e76o68kJz48NzfucwZnM77Vdsby71+EL/RTlPQ5YBM7PpTbBw8jEOUIFDCIRkDVtG9ZZ3+JNRev3PneoOVspwSuKPVbKhCeUFffWnIhOlEXzVxRCW3FAk5YpyBr4WXy8FTWlASpzdCRenIEINIWwVPq1KMz5hltNlO8DLpuvK3O5l6gZLo2izz4ob7rXpn5iikq2fpUjIVvlVaDbV9KgBBA94lGGkDbNhL1Snr12NWQAueVX2pKE9ddjCbsAfG8F5sr3g7PfVVRxef0TtAQNa6gDcyYfztnn3GKBx+/AO6/7J6U3hrHa3UI9Va6R6NJgY6AEfex5nzljCOjJNQJLLpMkAysywcvm8fiVQCmYmlJr1wS8A3W+z38+qmu4DTOVdFiWM+pG7zgmI9UJURIm/UxW55L0dkNOF3u/5YREjLUpI4QSSUvvvyIqfOI9XSqVGtkzyd76BF85Fx+ODjYvhcgDuScEl5DrKbX+W/iVPbKmLsU06TFAjr3Y9LIdUmT5k6dJwnKUfo5Cu6C54QaZITnp1TlJsMJAHoiU+t182jynJnJIEzGvKXUoAFwPjXjkzYZNGqp2Lp+/ZYskVXvN152vPVPLxGFS6XC2dJ0khLDjto6YS4A+MPMeowcW19oMqXZz9Ka/Q2N8glbuAS2gne1rJIboMFr4Etps75RfrBxYM/x44+PdAysjjVP0+ZvUVytOOmTafzbyMaZH8011aEG+TaDrOgOilgnyJ1BOYvShgiC8UAZ4uJ45Btzb3YSSbHjuA+U5d992/9G4WS7U22LJI3l3kGd37pQVy4LH2wVdaCa3yW8qJ5wLn+NX+loJnUYNU2mQi5jADvHKiwwcUglnuI4X1ZTwxeWMHCHPo587ZFaty/+54Ce/9Ja0mL8E1O76JLjB3fmKGsLE9NS0rF+X2vNp8j7v5CToAqRU+rKFXRLZAHzIedV6jv6EFpzuW8/OOuHz9pen X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0748; 6:K92R2UGJLYR5lxg2ro+bJg+PvHGtoi2IaqsRkj0wbhHlQObWNVMNeutkcnHHb/OxzkThoge5xf3VJQL7QzO93EaLB01soiBTPiST/80a7BR0M7eOBD7JLhvPApzv179WRSkfBOmvnG3YMaTHxlCBSigRdhJhUv7TTYoQc48UC8WMj03jpDYM487f/2ZRNgiB6fFJUD4xt332Mbm++o4rjtlpmyCFZ1xRrmYbgnf0zR9nMd5jecOIo5izAt6Pd2Pm7LYiXMTbN2ebVqRJbVwKntShHRpGwfJNEwqqHXg0uWOlmYibd2zPrQbSy1Il60+azPa0F9t/Qu67u9pAPzyL6yw6pPEJb8yGktoCawHVxGAQmYQIkDTI+DghJLs1SZeHXqS5LPazqxmF3M2z+7xCywF6gH1cpn50OiedXvSt/fji2tT8FVOOTOMsLCWTr3Bp; 5:S2LpcUJzd/8VPtd/yY+02LrvLzRDdM6Go/PE8xezEp85wZ7M6XvUBGp8OfU7XPmDACRV53hb9wTGGxAW0pwxHv+QwwtFayZiLb89EjkiYLfm88FlUMq1HRE9cBmMM8DIXi2DYQEhXNntL2G3Ap+Oz6cgC+EcNDgsvNZLlFAYM4uxqSBEyV0dMEoIqjx8PUmu; 24:z60PywuMmQGAlfzAfG3I+5Wexm/ELgP+Aj58GnFV4bniqFzEQrueKryFKXaq3fzLogi3ScBK9BmNe74DeKHQUTCzmw2S2UztOf/xRIUK8mk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0748; 7:XdqQKPP5XDUBrUWxo/0StTGqCGRKVAFHJegDX8xIngXVBhjaA0Ihb1+3VUbQjEV9ETAV6iCqy6sOna4sz9EFIGU61Ne3lC9vrwJ5x7ETDMsseRTb/xjJOgXK1u8SDP5DZLJZRJJFHJ0n2bNETvuqu5xLRmt1MgD7W00AbgG4XCRGw+sNnmkUpb6pwz2efiHHxb5U0K0dGwxIY+oz0Chbn3AEKbZbP7uNv2UFF6X9bNjnPfzUl2+nuLLCILv+vzpjihAfaORAcz82reHCrhphjtTBf8OFje/e8vbukXX780uO+R9BLCRQqKWN+YKEUwXASfzpLHiuTMTcn35qCNeha0glzZTm4hNaRtOb465p9oK7hKfMSL14WpG8l0wJmtvvI8ylRU/Sv6bYcuY1fm/64d6web1/tlpELu3GqIufFEcp7FwfK+UcLyI8kEfMRJPeqoAgHg79owxfC2lYez2vRg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2016 14:51:26.4521 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0748 Subject: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device pointer in cryptodevice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel compilation | success | Compilation OK |
Commit Message
Akhil Goyal
Dec. 22, 2016, 8:16 p.m. UTC
This patch will not be required as some parallel work is going
on to add it across all crypto devices.
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
lib/librte_cryptodev/rte_cryptodev.h | 1 +
1 file changed, 1 insertion(+)
Comments
Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agrawal@nxp.com; Mcnamara, John; nhorman@tuxdriver.com; > Akhil Goyal > Subject: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device > pointer in cryptodevice > > This patch will not be required as some parallel work is going > on to add it across all crypto devices. > Could you tell me the patch that is going to add this? In that case, you can drop this and just say that your patchset depends on it. Also, the title should be "cryptodev: add rte_device pointer in crypto device". Note that for libraries, you just need the name of the library (i.e. cryptodev). The other thing is that the first letter should be lowercase. Could you change this in the other patches too? Thanks, Pablo
On 1/9/2017 7:04 PM, De Lara Guarch, Pablo wrote: > Hi, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal >> Sent: Thursday, December 22, 2016 8:17 PM >> To: dev@dpdk.org >> Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; >> hemant.agrawal@nxp.com; Mcnamara, John; nhorman@tuxdriver.com; >> Akhil Goyal >> Subject: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device >> pointer in cryptodevice >> >> This patch will not be required as some parallel work is going >> on to add it across all crypto devices. >> > Could you tell me the patch that is going to add this? > In that case, you can drop this and just say that your patchset depends on it. > > Also, the title should be "cryptodev: add rte_device pointer in crypto device". > Note that for libraries, you just need the name of the library (i.e. cryptodev). > The other thing is that the first letter should be lowercase. Could you change this in the other patches too? > > > Thanks, > Pablo > Thanks for your comments Pablo. There is some discussion ongoing regarding bus model for DPAA2 platform. This change is already there for ethdev and we would be replicating the same for cryptodev, once the bus model patches are completed. This is added here so that compilation is not broken for subsequent patches. For title, I will correct that in next version. Thanks, Akhil
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 8f63e8f..bb5f41c 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -623,6 +623,7 @@ struct rte_cryptodev { /**< Supported features */ struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ + struct rte_device *device; enum rte_cryptodev_type dev_type; /**< Crypto device type */