Message ID | 20160926163300.22990-3-akhil.goyal@nxp.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Pablo de Lara Guarch |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1844058CF; Mon, 26 Sep 2016 13:05:12 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0069.outbound.protection.outlook.com [104.47.33.69]) by dpdk.org (Postfix) with ESMTP id 35ECD3238 for <dev@dpdk.org>; Mon, 26 Sep 2016 13:05:07 +0200 (CEST) Received: from BN6PR03CA0017.namprd03.prod.outlook.com (10.168.230.155) by BN3PR03MB2225.namprd03.prod.outlook.com (10.166.74.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Mon, 26 Sep 2016 11:05:06 +0000 Received: from BL2FFO11OLC001.protection.gbl (2a01:111:f400:7c09::102) by BN6PR03CA0017.outlook.office365.com (2603:10b6:404:23::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5 via Frontend Transport; Mon, 26 Sep 2016 11:05:06 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC001.mail.protection.outlook.com (10.173.161.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Mon, 26 Sep 2016 11:05:04 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8QB4waI005049; Mon, 26 Sep 2016 04:05:02 -0700 From: <akhil.goyal@nxp.com> To: <dev@dpdk.org> CC: Akhil Goyal <akhil.goyal@nxp.com> Date: Mon, 26 Sep 2016 22:03:00 +0530 Message-ID: <20160926163300.22990-3-akhil.goyal@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20160926163300.22990-1-akhil.goyal@nxp.com> References: <20160926163300.22990-1-akhil.goyal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131193615055791203; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(18543002)(86362001)(92566002)(4326007)(81166006)(86152002)(19580405001)(85426001)(1076002)(2906002)(47776003)(50466002)(81156014)(8676002)(19580395003)(586003)(2950100002)(6916009)(7846002)(305945005)(48376002)(87936001)(33646002)(626004)(8936002)(5660300001)(11100500001)(50226002)(105606002)(229853001)(104016004)(76176999)(68736007)(50986999)(2876002)(97736004)(8666005)(2351001)(106466001)(77096005)(110136003)(189998001)(356003)(36756003)(5003940100001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2225; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC001; 1:0jdLGkIQGqAVYSpg2oiC/ZL6f/pyaxOrgv/Kuz+WJ0XCt6yFZTEHw46IzF7+dCErLPpQVqgVvQEbDW94Zmb4GaSgQMawvH1w4f5b2k51dD6KuuQTfCFMvlpusEm6PueSAZUHr/GJieDDqLzHZFZq4bUx3peEeUQwwb+KJoJUaDjQ0MIdzIUJHsY9WD+/MeieWm4QoBHi9nhyl2HBi8kKW9z2OQuv0TCqzM5/3ewSpW2P/ni22AQC6ZAvvd79wKGCAcfserYjCzspbzbhWzL+H6fu9dPx3Seyb7RmaZf/Z8XLCpaQpDW6YCYLnpNUX1fmsNFXD/a70yBuNCiGJYtF+6MirF0y1kdYNRkH0m7goJU2YdhkEIWNsS3Bq9Zeg5dRI1voz/leN2biw5wYsTaOrkHb1jKi5wAX9kL4wPFLpJYBsz3R0XlZkB02yWHeUP12c0SWXlSzph/3VgE0B4m07Pk3HJgDhx6u8OjZFiNlnwrLpoxTD/C6sAJb3UiwcWwi3cykPZ/gTkjtAhb4HjJ+1sQ+HmrTn3K1YhfFpOSTrsiphzvDb8HS5zRc3nbXqlSohSzOdR25D4wCGw7cbIZf7eiuKBRgnC5Jil/O03ZCJLoYqmhqnMD9EJYv7m/6fY1fr2N6/Dz7EdAsxLqfuXiRsSrMMz/6OjQTZpzgHZzX5+uaT0bQX0M31YdqnWPiAtSB5bHwHg2WskBjDxzHVP5tWnUbZcmz2RdIvMnHzyzDQmY= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 140be84e-467c-4335-2463-08d3e5fcf8aa X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2225; 2:c7DQloTHGVKVlYJxGVV9xsasCvvM7Ww2oPuhdLcLuKdcRDsXQF4POwNFNlPj38XuiJUlCJyH6MQlDIlYhq3TL7hIAui3VnWSQbHIDPKBLEucf2W4khgPf/xHY3Ym95INeiHEcgTO6JmkDEhUDYnKsuzS8lqRmiZqjLHemKbr6zTZ17GVGW3Mr20Td1T51yZt; 3:AL2+AqAlJ0KpA0CTHyZgjmPM8urJ0CHx7cQ13oTQhLKCRCz5/xhc1dsmbbPw7hbUf+w1vbR0akNTvkfQcrk0VEAzJhXI+8Vpcf/J8T4/sHcc0bwsbDw5nCj+eiwNEgx+WO3dclPWI6TstrEWbHBXzKTSfQteK47PpygzQqZsr23Zam09JGaMajgkwgyF8Td07O3vZH7r4V9PtWWVXVQSiwPasyqtyr/eXqV0+Li0rRo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB2225; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2225; 25:5sx+BFLoL7DBTEvPCCqSIJq6K7Vbdo1CLGzaBmqFoztq2bkUC8FFGZI5mrUo0Der+tMdG9G+dcoJswKXootH6sNHG4SGP6CaRPP1RJMLCCum2kb5D1X1TwpIX9rFhHIta1hEmiLuGuJVJTcRypMTq3qxaO+gNRDqYJ7/Y82XviunpRY790gqJySsaRVcbYfvyolObfMephhWaLPcWpUV42bUnkENTZz8LoAL5xn+ZvubllyDJyXleIF9pdJf4dTbU7wlsNuB7b8hZQeAPaWzUn9yKewzx0JWrPsI5A15e7MIwl9j9TUFaDf9rAxfkGCc0J/asCCdFfJ7LTQcMvEkm06OzshEOheQhGpSq/qPAwriVXdI2Tub3q48lrGrgKYm2xbISU275lkqRge902W10AC1MckUwPAzh+yRHbeba9TLFMHncAJzFZI8CB7IYdAGhTyp+RHHd9BE/+RzSbJKTP1aNYAe7mj0PcoxHbPPOrccDlgtRnCjnIDzihYMaXXzhKZRfOb/RiVlYGT5u4XzfjKg7HR5uGOgUXbj4qtbsW4gJYsUnUNsID11Ku7I44K7u4LUduXqca980F4vy5tZjZ2XK+onJ9dg1JsXmddrn41ThE34aavK442PdtxC/QRplhajf+3vzeTQQliMYMjwutROdLkRGuc0E929qFHLWn+yT8I1SgZJaS+Anh6GUnxA8fdm3K3LNZfmr/xHrmW1dgddfc9tCClZFcLGzZWcRFI= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2225; 31:L/bko1brhDSlwD8Tl/q6TmFoPjbig6N7GU4euoM0t2V+5YrHoytabKZcGb/N4KbCT+sOxvruefDbkzP8z1sS10h8G3Xm1DswOmiB3odBpuutSHe9B4KCMswDxHW9w5XBstnNZu6AmVnOQZ4qTdwwm5duab86tx6WGB3VqY46YbjwsOL7VSbne9ZBl8qFiz/ZoZ8wqOjey1XPpfquLZDt8Rjz7A27r7NLTEbdPmMzJ68=; 4:wjoZh0Ucrax191OnRwN6sFVTKCfU91N2jfHOkzqQoVY0MxkmPeIjLmLwZ1fHRi1ZgwkHxaRpzpsXfO9J36aIEpFCPGXbnAaWWT0uXsMkqn+xZO3a7UV1RCJtsnLR4Bsblj+PElkufSUieY+Nim8XYi7u3hG2R7OHnuf+zoGbRPhypof887yO0IgBNterN8WtWc5CXxyZn+gM1aclo7g5jGsaHiVVOT77K3VEWgsvlYyIKZKD5v+SveVapM5VwTO1TSyCqXCRMBYG/DJXJdmvU8ku6vTkHtAeV6bTjh+0i1W5garr66FshdjRgbA/Q1KbIm0yxbfSXvE41ksBSkOJJPo5yZGlDaFmlDujVZTfKP7gKPowTnW5V6d14EjhHEDzsUfl7Sb8KxlLLaxmyQCTQ7bGCODOyoG3p9OG2yvETtHAth+QLHAFDNxLV2oBSjB5YZsRHsFiyfy8hti1qktl4ZTAvTgzaOa0F7eA4g3Tjm8+2r/ilrdytoytHdcKnE3yP8jsmd3/PQr97kOxbEsvT9oWe2BUEh9t4PZW5tPykk4= X-Microsoft-Antispam-PRVS: <BN3PR03MB22255C7445EB5318C7137F15E6CD0@BN3PR03MB2225.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(13023025)(13015025)(13017025)(13018025)(13024025)(5005006)(3002001)(10201501046)(6055026); SRVR:BN3PR03MB2225; BCL:0; PCL:0; RULEID:(400006); SRVR:BN3PR03MB2225; X-Forefront-PRVS: 00770C4423 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR03MB2225; 23:+nt605zvX0Lpgz21PPIxxQ82HTuU2Q9dpKikMOYsP?= =?us-ascii?Q?8Zo8O/V/FqMIXWPjN3q/3g3GkhlhyS5ePo6DNsT2X/aKJtZT4BCMr9386eeZ?= =?us-ascii?Q?N2wz43fDoAzyT7bBdrmcsCH0FUh6innGv0Ix67cWnsn0YEdJgQtP/VjccCWI?= =?us-ascii?Q?L3SSLhAOUX0YH1deue71ISeLaIONZXDoWurtq9xj2d7mR5ZB+/N7YhXCXwUj?= =?us-ascii?Q?i4moI6lLmf79HnPcNgoaC/ehUcEocL5yTagc9MjYVhBEGljQG2/HYydBrqdl?= =?us-ascii?Q?zExXZsNBXgSw4fR7igQB8t5n8Sswcy4olCp71rm5ApTxDSwqXpnA01+yQtV9?= =?us-ascii?Q?+05jR0ouogv7sHX/6T5jpGZuRmsnj1ynYpa/jbdTIZ9+yDqG0LSOycw+aDxL?= =?us-ascii?Q?7Av0msng9WlRbccjdjA2Tc5OK2p0BU1am4+hg1MJ/KfL2MEv9g706/Uc/SE5?= =?us-ascii?Q?VAHmZQfpVmsvjZ07db1OMvg3Rp23fbNdQgIu//+7PkuobatFSUbWpVz2CdUZ?= =?us-ascii?Q?RFZsZBYa+0n5wtzLMsBKMLlxH/t0pEgTV1EQklKt8J/ZfC+VJV+4DwrqeO2z?= =?us-ascii?Q?tTHuBSBeJ8A8GhIPaWSyt/uBGu0kTd0OdCRLE6G80dSrq8zZ4C19Ly7kcXL7?= =?us-ascii?Q?LygP2uIMlFwwFpguHhCgIUqdnjRTJBIGfZ+nwqdMq7G7YkFVXVSa5BXsDXJn?= =?us-ascii?Q?Aq0MgnDjLVNo2ePqdvBU6/Bbs+UQ0AvRpC4+lYcHlf2x78pqaCfmfrgIdlck?= =?us-ascii?Q?jhl3Ou+iaAYxyH5bdv19yS11gRzhAF5NtStTsSLsj3unMn3TU3lR9p0Whs/3?= =?us-ascii?Q?t1i9hCfB4CZ8fSL8XoeYMkY1m98KRWhRRE81Qecx6UB3rCcSz6b/Tf3q24As?= =?us-ascii?Q?wzm/uC5Z25gZPSOuuas/pZBWW5UKFsHqJRb1reb8S+SRpxNuyxsNSTmM3IPg?= =?us-ascii?Q?CTAb+Z+2hmiGW340vZHC/NnXJZ2s4L15/jjjbqR1hOFhbFDnk+F9Jaq01PLb?= =?us-ascii?Q?OycMF30oJWbwK8o+S3f5b+82+NXn2r5MSCgm6SreTxwWHkgG/Q233hRKhx2Y?= =?us-ascii?Q?aVcoOOwfCSa8O+AmHK9jhMi+UUtmSCPFpfKFAShlq9x9+YkBtSn2MFu1PzN+?= =?us-ascii?Q?gS9UBv23Wstqop1+GlKmbM6FIRzPO0P/AKkmY8RMuy2uiAgRUUtyREBOzIpD?= =?us-ascii?Q?dfMpFc8Cx0WLIR/b0MV4MQhgk3tOFPnV6r5sToX2lpCrwZmf3CxlSxlctdGL?= =?us-ascii?Q?YOJo3iEWtcIivlVO2DyT2YB5PnLcAsvNsBr5KrL?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2225; 6:uazaBeSluA5glpDnQP/DHNLnkko9bzhileuzJmuZzlZMLoe7proCVBBuCKuuSL7QsybZNVbdSkKXBqSjzsNsnHN7v/4P4vdHaHYq15FXavtYddJx0nEqZXi9Dh2tr5H/ai4hn7J4z1B9v4lmZw5NG2m0fSJUzogIklNo+nxYSj9pZqPfNNIdpC+2gcwpkdVmlgMCr6fSiDGI4a0HrvN+mwrzkO7NorsZvESE0hVUGhk0XQqo+gi+uzJ6bQLKUkFCHXDdV3ksvvzl67dp5idAFBzFjcoi1Af+xIQQwVKXY0g=; 5:XygEvl/kq9gFE9yiOkz4t4LbIOjgbFeFbWmTCAV7D0JiqQehWIkjxnfba7Yof+mWc6lU90NYBkf5YAWiOIA5ssuYvQcGkj/fLhAUtGvlcgXbC8GyeT1yn/VnMVZKok8JrqfPH4E+JwciwvlmJE/TJy9zrWNGH2O0MBL7Xg/Ad5k=; 24:/pCCBzi8NcnySH/ffC1GrzAVHQlphheXLIpxoR0brcd6NBAvcmCD7qgKIpskEboPg6NZDosSVa8LF7GTAjtBe4zOLwtoiurxDrNWYglqDA0=; 7:IF0p6mzI8fE6K/9WxCMWSxZs9HDfgJ2SNuw4SwfrsxT2Tq/fTVRHIu9h3IjX2MRRs/DUROZGAv0OlyHf2pwp7ktIpwyxYCSABfNkH+UU5evqLYXg9Syrc3ZYILs2v0hT0NKu2oEJYWfpTRiTfyoiusMVaHH2OkuCaDwemUrP7qXWOI9CcIV4WgeXOXuMscc6OpkN0qLWZttKPyXeZEf9mSme5NO8myokBsiX3ayAN9LDzxIdmD8GUA0fc6crLjP7C8kGO9OFXegqO9doYUXwkrRBJOr2ISkK5Cd6JZlRAJwUDtnQeN9mPWWN2PMm2d8J SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2016 11:05:04.7367 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2225 Subject: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Akhil Goyal
Sept. 26, 2016, 4:33 p.m. UTC
From: Akhil Goyal <akhil.goyal@nxp.com> For physical crypto devices, IV and digest are processed by the crypto device which need the contents to be written on some DMA able address. So in order to do that, IV and digest are accomodated in the packet. Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> --- app/test/test_cryptodev_perf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
Comments
On 9/26/2016 10:03 PM, akhil.goyal@nxp.com wrote: > From: Akhil Goyal <akhil.goyal@nxp.com> > > For physical crypto devices, IV and digest are processed by the crypto > device which need the contents to be written on some DMA able address. > > So in order to do that, IV and digest are accomodated in the packet. > > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> > --- > app/test/test_cryptodev_perf.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c > index 0ea7ec1..930d5b8 100644 > --- a/app/test/test_cryptodev_perf.c > +++ b/app/test/test_cryptodev_perf.c > @@ -2366,9 +2366,13 @@ test_perf_set_crypto_op(struct rte_crypto_op *op, struct rte_mbuf *m, > op->sym->auth.aad.length = AES_CBC_CIPHER_IV_LENGTH; > > /* Cipher Parameters */ > - op->sym->cipher.iv.data = aes_cbc_iv; > + op->sym->cipher.iv.data = (uint8_t *)m->buf_addr + m->data_off; > + op->sym->cipher.iv.phys_addr = rte_pktmbuf_mtophys(m); > op->sym->cipher.iv.length = AES_CBC_CIPHER_IV_LENGTH; > > + rte_memcpy(op->sym->cipher.iv.data, aes_cbc_iv, > + AES_CBC_CIPHER_IV_LENGTH); > + > /* Data lengths/offsets Parameters */ > op->sym->auth.data.offset = 0; > op->sym->auth.data.length = data_len; > @@ -2468,7 +2472,9 @@ test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id, > rte_pktmbuf_free(mbufs[k]); > return -1; > } > - > + /* Make room for Digest and IV in mbuf */ > + rte_pktmbuf_append(mbufs[i], digest_length); > + rte_pktmbuf_prepend(mbufs[i], AES_CBC_CIPHER_IV_LENGTH); > } > > > Hi Declan, Sorry I missed out copy your name in the TO list. Do we have some comments on this patch. Regards, Akhil
Hi Akhil, Could you rebase it against newest next-crypto subtree, there were changes with function names in the meantime. And to make it really consistent across all hw tests could you add this change to qat_snow3g too, for snow3g I assume aad need to obtain correct physical address too. Regards, Arek > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, October 05, 2016 7:40 AM > To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com> > Subject: Re: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should > be stored at a DMAeble address > > On 9/26/2016 10:03 PM, akhil.goyal@nxp.com wrote: > > From: Akhil Goyal <akhil.goyal@nxp.com> > > > > For physical crypto devices, IV and digest are processed by the crypto > > device which need the contents to be written on some DMA able address. > > > > So in order to do that, IV and digest are accomodated in the packet. > > > > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> > > --- > > app/test/test_cryptodev_perf.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_cryptodev_perf.c > > b/app/test/test_cryptodev_perf.c index 0ea7ec1..930d5b8 100644 > > --- a/app/test/test_cryptodev_perf.c > > +++ b/app/test/test_cryptodev_perf.c > > @@ -2366,9 +2366,13 @@ test_perf_set_crypto_op(struct rte_crypto_op > *op, struct rte_mbuf *m, > > op->sym->auth.aad.length = AES_CBC_CIPHER_IV_LENGTH; > > > > /* Cipher Parameters */ > > - op->sym->cipher.iv.data = aes_cbc_iv; > > + op->sym->cipher.iv.data = (uint8_t *)m->buf_addr + m->data_off; > > + op->sym->cipher.iv.phys_addr = rte_pktmbuf_mtophys(m); > > op->sym->cipher.iv.length = AES_CBC_CIPHER_IV_LENGTH; > > > > + rte_memcpy(op->sym->cipher.iv.data, aes_cbc_iv, > > + AES_CBC_CIPHER_IV_LENGTH); > > + > > /* Data lengths/offsets Parameters */ > > op->sym->auth.data.offset = 0; > > op->sym->auth.data.length = data_len; @@ -2468,7 +2472,9 @@ > > test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id, > > rte_pktmbuf_free(mbufs[k]); > > return -1; > > } > > - > > + /* Make room for Digest and IV in mbuf */ > > + rte_pktmbuf_append(mbufs[i], digest_length); > > + rte_pktmbuf_prepend(mbufs[i], > AES_CBC_CIPHER_IV_LENGTH); > > } > > > > > > > Hi Declan, > > Sorry I missed out copy your name in the TO list. Do we have some > comments on this patch. > > Regards, > Akhil
Hi Arek, Ok. I would rebase the patch. Regarding changes required to qat_snow3g, I do not have setup to test on qat and the hardware that I test, currently snow3g support is not added. I can send the patches for snow3g at some later stage. Regards, Akhil -----Original Message----- From: Kusztal, ArkadiuszX [mailto:arkadiuszx.kusztal@intel.com] Sent: Wednesday, October 05, 2016 2:57 PM To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com> Cc: Jain, Deepak K <deepak.k.jain@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com> Subject: RE: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address Hi Akhil, Could you rebase it against newest next-crypto subtree, there were changes with function names in the meantime. And to make it really consistent across all hw tests could you add this change to qat_snow3g too, for snow3g I assume aad need to obtain correct physical address too. Regards, Arek > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, October 05, 2016 7:40 AM > To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com> > Subject: Re: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest > should be stored at a DMAeble address > > On 9/26/2016 10:03 PM, akhil.goyal@nxp.com wrote: > > From: Akhil Goyal <akhil.goyal@nxp.com> > > > > For physical crypto devices, IV and digest are processed by the > > crypto device which need the contents to be written on some DMA able address. > > > > So in order to do that, IV and digest are accomodated in the packet. > > > > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> > > --- > > app/test/test_cryptodev_perf.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_cryptodev_perf.c > > b/app/test/test_cryptodev_perf.c index 0ea7ec1..930d5b8 100644 > > --- a/app/test/test_cryptodev_perf.c > > +++ b/app/test/test_cryptodev_perf.c > > @@ -2366,9 +2366,13 @@ test_perf_set_crypto_op(struct rte_crypto_op > *op, struct rte_mbuf *m, > > op->sym->auth.aad.length = AES_CBC_CIPHER_IV_LENGTH; > > > > /* Cipher Parameters */ > > - op->sym->cipher.iv.data = aes_cbc_iv; > > + op->sym->cipher.iv.data = (uint8_t *)m->buf_addr + m->data_off; > > + op->sym->cipher.iv.phys_addr = rte_pktmbuf_mtophys(m); > > op->sym->cipher.iv.length = AES_CBC_CIPHER_IV_LENGTH; > > > > + rte_memcpy(op->sym->cipher.iv.data, aes_cbc_iv, > > + AES_CBC_CIPHER_IV_LENGTH); > > + > > /* Data lengths/offsets Parameters */ > > op->sym->auth.data.offset = 0; > > op->sym->auth.data.length = data_len; @@ -2468,7 +2472,9 @@ > > test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id, > > rte_pktmbuf_free(mbufs[k]); > > return -1; > > } > > - > > + /* Make room for Digest and IV in mbuf */ > > + rte_pktmbuf_append(mbufs[i], digest_length); > > + rte_pktmbuf_prepend(mbufs[i], > AES_CBC_CIPHER_IV_LENGTH); > > } > > > > > > > Hi Declan, > > Sorry I missed out copy your name in the TO list. Do we have some > comments on this patch. > > Regards, > Akhil
diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c index 0ea7ec1..930d5b8 100644 --- a/app/test/test_cryptodev_perf.c +++ b/app/test/test_cryptodev_perf.c @@ -2366,9 +2366,13 @@ test_perf_set_crypto_op(struct rte_crypto_op *op, struct rte_mbuf *m, op->sym->auth.aad.length = AES_CBC_CIPHER_IV_LENGTH; /* Cipher Parameters */ - op->sym->cipher.iv.data = aes_cbc_iv; + op->sym->cipher.iv.data = (uint8_t *)m->buf_addr + m->data_off; + op->sym->cipher.iv.phys_addr = rte_pktmbuf_mtophys(m); op->sym->cipher.iv.length = AES_CBC_CIPHER_IV_LENGTH; + rte_memcpy(op->sym->cipher.iv.data, aes_cbc_iv, + AES_CBC_CIPHER_IV_LENGTH); + /* Data lengths/offsets Parameters */ op->sym->auth.data.offset = 0; op->sym->auth.data.length = data_len; @@ -2468,7 +2472,9 @@ test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id, rte_pktmbuf_free(mbufs[k]); return -1; } - + /* Make room for Digest and IV in mbuf */ + rte_pktmbuf_append(mbufs[i], digest_length); + rte_pktmbuf_prepend(mbufs[i], AES_CBC_CIPHER_IV_LENGTH); }