diff mbox

[dpdk-dev,v2] scripts: add more git log checks

Message ID 20160923124727.30356-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Ferruh Yigit Sept. 23, 2016, 12:47 p.m. UTC 
  Alphabetically sorted items to check and
added git log capitalization checks for LRO, NIC and PMD

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 scripts/check-git-log.sh | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

Comments

Yuanhan Liu Sept. 26, 2016, 3:26 a.m. UTC | #1 
On Fri, Sep 23, 2016 at 01:47:27PM +0100, Ferruh Yigit wrote:
> Alphabetically sorted items to check and
> added git log capitalization checks for LRO, NIC and PMD
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  scripts/check-git-log.sh | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
> index 1e05cf2..5f8a9fc 100755
> --- a/scripts/check-git-log.sh
> +++ b/scripts/check-git-log.sh
> @@ -112,20 +112,23 @@ bad=$(echo "$headlines" | grep -E --color=always \
>  	-e '\<[hsf]w\>' \
>  	-e '\<l[234]\>' \
>  	-e ':.*\<api\>' \
> +	-e ':.*\<arm\>' \
> +	-e ':.*\<armv7\>' \
> +	-e ':.*\<armv8\>' \
>  	-e ':.*\<dma\>' \
> -	-e ':.*\<pci\>' \
> -	-e ':.*\<mtu\>' \
> +	-e ':.*\<freebsd\>' \
> +	-e ':.*\<linux\>' \
> +	-e ':.*\<lro\>' \
>  	-e ':.*\<mac\>' \
> +	-e ':.*\<mtu\>' \
> +	-e ':.*\<nic\>' \
>  	-e ':.*\<numa\>' \
> -	-e ':.*\<vlan\>' \
> +	-e ':.*\<pci\>' \
> +	-e ':.*\<pmd\>' \
>  	-e ':.*\<rss\>' \
> -	-e ':.*\<freebsd\>' \
> -	-e ':.*\<linux\>' \
> -	-e ':.*\<tilegx\>' \
>  	-e ':.*\<tile-gx\>' \
> -	-e ':.*\<arm\>' \
> -	-e ':.*\<armv7\>' \
> -	-e ':.*\<armv8\>' \
> +	-e ':.*\<tilegx\>' \
> +	-e ':.*\<vlan\>' \

That basically means to me that you should store this (long) list into a
file, with the help of "-f" option.

	--yliu

>  	| sed 's,^,\t,')
>  [ -z "$bad" ] || printf "Wrong headline lowercase:\n$bad\n"
>  
> -- 
> 2.7.4
Thomas Monjalon Oct. 26, 2016, 9:34 p.m. UTC | #2 
2016-09-23 13:47, Ferruh Yigit:
> Alphabetically sorted items to check and
> added git log capitalization checks for LRO, NIC and PMD
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 1e05cf2..5f8a9fc 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -112,20 +112,23 @@  bad=$(echo "$headlines" | grep -E --color=always \
 	-e '\<[hsf]w\>' \
 	-e '\<l[234]\>' \
 	-e ':.*\<api\>' \
+	-e ':.*\<arm\>' \
+	-e ':.*\<armv7\>' \
+	-e ':.*\<armv8\>' \
 	-e ':.*\<dma\>' \
-	-e ':.*\<pci\>' \
-	-e ':.*\<mtu\>' \
+	-e ':.*\<freebsd\>' \
+	-e ':.*\<linux\>' \
+	-e ':.*\<lro\>' \
 	-e ':.*\<mac\>' \
+	-e ':.*\<mtu\>' \
+	-e ':.*\<nic\>' \
 	-e ':.*\<numa\>' \
-	-e ':.*\<vlan\>' \
+	-e ':.*\<pci\>' \
+	-e ':.*\<pmd\>' \
 	-e ':.*\<rss\>' \
-	-e ':.*\<freebsd\>' \
-	-e ':.*\<linux\>' \
-	-e ':.*\<tilegx\>' \
 	-e ':.*\<tile-gx\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<tilegx\>' \
+	-e ':.*\<vlan\>' \
 	| sed 's,^,\t,')
 [ -z "$bad" ] || printf "Wrong headline lowercase:\n$bad\n"