From patchwork Fri Sep 2 15:05:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Gatto X-Patchwork-Id: 15597 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E9916532C; Fri, 2 Sep 2016 17:05:31 +0200 (CEST) Received: from dv-adm01.admin (ows-185-21-195-233.eu-west-1.compute.outscale.com [185.21.195.233]) by dpdk.org (Postfix) with ESMTP id D6D6B4CE7 for ; Fri, 2 Sep 2016 17:05:30 +0200 (CEST) Received: from localhost.localdomain (unknown [172.19.166.138]) by dv-adm01.admin (Postfix) with ESMTP id 6B94140319; Fri, 2 Sep 2016 15:05:27 +0000 (UTC) From: Matthias Gatto To: dev@dpdk.org Cc: Matthias Gatto , huawei.xie@intel.com, yuanhan.liu@linux.intel.com Date: Fri, 2 Sep 2016 17:05:21 +0200 Message-Id: <20160902150521.680-1-matthias.gatto@outscale.com> X-Mailer: git-send-email 2.9.3 Subject: [dpdk-dev] [PATCH] virtio: remove obsolete comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As new_device and destroy_device use an int instead of a "struct virtio_net *", The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus If I've correctly understand the code, the drivers take care of setting the flag before calling the callbacks, so I guess that this comment is obsolet and I've remove it. Signed-off-by: Matthias Gatto --- lib/librte_vhost/rte_virtio_net.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h index 9caa622..a88aecd 100644 --- a/lib/librte_vhost/rte_virtio_net.h +++ b/lib/librte_vhost/rte_virtio_net.h @@ -59,10 +59,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM}; /** * Device and vring operations. - * - * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and - * remove it in destroy_device. - * */ struct virtio_net_device_ops { int (*new_device)(int vid); /**< Add device. */