From patchwork Wed Oct 11 14:35:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 30149 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C99B1B2C5; Wed, 11 Oct 2017 16:37:02 +0200 (CEST) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 19A491B261 for ; Wed, 11 Oct 2017 16:36:49 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id t69so5372470wmt.2 for ; Wed, 11 Oct 2017 07:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=asFGQVliKJEwPcP9wqJ7Eofj4vh5WSFipik/QMyXf6g=; b=w0SgugdnsVJSCyyiKdlibQHpdERWR7HaV5sXtnYjp5ZExjDLaTpx52xyP1twBfL44z nW1Wnz+1SGIX469H8IiqHJRmZFXUr9VtadoSlu4rWcn8umhlZnXLT0f03fjJ32v7pnh4 ZSfkcEoHhoXFvL7LflGU0mF4D5oE47Szz2J/hM78HGANLNWROdodkqymAD2gYX5Mz6BC rgnbyMfJM8oi5A67nwrfut2hlDrjjImO0CiercQdMiqlvSd2klbADXNLIuPmeRn716bg AnVbo6Q0Bet5E3pfghKjWDEgEOo4aQhXk4TrBcUDdfUYgVrcFlD/yWr9Nun62n6usZ5/ tffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=asFGQVliKJEwPcP9wqJ7Eofj4vh5WSFipik/QMyXf6g=; b=LddE/fACbn/MtLICnUn9W2XqDyV83v11JHhDW11xChivg7F78d40rXwxn8P6HgG4IT vIZ5q9KzCTkWadf+Iii/DjjzDkBKrjdw7pp0s9HUlnuCgQrypye1S7kf1Kbd6BlmuMlH Re8ALVw/f+ZvhhBNeIJVLmZhkdHugAyV1/Xr5rCq+Ja0uaPnYJh12B2SHcMXV/kbe1IH 91rBMGGQa8awaRtMox1sATMhXaa3gDQM69znSCKjoFBAx744fMLzVPqm3w5Ka4VeXpRA mj9fNmJUKcXph+IMpXSdCFzQz2irwi7uwj4DDL/4OMbTmDPILnMjaknGG8NUPC/hUuhp +APQ== X-Gm-Message-State: AMCzsaVrGbi2+te9H95BG17ZOrNibnEdvxTbyXlJKxRR0dOpD9/gvihn 7cFpVza+CklYqQ3VB6sM/H7vOOQP X-Google-Smtp-Source: AOwi7QABUcz+LgscSztb6Pe+/f4ryLeWvI57uDxLmhZwDUBfw86eaLv9BbrOg9npM74GwOkhQLYDGw== X-Received: by 10.28.185.75 with SMTP id j72mr15023759wmf.138.1507732609577; Wed, 11 Oct 2017 07:36:49 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 69sm15969747wmp.11.2017.10.11.07.36.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 07:36:48 -0700 (PDT) From: Adrien Mazarguil To: Ferruh Yigit Cc: dev@dpdk.org Date: Wed, 11 Oct 2017 16:35:28 +0200 Message-Id: <1c122466a4bfb311eed32c76ec40228427ea0f85.1507730496.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 26/29] net/mlx4: remove unnecessary check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Device operation callbacks are not supposed to handle a missing private data structure. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c index ebf2339..661e252 100644 --- a/drivers/net/mlx4/mlx4_ethdev.c +++ b/drivers/net/mlx4/mlx4_ethdev.c @@ -750,8 +750,6 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) char ifname[IF_NAMESIZE]; info->pci_dev = RTE_ETH_DEV_TO_PCI(dev); - if (priv == NULL) - return; /* FIXME: we should ask the device for these values. */ info->min_rx_bufsize = 32; info->max_rx_pktlen = 65536;