From patchwork Thu Jan 25 16:18:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 34483 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 672411B1B4; Thu, 25 Jan 2018 17:18:55 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0042.outbound.protection.outlook.com [104.47.1.42]) by dpdk.org (Postfix) with ESMTP id 260D11B04C for ; Thu, 25 Jan 2018 17:18:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YbDxmyxWFHV86fthOq9XPGY0KGCDxRKxZ+xOx5MuKnc=; b=WnvopStujGaMF9TvgXRq2hU56rA9/T/jBZ3/23bLBwPL4ZLEgpDUF1Eso1A4got9GJBXW3vi2Pe/wG10v9DT8lS3wKyg5ly2sjQxfO3RuC9ACOZRXktkj/HDZ1qR8xsPnUXBscXYqaRguh0BSdZHx8TwlJR2ihcZeS495bafi/g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:18:42 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, Xueming Li Date: Thu, 25 Jan 2018 18:18:01 +0200 Message-Id: <18e7587b726a330bca167c3e16896bcd887afa1b.1516896871.git.shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:4:54::19) To DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 91cb7abc-7424-4774-9687-08d5640f4d61 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3143; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 3:lVzQ3v8/q0gnfnswDQ8BwNQ5l72XeuK5ApUJVlEE5G7pKk4lXJMOR16cWk3JgUCGZYcy7vLFHLC3TJBwS9JdawxqfiPPbjHkdkc1rO7FRsmNTvqRt6UXkBO3cfRFYIxGR6W/oGiUXwn8RBiQPn0JsXjXA8wIF910yL0nlzVk3/E5zI0imM9EhTKsIl7CGqTDfZBqOzSK3sy4XfIBozv1MrMioytQzFkWEhcSkwoq3gqsspOkCdDs11TmYYhSs+Hk; 25:91L+M8NZly3MbwzZMtFoo/OK2ffRx6JiweXNJGGCllocLCSMEPs2QDDSUBrKeKO5l2KuC5kEpJoi/yZqg2XSbaD2qORTtsLfe1qPuULaktFER+n634cyizn8cYfj4mVzPy5WQw3s0GV3LvvPyDTHM48XGZDuYJBGvjdEGfF2jtZ1Z9AxQxGKISaKF+TOEFXCOOmVysnPqMkP4YviWzMWXJXwN48CvLpEH8r4X1tBkb43AgayEJWBk9Ww5sFt0yYq+KQaMaQ2E4ZfbhFalZgBzgGl0VomXrtC0nih5oS+L0K9GBCFdEHsHtt8LF3nRviB5HWqcds1TP5FdFGv/IjS5Q==; 31:dHqAsn1mSD+ask1nOujXKSGe8APQXYY7X1ZTd5oL796UL3YVUTQrDe9Q8TcD0ufltpFI6DTJZZcdd2Psch4lxtkE0aX/V+l27S3+09yADT2N+onURLyJXLpNnHvdCEJKmZoDEn76VDcluPkEJwCqQ4DlVELZ+LuFbmCuP8hNm1pxFCbrpb8h+/QLMCYyhOVh1cVfZotqxnQEfD/qzJcqfTvQKcbYhE75xEdnNAhrjiA= X-MS-TrafficTypeDiagnostic: DB6PR05MB3143: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 20:WrHMCiJG1PFojYWOmbyt1TCiaO5fZBWtMpSlPQXGCnvo8xlOZT3phBjMnGEF1hjkrwunN73Sj2JaWJ7DW9LLBYR0zl40vpaqkzqYLnkz+JduNeeB5NAezlCf4zQZUO291KoXxMfXPqgdR8z2tl2Ah55srXxVUo6DNlvJU5/jUrzPQNUzjfdvFcV2xzslpRXyY0bkpsLMYwxDUsLgDeb+VxFUR8zRBv2292l5HflEG54a8DefRDUqHIP8W4nbrr4Dk65t7L/P76migXrNGFkYO2t4eGiFt4WOpLfb1imSF3+ezcAdQUrxEnHw0lXhFCv9DPKhL5PuCAUhyXjB2spbSdvjG+EM23cqvxhQQWBtFQCIz0VGTBTB/YLc0J6YMLZ46bOO0O3KJm+kIWZyhuVNrze+unvaZO2l3UTSjKQfBz2xVy/L98qlDHpXihKt06/yKNUS5I3Rl+24xaa/p0o3aG1qs537wiL6T6KIQF385w2pIG+F0bAP9axyvwOeKbfV; 4:r16MfQ6HEj0/vwyi7cs98GAqb2WORaYvlwOUCbaGI/7Pu6IA0EXkouDTYqj9ArIVXaW6HLLP0B8RM8zSgsbRTQV6cAvs5pT6DhJPHBRUjLWYoANKToEO59dxyQmcLWAk3kQPD6SbcEP4aTXRmkifahS0EM3r+GORgFGxuKawSv84YsEcxtStJukqx2QDw7MQsOZZDPWTMyHdVJnRu7SgS69XFoBrKRMWBHqqgWzlHlHaI368VxkTwYcAQAxbUSg9jmwLUWYkidgMHPStid4e4A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR05MB3143; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3143; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(189003)(199004)(53936002)(478600001)(21086003)(4326008)(107886003)(6636002)(6666003)(47776003)(25786009)(55016002)(106356001)(69596002)(86362001)(36756003)(2906002)(66066001)(8676002)(16526018)(16586007)(81156014)(81166006)(8936002)(3846002)(105586002)(48376002)(50466002)(26005)(316002)(68736007)(6116002)(51416003)(7696005)(118296001)(76176011)(5660300001)(7736002)(305945005)(97736004)(52116002)(59450400001)(386003)(2950100002)(186003)(50226002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3143; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3143; 23:echHtp8eN3u0HYECG+650VarPEPyJYPtub4DOJ0zb?= BADwR/87r4T6o/3dy6WcV6UoJRXf0ePc9hNzHn9nMlt9+lPgIV7J5/0JWVsgp9xfMiNA9MLhdhbKCwbzytirZ7g6u2fndyfl+ARjp5+xZdMkOHXnxlgSd5vfLOh8HfFp+uv4Rblmrze+PNFyKFz+Q3YsNOceu14glOr8kcIRAj3HO5HDgevblfGbVbSIYAz2SH7GqG3Gnk97VhhfqwcSBBuDpOtdLPpNhYDexsEchP2xt5AxQ3pIuEZ5u9Fj+AAZSir89fM3pKP52c7ZTJ2pQouwvMhLQxlAObvR5eIj4YdyLH6spxS/ODsSxrQlNhrnykz0habbsitIZhJZb389YdC0R4O9qz1WGfEBqXTcpZRY5GqYXIMez9U7uT5168p0RCnAFn/vI4WwtnZLBIZ+TUm6VsQHfZz+/wZ8QJL0osWRtA2UHIamIalV8Vwet1HBoPc34UPyVld4pMQjPvaD7H8dZSQYuPhsYKH3riylExeL25fRNxEKwSNr+UKTfWN4MeMTQc/Up926i1XHEV22HSHnNF0uyq65k+bLdaR8yWmiOZaaPBBkx/Vth8N9u/BK3jdENsBIwXIDpUKD469L4wiceryCXvqKLvcre186YrBlMdn3eO7cKVtE2wdmqx9zsxAjwokMBjyhRDl8ApaQBUV+w4FnJzwOTHWcXjaUCblqRz2hDVcjh+vtfSQ5I4JWOZQf8BFwVEvCZEJNGZXgS7BpG0cjn8I5JTex7LWUTHWQHDq99CeuyzPYYC72IuT9heT92VrFWE0j5FlW7xczfXBQi6B+uDr7VF0psRBDib44im72ov8S0KzMeaqZCo1GwQiLmxAFhzun1G5pYuZI5GknctMqVvqV+ljBw1qLjUdFjggQ9gHeg33pwcFJlRJn6Z+EN6ppZ3l96IcamomGYFIDtXS1X3LDkuSsszuXO9r3N9bWvpWpJMpk7+BUS5v2sWmD/KMG1EA7jk9t0mydZ1cWag6SPfNkSjk9tHzt2jQZRUAEnrumZAcFaE+McWcZ/U3+jX7gM3uHoNtOddPwHi1fkqQCLzYZvtoMGnykPNDqVYWHIQA8lzdPZ1N8T6n1rh3YnaiMatdJ/MgCojEpSTK5m1e5nS245S7siWLBx2k7lyNirwc+Duo2H0yGPr14a9CC7YMxup+1cr3yMQCTdGSyoURJ0QvWUCh/icfGZRZnT64IYGbKzCJ8+nyN1gGb6eXrCHx5WEVr2pN5DYvOHaY1LXSA1BsPg0PUnJQ6tvoAg== X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 6:paf48D+xvzT7aZSK2uikhWDyybeZW4xlvUrvcv77y7t8ISI8ewsZykjkkmtS9fchkhqjcKgtwP2CI2vYXkCKQG7vMKWZwJ8dnmkRLMySL7lpMy5eo9v91TTX7VYRHVFcfceIywXfNmYTXjQgtWbt/Xm83Z1M3hhkFIRXy/6lxtfr8jMYIPjDliIqina8kN2OUe6POg5Yexvnu4LkmEbnjdaUBrqZFcgKIy6+t0bFBotzicaff2AYYwEJJ9k2hB+9NjvhAqTSQh5HGG1waMM0jfxRYlrouapCyyQnB+FYDRTQEiHpxLOpYQ8+UzEdjSpLNI12Km2awbx14P1wp0NEQTLX3qhT8hIFEl2R1Il0afY=; 5:QNjMzMgTa3CsSZdmL1AVyoEjscsovH9k/5A9GTx1Zw+Xm60/RkpZaQ4NuTLqidaD4re7RIh3KR5Et815NeMkg5mB40OweBoq6afCRQdPAWJsxFUxz1NPgK+u5CGrmw5Yof8W/iQ6AXH1a2ubNdSGXgOqv5K62rUG5WiA0REAtso=; 24:xSInwYgRelm5Kj3yFFABB8NOn9Qz3ycqJUi7GJSiGI+2vaoJLzHqs+2YUg+7n4CjvgG5v1C8aaxQVwuh8bFGswQwNqELcfY1YihBJqfjB8g=; 7:4BdgMqeFCga/WEc2ZcS9Lq679JRw7j74OkH03EA+eRNOPC5UGZ/tdkPWTrwKPBNbZNd32kfJOg3RPAE7G0IpdSsNW4Z+n0lRaianoNMorGC48LKf9lVjKaDG7W1jdPkq6Q53HWuOvWVdyXPAjjShZW24sMABaG9Cs35CWdnAoMvPVKioEk1Mm2uoQIu8B9Nq15mSlMaq96RRzYk0T3hiKeuAYm3dNdS04UQG3a07KLTJem/yIZhTOZX+ng7TpzNd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 16:18:42.2540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91cb7abc-7424-4774-9687-08d5640f4d61 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3143 Subject: [dpdk-dev] [PATCH v2 4/6] net/mlx5: warn for un-successful memory registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Memory registration can fail, add the proper warning for such scenario for it at least to be visible in debug mode. Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 26be206a7..e6d163a59 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -576,6 +576,11 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) if (mr) { rte_atomic32_inc(&mr->refcnt); return mr->lkey; + } else { + struct rte_mempool *mp = mlx5_tx_mb2mp(mb); + + WARN("Failed to register mempool 0x%p(%s)", + (void *)mp, mp->name); } return (uint32_t)-1; }