From patchwork Thu Jan 25 16:18:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 34485 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1196C1B1D9; Thu, 25 Jan 2018 17:18:58 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0089.outbound.protection.outlook.com [104.47.2.89]) by dpdk.org (Postfix) with ESMTP id DD3CC1B1A9 for ; Thu, 25 Jan 2018 17:18:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YQq3hKZkk/jSa66E1iTSnJltNOZzmP7yHaEIvZhYG6Q=; b=xyZ7AliOVr28fBayiITBv2Friubq4ZrF1pw2ijWheuEWLtbvnVhVXm9Lr9SUMhjOxAyDSqVqWIbhZV2InV71rwq8RwoNvna66TDaypH2XqsE8qQSqP462baDRUhVPokVl8CJ2eipLK13cF7DYsEf/zqhDnhx5XBW3w9A41VVcCM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:18:44 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, Xueming Li Date: Thu, 25 Jan 2018 18:18:03 +0200 Message-Id: <17ffe3deb8270e6966dd2c09d7d6ff546f28c655.1516896871.git.shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:4:54::19) To DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4e1c31f1-fd00-408d-3aaf-08d5640f4e89 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3143; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 3:2H40wEDFDpYY3AvPcyryW+YLxhtryv/KGTNqdIzi5M9b7aVLYw5y7RoC/RCd2DIRIhSxrSpX8x7DfkbsNzYSmbcsovHFJYqaOiB8Om9EDmbCWmtiGlbS8C4Oa3eDn3KDnBi9WdzpMEwJKtoidDI7jOkKy3YRQJGzRdj2LhHOjq46FzqT+temxY30ks4niITFZyPigKkgnUTZXP48yydt9L5FyiwvIOTymW63DXXCn972cUHf1ZTRO7AkwTY50NhV; 25:6fm09me4ZUvXCGtZ4HwijepgDMveTCblUt8n4DEnMWSUMgeimFoKxVoPwYvyqUTOtnZnV5Sr7x3eOVxHvUL6HNKD5kjmKNEKl6kvoibIdu7G/kLuFzD7bZcB0J6vEQoMSkMMliNDDRLhZzvyrdQmraZ2PJS5JiY7K0dsmB10o80rx3AI6pATwtoqE70Uu4eK8+/SmW0rbDcckh6mdcSDaG4PpffNJ8BlJndIk1Hzzjz9vPEnVS6N934gySk+iXG7rTR5JEHB+psfU9ySLup8AeGxUFrsYQXYPxVJYoWMmLV6DQL4g1uR4F8JQK1ChrOJ8kfJu24+z24mSChcM5TQSg==; 31:37TvjHmn3hyp+95u//42L83PIpvi1LUg0akRAQwIEKLUuPyDiuNohgZF8p89CXm00SSVDgfTsGNFCl0S+9oF7FwBRmB1Fq6/KsI3uidKpIM4tqxkSPZ9F9p9tEmyZM2VeWV2D0irX+8SJ0DqWbdRlTvsSHwEVhHmfE1CEdm0ghgo56VlOSCBHDTu8WaXD91pjDj+r7wyFPgkkr7+MLp8O2VOAjUhTF7K8DarBjqqwVM= X-MS-TrafficTypeDiagnostic: DB6PR05MB3143: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 20:nO35wJ30MSHqH3mqIigGYrVXJCH76Kyj8ZBrO3YmwEkO+/SzfZ4UVSaO23J4IkFE1jzUFCJg+3XgC41DiZhPqZLv5QMaXFxYKWqAR/rcF+3Kgq13QSwdf3oDTDbZDJcEZX1nqRjDYYicIQLbQouc1OT2ECjpw5crWe2TAqf3Wn0hilQEzhH/mrG6qFLHBae1NTXoyiaEyjCZKNIzHOhrWet2IJF2DMZ2SV/yf1b/+aPAJz6Ui2eu1IivKY4NTw58zpJj1mJY1VvoJg95OXTfxKjS3+erb1SCFrhtIugNB7UMhdBVmUabh6Rcg9at9EITv4RfK/YSXYTPf/KENtznJDAjIEwO2Ps/TcJxjmdylL9uocL3y7Y6dtiO7SP7PqIpxvwPBAPw5MsUCBWebkbqLWqyQeM/mVcgym17vZHb3FilLor4Udm9pJ38+OD75vpaR1SCni0U4QGfmw88hgOpZND12W1oyslr54LsFrKp/ZDHZQ2WR4WSrp/bounU5U/Q; 4:nGnZ99oe9QmCjEvL+ax7ZItMicfFDmESphvz5KzkPhuYlfKXG6Kn5+FbhSnDlTaMz0Lju5gZ93Rtuu4Q9AMSTjRfXawmhuuoR4zRtxFBgSmz6FcVQog91QNZIm5B9qGIFjvmvyogVl1PcUzBtQNYB3OQiNtMJA5Y7lXmBnhecdumkbCcr2IYOE7NM9D6s/cNZOqyg2SgRyj7zUWKePRdVVlICcS3TMQU2ThOah1AMUyG5Jti/YOCHb+ED6tGpqiXml144mMz/aq0iOgXrPH7BA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR05MB3143; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3143; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(189003)(199004)(53936002)(478600001)(21086003)(4326008)(107886003)(6636002)(6666003)(47776003)(25786009)(55016002)(106356001)(69596002)(86362001)(36756003)(2906002)(66066001)(8676002)(16526018)(16586007)(81156014)(575784001)(81166006)(8936002)(3846002)(105586002)(48376002)(50466002)(26005)(316002)(68736007)(6116002)(51416003)(7696005)(118296001)(76176011)(5660300001)(7736002)(305945005)(97736004)(52116002)(386003)(2950100002)(186003)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3143; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3143; 23:5I2jbgd8VpfoisEgqtSr46Lv+TDDLmSrx8ZJOt1dw?= kwG1MXS4AEbL352ibplwitw2tvxRsAgS28gzLgyvV0AaKE4B/HHbo+XxXEV0R6f4GIRzSzYceCclA9vEDueak9J4cXQZy+e0PEow2zknO40lHh9b9ouQ6wrcXwic8IszuoJ05oA7eJ68o+6PoSVvxDxApUk8NAwPVVM84OfJ80pXtUBP2OO0up930qlhPX7K0tT7loeWhzMcCzp9BXTY5vm/8sbWIiyX+LTOWhCq2XkyHvuKJKam9KCXZTuOxutdNU4g0zmv296rTT2RFTH228ysBK++M77c3EUPZyh4cxqeEex0UPdrEdzQaDbPuZ558dQee/nGTEoGaxLmVLYUnhqdVZr3Wlf1pfrMSM386iRy5M/qlrwrH+vDSz0+NPy52lukwpuxMs/vHdtXk0vHdg4MhGiR9Jd91htjwR2xyh7dJXWEqWgsXM70Q7UfpsMltCVJEFE4sgJFDPoqr6EZK7YbBs9NkB+HaKFk1jufDc6qa6ww3/ch66Zhug6DzHNAvGnZSrOuk6GNa7mc1cDStUpVBOWB1y46OtouSwsH7X7KxcF8AAAyjS2NfRgzCMKRUbziEv5d1P1MnXrJoX/ukynhJD08t4JTmmURda56QAvr2lQsF+8ZEAMPu6m9dSI/SJN1uNIV5ZVvgFZ+G4voGZc7oqrlkBuv/RFZfkXMlO9fcA38/J2mVtLSCx+oW6CJd0IS4kQavDruYkQyLeJUQ9dK8nHQsNozZyNCaVxzaFfABTqpyAi6xmnz7LuuJ/05MCZ4TKPSIOI948FYFzWjlvPjNZt3l3AdTbHm7H1ppjHdFsWB3G6Lh5UHl4FPGs8DiRJBvCyio4LqSg+Vw1gDZMEMUZXx73IA4AxLr/avtrj/5eeqwV4c44GFDqexiOpLQvlEA0JqcRK7wNbzKShI1GHsp/ZukJIpcWepaRplHtKMuIkShEl0PIpBSuhsxBoEytU/taK2QA1qMTOtIXLHi3j3QOx1LgdAdH5t2XGxv4ONMi2vz+VgBIecuVbFXmwKiF5OVKRV6SHr2OmQd2WWKPvmk2RW2lE8ODqpd3pVZe1nMxuLHAgtGi4b9eXfxhX5LXGjPvLmyIRZrHV2K90LoQOW2ydu8BcoQBGcI8KnOgPIRCXSFlXcajV1a6cMlqbu7I= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 6:DEhLXRxEJJEX6x2c0KEC223IOFS0RMXXuI2nBEz4DBh8UvGjArmx+eS+oAdDiQ2xDAsj+kP6nPzN455Urr6YoZxsmar6Ytfpjrm0uvtmmxcL4vyzgBGL3bYs9h0bPvb2Z1qVe1tLf08hBXPV3a0IV7IHgls8SGGHt5KvUcCITTy2FuoCsAokIH1I3W7KnNf0Br1ITG3STh9+vgqiCebcgGNe6WZPEjTLrjymiIX3lxM7glYIN95Wfp0WhfCEXzD5n39cPnJQYkpvTVmbE6IZUFWOYFWNfrGe5Ph/6EaWnoGVqr2pX3kuLLfJJ0sZaXG+W+vi/3LPqxU9WhbHKweO79Zwvpx0IqeQmIgF1I5zKoM=; 5:fTKjO1rVWpyH7EVCuiIjLPiT065dvEKwRTZ7yLbvA6IfyQdBoTp+5cqxmSWlXqI2oQQZWfhi4xW2g+YH+O/sSXMy14FAcHUrNXcPkgc8V8WjsKWqERKsIkb+8HY+pVudb241h/NmWerc1U/9TT77FFgh7VfFFT68cZiMu2IXEeo=; 24:zUbsqnTi77ApFAB9EoI3rGHjqwrm/rA+g4BEG0EfW9qR0RZB/eiAv5lRZYwrdnIoikgZoOZeVM3t5pQTbTAKMRW9zzUCwo1FVp9Dixz4Pyc=; 7:J66KRTOgmShbMDy3Zw1x82GzAqqpa61T2OfI8UhgnPE8AFwUVijakhw41qw6xQIuJ4OQqdlZcfipaopUscSMHxyP+AKOdu2i8pYVGwQf9N6OqcEMyVKrjNW7m8B5e76vRdXM7wQT7ShTGjF72zPOBE1mbArd9lrJZKLkrySNGdCG2gj2H856rn1B5Kh7mvu1dyatay7moz224jJ4vOPRAtQvUNlUsDBqtkGscN0L6hdD5neLkVGkp9HqDj/nCaMH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 16:18:44.1915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1c31f1-fd00-408d-3aaf-08d5640f4e89 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3143 Subject: [dpdk-dev] [PATCH v2 6/6] net/mlx5: fix Memory Region boundary checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since commit f81ec748434b ("net/mlx5: fix memory region lookup") the Memory Region (MR) are no longer ovetrlaps. Comparing the end address of the MR should be exclusive, otherwise two contiguous MRs may cause wrong matching. Fixes: f81ec748434b ("net/mlx5: fix memory region lookup") Cc: yskoh@mellanox.com Signed-off-by: Xueming Li Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 7e7db0e8c..2919a747c 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -552,7 +552,7 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) struct mlx5_mr *mr; assert(i < RTE_DIM(txq->mp2mr)); - if (likely(txq->mp2mr[i]->start <= addr && txq->mp2mr[i]->end >= addr)) + if (likely(txq->mp2mr[i]->start <= addr && txq->mp2mr[i]->end > addr)) return txq->mp2mr[i]->lkey; for (i = 0; (i != RTE_DIM(txq->mp2mr)); ++i) { if (unlikely(txq->mp2mr[i] == NULL || @@ -561,7 +561,7 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) break; } if (txq->mp2mr[i]->start <= addr && - txq->mp2mr[i]->end >= addr) { + txq->mp2mr[i]->end > addr) { assert(txq->mp2mr[i]->lkey != (uint32_t)-1); txq->mr_cache_idx = i; return txq->mp2mr[i]->lkey;