diff mbox series

examples/symmetric_mp: log/ignore promiscuous fail

Message ID 1747766224-31511-1-git-send-email-mamcgove@microsoft.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers
Series examples/symmetric_mp: log/ignore promiscuous fail |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-marvell-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/aws-unit-testing success Unit Testing PASS

Commit Message

mamcgove@microsoft.com May 20, 2025, 6:37 p.m. UTC 
From: Matthew G McGovern <mamcgove@microsoft.com>

The example apps have a few different failure modes when enabling promiscuous mode:

- testpmd will warn about the failure and continue.

- l3fwd has a flag '-P' to explicitly require promiscuous mode.

- symmetric_mp will exit with an error code

This patch changes symmetric_mp to warn and continue.

Signed-off-by: Matthew G McGovern <mamcgove@microsoft.com>
---
 examples/multi_process/symmetric_mp/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon July 9, 2025, 2:29 p.m. UTC | #1 
20/05/2025 20:37, mamcgove@microsoft.com:
> From: Matthew G McGovern <mamcgove@microsoft.com>
> 
> The example apps have a few different failure modes when enabling promiscuous mode:
> 
> - testpmd will warn about the failure and continue.
> 
> - l3fwd has a flag '-P' to explicitly require promiscuous mode.
> 
> - symmetric_mp will exit with an error code
> 
> This patch changes symmetric_mp to warn and continue.

Why not doing the same in examples/multi_process/client_server_mp/mp_server/ ?
What about other examples?
diff mbox series

Patch

diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index f7d8439cd4..974fed2cd5 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -275,7 +275,8 @@  smp_port_init(uint16_t port, struct rte_mempool *mbuf_pool,
 
 	retval = rte_eth_promiscuous_enable(port);
 	if (retval != 0)
-		return retval;
+		printf("Error during enabling promiscuous mode for port %u: %s - ignore\n",
+			port, rte_strerror(-retval));
 
 	retval  = rte_eth_dev_start(port);
 	if (retval < 0)