diff mbox series

acl: use common top-level variable for easier maintenance

Message ID 1740768356-29954-1-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series acl: use common top-level variable for easier maintenance |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing pending Testing pending
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS

Commit Message

Andre Muezerie Feb. 28, 2025, 6:45 p.m. UTC 
Updated meson.build to use common variable cc_avx512_flags.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 config/x86/meson.build | 2 +-
 lib/acl/meson.build    | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

Comments

Bruce Richardson March 3, 2025, 3:19 p.m. UTC | #1 
On Fri, Feb 28, 2025 at 10:45:56AM -0800, Andre Muezerie wrote:
> Updated meson.build to use common variable cc_avx512_flags.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  config/x86/meson.build | 2 +-
>  lib/acl/meson.build    | 8 ++------
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 

One suggested improvement below.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> diff --git a/config/x86/meson.build b/config/x86/meson.build
> index 47a5b0c04a..12befd4d73 100644
> --- a/config/x86/meson.build
> +++ b/config/x86/meson.build
> @@ -14,7 +14,7 @@ if is_linux or cc.get_id() == 'gcc'
>      endif
>  endif
>  
> -cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw']
> +cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw', '-mavx512cd']
>  cc_has_avx512 = false
>  target_has_avx512 = false
>  if (binutils_ok and cc.has_multi_arguments(cc_avx512_flags)
> diff --git a/lib/acl/meson.build b/lib/acl/meson.build
> index fefe131a48..6ba53fbba4 100644
> --- a/lib/acl/meson.build
> +++ b/lib/acl/meson.build
> @@ -55,15 +55,11 @@ if dpdk_conf.has('RTE_ARCH_X86')
>              sources += files('acl_run_avx512.c')
>              cflags += '-DCC_AVX512_SUPPORT'
>  
> -        elif cc.has_multi_arguments('-mavx512f', '-mavx512vl',
> -                    '-mavx512cd', '-mavx512bw')
> -
> +        elif cc.has_multi_arguments(cc_avx512_flags)

existing variable "cc_has_avx512"?

>              avx512_tmplib = static_library('avx512_tmp',
>                  'acl_run_avx512.c',
>                  dependencies: static_rte_eal,
> -                c_args: cflags +
> -                    ['-mavx512f', '-mavx512vl',
> -                     '-mavx512cd', '-mavx512bw'])
> +                c_args: cflags + cc_avx512_flags)
>              objs += avx512_tmplib.extract_objects(
>                      'acl_run_avx512.c')
>              cflags += '-DCC_AVX512_SUPPORT'
> -- 
> 2.48.1.vfs.0.0
>
Andre Muezerie March 3, 2025, 8:26 p.m. UTC | #2 
On Mon, Mar 03, 2025 at 03:19:49PM +0000, Bruce Richardson wrote:
> On Fri, Feb 28, 2025 at 10:45:56AM -0800, Andre Muezerie wrote:
> > Updated meson.build to use common variable cc_avx512_flags.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> >  config/x86/meson.build | 2 +-
> >  lib/acl/meson.build    | 8 ++------
> >  2 files changed, 3 insertions(+), 7 deletions(-)
> > 
> 
> One suggested improvement below.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> > diff --git a/config/x86/meson.build b/config/x86/meson.build
> > index 47a5b0c04a..12befd4d73 100644
> > --- a/config/x86/meson.build
> > +++ b/config/x86/meson.build
> > @@ -14,7 +14,7 @@ if is_linux or cc.get_id() == 'gcc'
> >      endif
> >  endif
> >  
> > -cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw']
> > +cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw', '-mavx512cd']
> >  cc_has_avx512 = false
> >  target_has_avx512 = false
> >  if (binutils_ok and cc.has_multi_arguments(cc_avx512_flags)
> > diff --git a/lib/acl/meson.build b/lib/acl/meson.build
> > index fefe131a48..6ba53fbba4 100644
> > --- a/lib/acl/meson.build
> > +++ b/lib/acl/meson.build
> > @@ -55,15 +55,11 @@ if dpdk_conf.has('RTE_ARCH_X86')
> >              sources += files('acl_run_avx512.c')
> >              cflags += '-DCC_AVX512_SUPPORT'
> >  
> > -        elif cc.has_multi_arguments('-mavx512f', '-mavx512vl',
> > -                    '-mavx512cd', '-mavx512bw')
> > -
> > +        elif cc.has_multi_arguments(cc_avx512_flags)
> 
> existing variable "cc_has_avx512"?

Indeed, that is even better. I sent out an updated patch.

> 
> >              avx512_tmplib = static_library('avx512_tmp',
> >                  'acl_run_avx512.c',
> >                  dependencies: static_rte_eal,
> > -                c_args: cflags +
> > -                    ['-mavx512f', '-mavx512vl',
> > -                     '-mavx512cd', '-mavx512bw'])
> > +                c_args: cflags + cc_avx512_flags)
> >              objs += avx512_tmplib.extract_objects(
> >                      'acl_run_avx512.c')
> >              cflags += '-DCC_AVX512_SUPPORT'
> > -- 
> > 2.48.1.vfs.0.0
> >
diff mbox series

Patch

diff --git a/config/x86/meson.build b/config/x86/meson.build
index 47a5b0c04a..12befd4d73 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -14,7 +14,7 @@  if is_linux or cc.get_id() == 'gcc'
     endif
 endif
 
-cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw']
+cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw', '-mavx512cd']
 cc_has_avx512 = false
 target_has_avx512 = false
 if (binutils_ok and cc.has_multi_arguments(cc_avx512_flags)
diff --git a/lib/acl/meson.build b/lib/acl/meson.build
index fefe131a48..6ba53fbba4 100644
--- a/lib/acl/meson.build
+++ b/lib/acl/meson.build
@@ -55,15 +55,11 @@  if dpdk_conf.has('RTE_ARCH_X86')
             sources += files('acl_run_avx512.c')
             cflags += '-DCC_AVX512_SUPPORT'
 
-        elif cc.has_multi_arguments('-mavx512f', '-mavx512vl',
-                    '-mavx512cd', '-mavx512bw')
-
+        elif cc.has_multi_arguments(cc_avx512_flags)
             avx512_tmplib = static_library('avx512_tmp',
                 'acl_run_avx512.c',
                 dependencies: static_rte_eal,
-                c_args: cflags +
-                    ['-mavx512f', '-mavx512vl',
-                     '-mavx512cd', '-mavx512bw'])
+                c_args: cflags + cc_avx512_flags)
             objs += avx512_tmplib.extract_objects(
                     'acl_run_avx512.c')
             cflags += '-DCC_AVX512_SUPPORT'