diff mbox series

[v9,23/30] examples/ptpclient: replace packed attributes

Message ID	1736383715-31703-24-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Andre Muezerie <andremue@linux.microsoft.com> To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie <andremue@linux.microsoft.com> Subject: [PATCH v9 23/30] examples/ptpclient: replace packed attributes Date: Wed, 8 Jan 2025 16:48:28 -0800 Message-Id: <1736383715-31703-24-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1736383715-31703-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1736383715-31703-1-git-send-email-andremue@linux.microsoft.com> Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix packing of structs when building with MSVC \| [v9,00/30] fix packing of structs when building with MSVC [v9,01/30] devtools: check packed attributes [v9,02/30] eal/include: add new packing macros [v9,03/30] app/test-pmd: remove unnecessary packed attributes [v9,04/30] app/test: replace packed attributes [v9,05/30] doc/guides: replace packed attributes [v9,06/30] drivers/baseband: replace packed attributes [v9,07/30] drivers/bus: replace packed attributes [v9,08/30] drivers/common: replace packed attributes [v9,09/30] drivers/compress: replace packed attributes [v9,10/30] drivers/crypto: replace packed attributes [v9,11/30] drivers/dma: replace packed attributes [v9,12/30] drivers/event: replace packed attributes [v9,13/30] drivers/mempool: replace packed attributes [v9,14/30] drivers/net: replace packed attributes [v9,15/30] drivers/raw: replace packed attributes [v9,16/30] drivers/regex: replace packed attributes [v9,17/30] drivers/vdpa: replace packed attributes [v9,18/30] examples/common: replace packed attributes [v9,19/30] examples/ip-pipeline: remove packed attributes [v9,20/30] examples/ipsec_secgw: replace packed attributes [v9,21/30] examples/l3fwd-power: replace packed attributes [v9,22/30] examples/l3fwd: replace packed attributes [v9,23/30] examples/ptpclient: replace packed attributes [v9,24/30] examples/vhost_blk: replace packed attributes [v9,25/30] lib/eal: replace packed attributes [v9,26/30] lib/ipsec: replace packed attributes [v9,27/30] lib/net: replace packed attributes [v9,28/30] lib/pipeline: replace packed attributes [v9,29/30] lib/vhost: replace packed attributes [v9,30/30] eal/include: deprecate macro __rte_packed

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Andre Muezerie Jan. 9, 2025, 12:48 a.m. UTC

MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro __rte_packed_end to restore
the pack value prior to the push.

Macro __rte_packed_end is deliberately utilized to trigger a
MSVC compiler warning if no existing packing has been pushed allowing
easy identification of locations where the __rte_packed_begin is
missing.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 examples/ptpclient/ptpclient.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff mbox series

Patch

diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
index 7b6862d951..9c64313fa9 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -56,22 +56,22 @@  static const struct rte_ether_addr ether_multicast = {
 };
 
 /* Structs used for PTP handling. */
-struct tstamp {
+struct __rte_packed_begin tstamp {
 	uint16_t   sec_msb;
 	uint32_t   sec_lsb;
 	uint32_t   ns;
-}  __rte_packed;
+}  __rte_packed_end;
 
 struct clock_id {
 	uint8_t id[8];
 };
 
-struct port_id {
+struct __rte_packed_begin port_id {
 	struct clock_id        clock_id;
 	uint16_t               port_number;
-}  __rte_packed;
+}  __rte_packed_end;
 
-struct ptp_header {
+struct __rte_packed_begin ptp_header {
 	uint8_t              msg_type;
 	uint8_t              ver;
 	uint16_t             message_length;
@@ -84,39 +84,39 @@  struct ptp_header {
 	uint16_t             seq_id;
 	uint8_t              control;
 	int8_t               log_message_interval;
-} __rte_packed;
+} __rte_packed_end;
 
-struct sync_msg {
+struct __rte_packed_begin sync_msg {
 	struct ptp_header   hdr;
 	struct tstamp       origin_tstamp;
-} __rte_packed;
+} __rte_packed_end;
 
-struct follow_up_msg {
+struct __rte_packed_begin follow_up_msg {
 	struct ptp_header   hdr;
 	struct tstamp       precise_origin_tstamp;
 	uint8_t             suffix[];
-} __rte_packed;
+} __rte_packed_end;
 
-struct delay_req_msg {
+struct __rte_packed_begin delay_req_msg {
 	struct ptp_header   hdr;
 	struct tstamp       origin_tstamp;
-} __rte_packed;
+} __rte_packed_end;
 
-struct delay_resp_msg {
+struct __rte_packed_begin delay_resp_msg {
 	struct ptp_header    hdr;
 	struct tstamp        rx_tstamp;
 	struct port_id       req_port_id;
 	uint8_t              suffix[];
-} __rte_packed;
+} __rte_packed_end;
 
 struct ptp_message {
-	union {
+	union __rte_packed_begin {
 		struct ptp_header          header;
 		struct sync_msg            sync;
 		struct delay_req_msg       delay_req;
 		struct follow_up_msg       follow_up;
 		struct delay_resp_msg      delay_resp;
-	} __rte_packed;
+	} __rte_packed_end;
 };
 
 struct ptpv2_time_receiver_ordinary {